-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cplat-2024-03-03] Update spec for SoftDelete Restore feature #30558
Merged
grizzlytheodore
merged 2 commits into
Azure:feature/cplat-2024-03-03
from
lkumaar:gallery-2024-03-03-softdeleterestore
Oct 28, 2024
Merged
[cplat-2024-03-03] Update spec for SoftDelete Restore feature #30558
grizzlytheodore
merged 2 commits into
Azure:feature/cplat-2024-03-03
from
lkumaar:gallery-2024-03-03-softdeleterestore
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkumaar
requested review from
Sandido,
dkulkarni-ms,
haagha,
MS-syh2qs and
grizzlytheodore
as code owners
September 13, 2024 06:23
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
lkumaar
changed the title
Update spec with restore
[cplat-2024-03-03] Update spec for SoftDelete Restore feature
Sep 13, 2024
This was referenced Sep 13, 2024
@@ -2435,6 +2435,10 @@ | |||
}, | |||
"securityProfile": { | |||
"$ref": "#/definitions/ImageVersionSecurityProfile" | |||
}, | |||
"restore": { | |||
"type": "boolean", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we update at least 1 example to utilize this new property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
grizzlytheodore
approved these changes
Sep 23, 2024
microsoft-github-policy-service
bot
added
no-recent-activity
There has been no recent activity on this issue.
labels
Oct 14, 2024
grizzlytheodore
merged commit Oct 28, 2024
c08c937
into
Azure:feature/cplat-2024-03-03
25 of 27 checks passed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.