Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client tsp for AzureFleet #30238

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Add client tsp for AzureFleet #30238

merged 8 commits into from
Aug 26, 2024

Conversation

ArthurMa1978
Copy link
Member

@ArthurMa1978 ArthurMa1978 commented Aug 15, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Aug 15, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Aug 15, 2024

@ArthurMa1978 ArthurMa1978 added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Aug 16, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Aug 16, 2024
@SahilArora92 SahilArora92 added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 labels Aug 18, 2024
@SahilArora92
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2024
@live1206
Copy link
Member

@ArthurMa1978 - Please create/update your PR using the template.

Updated with the template.

@mentat9
Copy link
Member

mentat9 commented Aug 21, 2024

@ArthurMa1978 - Please create/update your PR using the template.

Updated with the template.

@ArthurMa1978 - Thank-you! You also need to fill out the intake form in order for the repo and reviewers to handle your PR properly. Please fill out both the Purpose of this PR and Due diligence checklist sections.

@mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 21, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2024
@live1206 live1206 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2024
@live1206
Copy link
Member

@ArthurMa1978 - Please create/update your PR using the template.

Updated with the template.

@ArthurMa1978 - Thank-you! You also need to fill out the intake form in order for the repo and reviewers to handle your PR properly. Please fill out both the Purpose of this PR and Due diligence checklist sections.

Updated.

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2024
@SahilArora92 SahilArora92 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 22, 2024
@SahilArora92
Copy link
Member

@live1206 Can you also verify that these changes don't break other sdks? Or would we need another release for Go and Python sdk?

@live1206
Copy link
Member

@live1206 Can you also verify that these changes don't break other sdks? Or would we need another release for Go and Python sdk?

@msyyc @tadelesh Could you help approve the SDK breaking change?

@Alancere
Copy link
Contributor

Hi @raych1, please approve BreakingChange-Go-Sdk-Suppression, the Go SDK BreakingChange is caused by the current PR and this is a beta version.

@live1206
Copy link
Member

Hi @raych1, please approve BreakingChange-Go-Sdk-Suppression, the Go SDK BreakingChange is caused by the current PR and this is a beta version.

Why do we even have SDK breaking change for beta versions and there is no GA version released yet?

@msyyc
Copy link
Member

msyyc commented Aug 23, 2024

@raych1 Why is sdk-suppressions.yaml not parsed for Python? https://github.com/Azure/azure-rest-api-specs/pull/30238/checks?check_run_id=29144749206

@SahilArora92
Copy link
Member

We don't have a GA version yet.

@msyyc
Copy link
Member

msyyc commented Aug 26, 2024

@raych1 Why is sdk-suppressions.yaml not parsed for Python? https://github.com/Azure/azure-rest-api-specs/pull/30238/checks?check_run_id=29144749206

Azure/azure-sdk-tools#8862 Not supported yet so we have to add approval label directly.

@live1206 live1206 merged commit 0629824 into Azure:main Aug 26, 2024
27 of 30 checks passed
@ArthurMa1978 ArthurMa1978 deleted the mgmt-fleet branch September 10, 2024 13:58
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
* Add client tsp for AzureFleet

* update

* Update examples with valid url to fix model validation failures

* Create sdk-suppressions.yaml

* update sdk-suppressions.yaml

---------

Co-authored-by: Sahil Arora <arorasahil@microsoft.com>
Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Alancere <804873052@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants