Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade compiler, http, rest and openapi3 library to 0.59.1 fix #30188

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Upgrade compiler, http, rest and openapi3 library to 0.59.1 fix #30188

merged 3 commits into from
Aug 13, 2024

Conversation

timotheeguerin
Copy link
Member

No description provided.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@timotheeguerin
Copy link
Member Author

Waiting for another hotfix to the compiler as well

@timotheeguerin timotheeguerin requested a review from a team as a code owner August 13, 2024 18:20
@timotheeguerin timotheeguerin requested review from JeffreyRichter and weidongxu-microsoft and removed request for a team August 13, 2024 18:20
timotheeguerin
timotheeguerin commented Aug 13, 2024
View reviewed changes
...ation/ai/data-plane/OpenAI.Assistants/OpenApiV3/2024-02-15-preview/assistants_generated.yaml
@@ -36,25 +36,29 @@ paths:
type: integer
format: int32
default: 20
explode: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this the the openpai3 bug fix where we mis interpreted the explode default value in openapi3 query params(explode: true) but in TypeSpec its always explode: false by default.

@timotheeguerin timotheeguerin added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 13, 2024
@JeffreyRichter
Copy link
Member

I don't have any context on this. Why ask me to review it?

@timotheeguerin
Copy link
Member Author

timotheeguerin commented Aug 13, 2024 •
edited
Loading

I don't have any context on this. Why ask me to review it?

I didn't explicitly it just did automatically, not sure you need to review here, just upgrading typespec versions

@timotheeguerin timotheeguerin changed the title Upgrade http, rest and openapi3 library to 0.59.1 fix Upgrade compiler, http, rest and openapi3 library to 0.59.1 fix Aug 13, 2024
@mikeharder mikeharder merged commit ca8c67a into main Aug 13, 2024
39 of 43 checks passed
@mikeharder mikeharder deleted the upgrade/hotfix/typespec-0.59.1 branch August 13, 2024 19:19
@weidongxu-microsoft
Copy link
Member

I don't have any context on this. Why ask me to review it?

I didn't explicitly it just did automatically, not sure you need to review here, just upgrading typespec versions

Because the PR touches the Swagger in openai data-plane lib, hence it looped in 2 reviewers for Swagger change on data-plane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter JeffreyRichter is a code owner automatically assigned from Azure/api-stewardship-board

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
data-plane PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timotheeguerin @JeffreyRichter @weidongxu-microsoft @mikeharder @AzureRestAPISpecReview