Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stream-style-serialization in Radiology Insights #29934

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

alzimmermsft
Copy link
Member

Removes the stream-style-serialization: false from Radiology Insight's tspconfig.yaml to enable generating code without the usage of Jackson Databind.

Removes the `stream-style-serialization: false` from Radiology Insight's `tspconfig.yaml` to enable generating code without the usage of Jackson Databind.
Copy link

openapi-pipeline-app bot commented Jul 22, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jul 22, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 76953fb6d0252ae61f721eecc13ef33fc5993005. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-healthinsights-radiologyinsights [Preview SDK Changes]
    info	[Changelog] data-plan skip changelog generation temporarily
️❌ azure-sdk-for-java failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from 76953fb6d0252ae61f721eecc13ef33fc5993005. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmdout	[Java-Sdk-Automation] [ERROR] COMPILATION ERROR :
    cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/healthinsights/azure-health-insights-radiologyinsights/src/main/java/module-info.java:[10,54] duplicate or conflicting opens: com.azure.health.insights.radiologyinsights.models
    cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/healthinsights/azure-health-insights-radiologyinsights/src/main/java/module-info.java:[10,74] duplicate or conflicting opens to module: com.azure.core
    cmdout	[Java-Sdk-Automation] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project azure-health-insights-radiologyinsights: Compilation failure: Compilation failure:
    cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/healthinsights/azure-health-insights-radiologyinsights/src/main/java/module-info.java:[10,54] duplicate or conflicting opens: com.azure.health.insights.radiologyinsights.models
    cmdout	[Java-Sdk-Automation] [ERROR] /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/healthinsights/azure-health-insights-radiologyinsights/src/main/java/module-info.java:[10,74] duplicate or conflicting opens to module: com.azure.core
    cmdout	[Java-Sdk-Automation] [ERROR] -> [Help 1]
    cmdout	[Java-Sdk-Automation] [ERROR]
    cmdout	[Java-Sdk-Automation] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    cmdout	[Java-Sdk-Automation] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    cmdout	[Java-Sdk-Automation] [ERROR]
    cmdout	[Java-Sdk-Automation] [ERROR] For more information about the errors and possible solutions, please read the following articles:
    cmdout	[Java-Sdk-Automation] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    cmdout	[Java-Sdk-Automation] [ERROR]
    cmdout	[Java-Sdk-Automation] [ERROR] After correcting the problems, you can resume the build with the command
    cmdout	[Java-Sdk-Automation] [ERROR]   mvn <args> -rf :azure-health-insights-radiologyinsights
    cmdout	[Java-Sdk-Automation] 2024-07-22 21:33:48 [ERROR] [COMPILE] Maven build fail.
    cmdout	[Java-Sdk-Automation] 2024-07-22 21:33:48 [ERROR] One reason of the compilation failure is that the existing code customization in SDK repository being incompatible with the class generated from updated TypeSpec source. In such case, you can ignore the failure, and fix the customization in SDK repository. You can inquire in "Language - Java" Teams channel. Please include the link of this Pull Request in the query.
  • azure-health-insights-radiologyinsights [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from 76953fb6d0252ae61f721eecc13ef33fc5993005. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [Warn]: Enum 'ApiVersion' must have a description
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:144
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  144 |              GeneratePackage `
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |              ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk solution. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
  • Azure.Health.Insights.RadiologyInsights [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 76953fb6d0252ae61f721eecc13ef33fc5993005. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/healthinsights/azurehealthinsightsradiologyinsights-rest/changelog-temp/package/review/rest/health-insights-radiologyinsights.api.md'
  • ️✔️@azure-rest/health-insights-radiologyinsights [Preview SDK Changes]
    info	[Changelog]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 22, 2024

Generated ApiView

Language Package Name ApiView Link
Python azure-healthinsights-radiologyinsights https://apiview.dev/Assemblies/Review/20cfb136ef164184971be6154cc227df?revisionId=e01ed88016f44a4ba7d2faefa10a41ee
.Net Azure.Health.Insights.RadiologyInsights https://apiview.dev/Assemblies/Review/d43daa369e2a49c0bb24a37339ceacea?revisionId=62d17c9899894abd834dc096d86a1f78

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that they've doing a GA SDK PR on the next api-version
Azure/azure-sdk-for-java#41098

@alzimmermsft alzimmermsft merged commit 61fe9b0 into main Aug 6, 2024
27 of 30 checks passed
@alzimmermsft alzimmermsft deleted the alzimmermsft-patch-1 branch August 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants