-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmelia ara v3 azure backup changes hardwaresecuritymodules microsoft.hardware security modules 2024-06-30-preview #29712
Emmelia ara v3 azure backup changes hardwaresecuritymodules microsoft.hardware security modules 2024-06-30-preview #29712
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2023-12-10-preview to preview/2024-06-30-preview.
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @mikekistler Already approved PR link: #28651 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Azure Versioning policy does not allow a GA and a preview API version with the same date. Since PR #28651 is adding this 2024-06-30 GA API version, the new preview must have an API version that is 2024-07-01-preview or later.
Furthermore, you need to merge #28651, and then rerun the pipeline checks before this PR is merged. That should clear any breaking changes issues and if not we'll need to understand why.
@mikekistler we are planning to release the Preview version and then the GA version. Will it be okay to update the GA version to 2024-07-01 (stable) instead ? We will wait to merge this one and then re-check the breaking changes on the GA PR. |
Please come to Breaking Change office hours on Monday at 10AM PT, or schedule a separate meeting with me if that's not convenient, so we can talk through this. |
will do, thanks! |
...ource-manager/Microsoft.HardwareSecurityModules/preview/2024-06-30-preview/dedicatedhsm.json
Show resolved
Hide resolved
"resourceId": { | ||
"type": "string", | ||
"description": "The Azure resource id in the form of /subscriptions/{SubscriptionId}/resourceGroups/{ResourceGroupName}/...", | ||
"format": "arm-id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add details if applicable :
https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details
"type": "string", | ||
"description": "The Azure blob storage container Uri which contains the backup", | ||
"format": "uri" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be clear , the secret part of the sas uri is not present here right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, we do not return the SAS token in the result, just the blob storage account and the container: "https://myaccount.blob.core.windows.net/container/container",
.../resource-manager/Microsoft.HardwareSecurityModules/preview/2024-06-30-preview/cloudhsm.json
Outdated
Show resolved
Hide resolved
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HardwareSecurityModules/cloudHsmClusters/{cloudHsmClusterName}/backup": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raosuhas, what is ARM policy affect?
Hi @raosuhas, resolved the LintDiff warnings were possible. Please have a look at the ones below: For LatestVersionOfCommonTypesMustBeUsed: I am using v6 and it is saying to use latest v5. Shall I downgrade or is it a false positive ? For PatchSkuProperty: Our service does not support Patch update. I added x-ms-mutability[read, create] in SKU definition (link) For EnumInsteadOfBoolean: This value used to be an enum but it was confusing to customers. It can only have 2 values. ApprovedFips or NotApprovedFips so we made it a Boolean instead. For PageableOperation: the get operation that the warning is flagged on, it is just a GET on a specific resource and it will only return max one dedicated HSM resource and never a list. Thanks! |
@raosuhas gentle ping. Made some changes based on the feedback, can you have a look on the updates? |
Had an offline call, and changes are approved with breaking-Change approved label
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.