Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Azure Traffic Manager 2018-03-01 API version with custom he… #2959

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

ttlcgl
Copy link
Contributor

@ttlcgl ttlcgl commented Apr 26, 2018

…aders and status code ranges options.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2038

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#137

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2829

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1771

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(3 total)
5 new Errors.(5 total)
Code Id Source Message
OperationsAPIImplementation R3023 Link Operations API must be implemented for '/providers/Microsoft.Network/operations'.
RequiredPropertiesMissingInResourceModel R2020 Link Model definition 'Endpoint' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
RequiredPropertiesMissingInResourceModel R2020 Link Model definition 'Profile' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
RequiredPropertiesMissingInResourceModel R2020 Link Model definition 'TrafficManagerGeographicHierarchy' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
RequiredPropertiesMissingInResourceModel R2020 Link Model definition 'HeatMapModel' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(1 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@sergey-shandar
Copy link
Contributor

@ravbhatnagar new API version.

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 27, 2018
@ttlcgl
Copy link
Contributor Author

ttlcgl commented Apr 27, 2018

@jhendrixMSFT

@jhendrixMSFT
Copy link
Member

@sergey-shandar I don't believe this is a completely new API version, it's just a combination of existing APIs. Please see my review in the private specs repo https://github.com/Azure/azure-rest-api-specs-pr/pull/450

@ravbhatnagar
Copy link
Contributor

Signing off from ARM. This has already been reviewed by ARM earlier.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants