Update header and query parameter for source control #29570

Juliehzl · 2024-06-25T07:38:46Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-06-25T07:38:49Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-06-25T07:38:50Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.12)	new version	base version
SourceControls.json	2024-02-02-preview(2e40914)	2024-02-02-preview(main)

Rule	Message
`❌` 1010 - AddingRequiredParameter	The required parameter 'x-ms-github-auxiliary' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L174:11
`❌` 1010 - AddingRequiredParameter	The required parameter 'x-ms-github-auxiliary' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L240:11
`❌` 1043 - AddingOptionalParameter	The optional parameter 'ignoreWorkflowDeletionFailure' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L247:11
`❌` 1043 - AddingOptionalParameter	The optional parameter 'deleteWorkflow' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L254:11

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-preview-2024-02	package-preview-2024-02(2e40914)	package-preview-2024-02(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L247
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L254

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L36
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L85
`❌` ResourceNameRestriction	The resource name parameter 'sourceControlName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L85
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L137
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L137
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L201
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L212
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L269
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L278
⚠️ MissingSegmentsInNestedResourceListOperation	A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L36
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L45
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L58
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L94
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L97
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L114
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L137
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L146
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L149
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L212
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L221
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L224

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-06-25T07:38:50Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-appcontainers [Preview SDK Changes]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [Preview SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️❌ azure-powershell failed [Detail]

FAQ

❌Code Generator Failed in generating from 24a6916eea80e205e16fce68f5944cedf41600cb. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
error	Script return with result [failed] code [2] signal [null] cwd [azure-powershell]: sh ./tools/SwaggerCI/init.sh
warn	Warning: File azure-powershell_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
error	FatalError: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
error	ErrorStack: Error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'    at Object.openSync (node:fs:596:3)    at Object.writeFileSync (node:fs:2322:35)    at writeTmpJsonFile (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/fsUtils.js:125:18)    at workflowCallGenerateScript (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:593:36)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:239:46)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:107:9)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:217:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-06-25T07:38:51Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/77a1e1c7ff4c495e8e1c9cf369fdf74a?revisionId=3be29f77484540099b124b4af11c2d9b
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=c6736c06b02c41a6a78fb35c60360039
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=05f6732be6734cc2ba4a7a01cba7a98e
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=ae3434986705460199b77326fd78e659

jijohn14 · 2024-06-25T14:29:02Z

/azp run

azure-pipelines · 2024-06-25T14:29:09Z

Commenter does not have sufficient privileges for PR 29570 in repo Azure/azure-rest-api-specs

ramoka178 · 2024-06-25T22:40:21Z

Same comments as in the PR #29536. Please answer here as well, if any other reviewer is taking a look.

Juliehzl · 2024-06-26T03:33:13Z

Same comments as in the PR #29536. Please answer here as well, if any other reviewer is taking a look.

replied in #29536

ramoka178 · 2024-06-26T19:11:43Z

Please address new comments from #29536

Juliehzl · 2024-07-30T08:25:17Z

/pr RequestMerge

ms-bogdan-rotaru · 2024-07-30T08:32:17Z

/azp run

azure-pipelines · 2024-07-30T08:32:34Z

Azure Pipelines successfully started running 3 pipeline(s).

ms-bogdan-rotaru · 2024-07-30T11:38:19Z

@Juliehzl The check Swagger BreakingChange is failing.

Juliehzl · 2024-07-31T10:03:03Z

@Juliehzl The check Swagger BreakingChange is failing.

@ms-bogdan-rotaru we already get breaking change review and get sign off.,
Why these labels are removed?

ms-bogdan-rotaru · 2024-07-31T10:07:47Z

@Juliehzl The check Swagger BreakingChange is failing.

@ms-bogdan-rotaru we already get breaking change review and get sign off., Why these labels are removed?

Added back labels ARMSignedOff and BreakingChange-Approved-BugFix

fix

9d6013e

fix

ece1fd4

azure-sdk mentioned this pull request Jun 25, 2024

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Update header and query parameter for source control azure-sdk/azure-sdk-for-go#10289

Closed

mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Jun 25, 2024

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jun 25, 2024

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2024

fix

7d2c1c9

Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 26, 2024

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 26, 2024

Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 23, 2024

razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 23, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 23, 2024

microsoft-github-policy-service bot added the MergeRequested label Jul 30, 2024

Juliehzl mentioned this pull request Jul 30, 2024

Update header and query parameter for source control #29536

Merged

7 tasks

Merge branch 'main' into user/zuh/fix-header-02-02-preview

97c9ef0

ms-bogdan-rotaru added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels Jul 31, 2024

ms-bogdan-rotaru removed the NotReadyForARMReview label Jul 31, 2024

ms-bogdan-rotaru approved these changes Jul 31, 2024

View reviewed changes

ms-bogdan-rotaru removed the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Jul 31, 2024

AzureRestAPISpecReview added NotReadyForARMReview and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jul 31, 2024

ms-bogdan-rotaru added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed NotReadyForARMReview labels Jul 31, 2024

ms-bogdan-rotaru merged commit c1a4465 into Azure:main Jul 31, 2024
28 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update header and query parameter for source control #29570

Update header and query parameter for source control #29570

Juliehzl commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

jijohn14 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

ramoka178 commented Jun 25, 2024

Juliehzl commented Jun 26, 2024

ramoka178 commented Jun 26, 2024

Juliehzl commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 30, 2024

Juliehzl commented Jul 31, 2024 •

edited

Loading

ms-bogdan-rotaru commented Jul 31, 2024

Update header and query parameter for source control #29570

Update header and query parameter for source control #29570

Conversation

Juliehzl commented Jun 25, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jun 25, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jun 25, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 25, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jun 25, 2024 • edited Loading

Generated ApiView

jijohn14 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

ramoka178 commented Jun 25, 2024

Juliehzl commented Jun 26, 2024

ramoka178 commented Jun 26, 2024

Juliehzl commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

ms-bogdan-rotaru commented Jul 30, 2024

Juliehzl commented Jul 31, 2024 • edited Loading

ms-bogdan-rotaru commented Jul 31, 2024

Juliehzl commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2024 •

edited

Loading

Juliehzl commented Jul 31, 2024 •

edited

Loading