-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update header and query parameter for source control #29570
Update header and query parameter for source control #29570
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.12) | new version | base version |
---|---|---|
SourceControls.json | 2024-02-02-preview(2e40914) | 2024-02-02-preview(main) |
Rule | Message |
---|---|
1010 - AddingRequiredParameter |
The required parameter 'x-ms-github-auxiliary' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L174:11 |
1010 - AddingRequiredParameter |
The required parameter 'x-ms-github-auxiliary' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L240:11 |
1043 - AddingOptionalParameter |
The optional parameter 'ignoreWorkflowDeletionFailure' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L247:11 |
1043 - AddingOptionalParameter |
The optional parameter 'deleteWorkflow' was added in the new version. New: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L254:11 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 2 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-02 | package-preview-2024-02(2e40914) | package-preview-2024-02(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L247 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/SourceControls.json#L254 |
The following errors/warnings exist before current PR submission:
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run |
Commenter does not have sufficient privileges for PR 29570 in repo Azure/azure-rest-api-specs |
Same comments as in the PR #29536. Please answer here as well, if any other reviewer is taking a look. |
Please address new comments from #29536 |
/pr RequestMerge |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@Juliehzl The check |
@ms-bogdan-rotaru we already get breaking change review and get sign off., |
Added back labels |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.