-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
justinytchen hybridcompute microsoft.hybrid compute 2024 07 31 preview #29560
justinytchen hybridcompute microsoft.hybrid compute 2024 07 31 preview #29560
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
azp /run |
I am not sure about the example. Also, I have not seen the format of duplicating the RP name in the API itself. You could post your issue in https://teams.microsoft.com/l/channel/19%3A4f661242c446452e895359cc3ef45125%40thread.tacv2/ARM%20linter%20rules?groupId=0cab4ce9-7691-42ae-82e3-460d4346a710&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47 for any guidance. Also there are other errors in BodyTopLevelProperties , that are not related to value/nextLink issue. Please fix them as well. |
@ramoka178 These changes (the HybridCompute provider being listed twice and the AgentVersion top level properties) have been approved and are in previous preview versions. Changing these would be breaking changes. We can potentially make a change to the AgentVersion APIs but the networkconfiguration path will be very difficult to change |
Previous preview API version with AgentVersion top level properties: #29070 |
Went to office hours, talked about the networkConfiguration/current path, which would be discussed internally (in the ARM team) to figure out the resolution. Also discussed the AgentVersion response, where the top level properties has already been approved. |
For next API reviewer: Asked this question on https://teams.microsoft.com/l/message/19:78cd6c72c41240dc84a36523af60b88a@thread.tacv2/1725044502273?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=0cab4ce9-7691-42ae-82e3-460d4346a710&parentMessageId=1725044502273&teamName=ARM%20API%20Reviewers&channelName=ARM%20swagger%20reviews&createdTime=1725044502273 |
…ompute-2024-07-31-preview
…-07-31-preview' of https://github.com/Azure/azure-rest-api-specs into justinytchen-hybridcompute-Microsoft.HybridCompute-2024-07-31-preview
Previous stable api version has been released
Azure#29560) Updated preview version with 2024-07-31-preview to add FirmwareProfile, HardwareProfile, and StorageProfile to Machine Properties in Hybrid Compute Machine Resource --------- Co-authored-by: Justin Chen <juschen@microsoft.com> Co-authored-by: Tim Lovell-Smith <tilovell@microsoft.com>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.