Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API #29519

Merged
merged 3 commits into from
Jun 22, 2024

prettier + spell check

993c479
Select commit
Loading
Failed to load commit list.
Merged

Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API #29519

prettier + spell check
993c479
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Jun 20, 2024 in 6m 55s

Swagger LintDiff succeeded

LintDiff
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.2) new version base version
package-preview-2024-07 package-preview-2024-07(993c479) package-preview-2024-07(release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L22134


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L64
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L180
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L243
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L249
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L349
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L479
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L549
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L555
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L706
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L822
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L885
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L891
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L991
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1121
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1191
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1197
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1303
❌ ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1428
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1428
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1618
❌ ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1757
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1757
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L1920
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2071
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2187
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2250
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2256
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2383
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2513
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2583
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2589
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L2955
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3071
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3134
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3140
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3291
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3421
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3491
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3497
❌ ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3654
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3655
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3769
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3832
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3917
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3923
❌ ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L3950
❌ ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L4021
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L4021
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L4022
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L4150
View more details on openapi-pipeline-app