[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb… #2939

kjohn-msft · 2018-04-24T17:12:14Z

…oot Settings

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…oot Settings

AutorestCI · 2018-04-24T17:12:52Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-24T17:13:33Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1959

AutorestCI · 2018-04-24T17:13:35Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2653

AutorestCI · 2018-04-24T17:15:17Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpam3216h0/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpam3216h0/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
Processing batch task - {"tag":"package-2018-01-preview"} .
FATAL: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
   at System.String.LastIndexOf(Char value, Int32 startIndex, Int32 count)
   at AutoRest.Go.Model.CodeModelGo.PackageVerDir() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 64
   at AutoRest.Go.Model.CodeModelGo.get_DefaultUserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 83
   at AutoRest.Go.Model.CodeModelGo.get_UserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 31
   at AutoRest.Go.Templates.VersionTemplate.<ExecuteAsync>d__1.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\obj\Razor\Templates\VersionTemplate.cshtml:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\CodeGeneratorGo.cs:line 91
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

azuresdkciprbot · 2018-04-24T17:18:12Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T17:18:12Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

dsgouda · 2018-04-24T17:35:48Z

Please fix the syntax errors indicated by CI

vrdmr · 2018-04-24T23:30:13Z

...automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json

+           ],
+           "x-ms-enum": {
+            "name": "WindowsRebootSettings",
+            "modelAsString": true


Missing "}" here? Can you validate the JSON.

azuresdkciprbot · 2018-04-25T22:22:38Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T22:22:38Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-26T22:06:33Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-26T22:06:33Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

dsgouda · 2018-04-27T20:52:26Z

...automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json

@@ -721,6 +721,10 @@
          "items": {
            "type": "string"
          }
+        },


If you can update the x-ms-examples based on this it would be great.

dsgouda · 2018-04-27T20:53:52Z

LGTM will merge upon acknowledgement of comment

dsgouda

LGTM will merge on CI pass

azuresdkciprbot · 2018-04-27T21:06:06Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-27T21:06:06Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Add Managed Identity support for Microsoft.DeviceUpdate

[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb…

fb32a40

…oot Settings

azuresdkci assigned dsgouda Apr 24, 2018

azuresdkci requested a review from dsgouda April 24, 2018 17:13

vrdmr reviewed Apr 24, 2018

View reviewed changes

Fixed syntax error

7db8289

Merge branch 'master' into master

74dc9b8

dsgouda reviewed Apr 27, 2018

View reviewed changes

Example for Reboot Setting

d2cdfb8

dsgouda approved these changes Apr 27, 2018

View reviewed changes

dsgouda merged commit 6c1ea9c into Azure:master Apr 27, 2018

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #2939 from Azure/Sedols-patch-11

a507804

Add Managed Identity support for Microsoft.DeviceUpdate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb… #2939

[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb… #2939

kjohn-msft commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

azuresdkciprbot commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

dsgouda commented Apr 24, 2018

vrdmr Apr 24, 2018

azuresdkciprbot commented Apr 25, 2018

azuresdkciprbot commented Apr 25, 2018

azuresdkciprbot commented Apr 26, 2018

azuresdkciprbot commented Apr 26, 2018

dsgouda Apr 27, 2018

dsgouda commented Apr 27, 2018

dsgouda left a comment

azuresdkciprbot commented Apr 27, 2018

azuresdkciprbot commented Apr 27, 2018

[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb… #2939

[UpdateManagement] SoftwareUpdateConfiguration changes to support Reb… #2939

Conversation

kjohn-msft commented Apr 24, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

dsgouda commented Apr 24, 2018

vrdmr Apr 24, 2018

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

dsgouda Apr 27, 2018

Choose a reason for hiding this comment

dsgouda commented Apr 27, 2018

dsgouda left a comment

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 27, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 27, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

kjohn-msft commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading