Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update securityPostureReference in VMScaleSet API #28891

Merged
merged 14 commits into from
Jun 5, 2024

Update sdk-suppressions.yaml

8434bfb
Select commit
Loading
Failed to load commit list.
Merged

Update securityPostureReference in VMScaleSet API #28891

Update sdk-suppressions.yaml
8434bfb
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded May 30, 2024 in 5m 2s

Swagger LintDiff succeeded

LintDiff
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.2) new version base version
package-2024-03-01 package-2024-03-01(8434bfb) package-2024-03-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6352
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6376


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L297
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L350
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L374
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L413
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L439
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L506
❌ ParametersInPost hibernate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L512
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L554
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L576
❌ ParametersInPost forceDeletion is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L582
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L624
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L646
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L677
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L822
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:secretUrl.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sourceVault.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L866
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L896
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L935
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L964
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1235
❌ ParametersInPost skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1241
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1284
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1306
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1347
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1369
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1410
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1432
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1494
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1535
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1557
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1598
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1620
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1661
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1683
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1724
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1746
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1787
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1870
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1871
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1903
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1925
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1957
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1979
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2011
❌ PathForNestedResource The path for nested resource doest not meet the valid resource pattern. There is one exception for extension resources with fully qualified path and the author can go ahead and suppress the error(look at https://github.com/Azure/azure-openapi-validator/blob/main/docs/path-for-nested-resource.md#pathfornestedresource for more details)
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2029
❌ PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2029
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2030
❌ ParametersInPost platformUpdateDomain is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2089
❌ ParametersInPost zone is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L2089
View more details on openapi-pipeline-app