[Bastion] Fix get and disconnect Bastion active sessions #28763

abhi7860 · 2024-04-19T19:15:53Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- beginListActiveSessionsAndWait() does not return Sessions even though the api called by the sdk does return Sessions azure-sdk-for-js#25671 (comment)

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-04-19T19:15:56Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).
❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).
❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

openapi-pipeline-app · 2024-04-19T19:15:57Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 3 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.7)	new version	base version
bastionHost.json	2024-01-01(fa3a602)	2023-11-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Network/stable/2024-01-01/bastionHost.json#L627:11
`❌` 1026 - TypeChanged	The new version has a different type 'string' than the previous one 'object'. New: Microsoft.Network/stable/2024-01-01/bastionHost.json#L933:9 Old: Microsoft.Network/stable/2023-11-01/bastionHost.json#L926:9
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Network/stable/2024-01-01/bastionHost.json#L597:7 Old: Microsoft.Network/stable/2023-11-01/bastionHost.json#L597:7

️❌LintDiff: 16 Errors, 0 Warnings failed [Detail]

Compared specs (v2.2.0)	new version	base version
package-2024-01	package-2024-01(fa3a602)	package-2024-01(release-network-Microsoft.Network-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/fa3a6023417bcfd4b9ad29f02a5679c37b93a39c/#L1
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L627	RPC-Async-V1-07

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L38
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L59
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L235
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L369
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L394
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L422
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L572
`❌` MissingTypeObject	The schema 'BastionHostIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L682
`❌` MissingTypeObject	The schema 'BastionHostIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L708
`❌` MissingTypeObject	The schema 'BastionHostPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L737
`❌` MissingTypeObject	The schema 'networkAcls' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L754
`❌` MissingTypeObject	The schema 'BastionHost' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L811
`❌` MissingTypeObject	The schema 'BastionHostListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L842
`❌` MissingTypeObject	The schema 'BastionShareableLink' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L858
`❌` MissingTypeObject	The schema 'BastionShareableLinkListRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L885
`❌` MissingTypeObject	The schema 'BastionShareableLinkListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L910
`❌` MissingTypeObject	The schema 'BastionActiveSession' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L926
`❌` MissingTypeObject	The schema 'BastionActiveSessionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L994
`❌` MissingTypeObject	The schema 'BastionSessionState' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1010
`❌` MissingTypeObject	The schema 'BastionSessionDeleteResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1030
`❌` MissingTypeObject	The schema 'SessionIds' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1054
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L44
⚠️ RequiredReadOnlySystemData	The response of operation:'BastionHosts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L88
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L94
⚠️ RequiredReadOnlySystemData	The response of operation:'BastionHosts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L134
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L140
⚠️ RequiredReadOnlySystemData	The response of operation:'BastionHosts_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L199
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L205
⚠️ PatchSkuProperty	The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L215
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L263

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-19T19:15:58Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [Preview SDK Changes]
- Microsoft.Azure.Management.Network.26.0.0.nupkg
- Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [Preview SDK Changes]
- Azure.ResourceManager.Network.1.8.0-alpha.20240419.1.nupkg
```
info	[Changelog]
```

️🔄 azure-sdk-for-python inProgress [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `BastionActiveSession.StartTime` has been changed from `any` to `*string`
info	[Changelog] - Function `*ManagementClient.NewDisconnectActiveSessionsPager` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*ManagementClient.BeginDisconnectActiveSessions(context.Context, string, string, SessionIDs, *ManagementClientBeginDisconnectActiveSessionsOptions) (*runtime.Poller[*runtime.Pager[ManagementClientDisconnectActiveSessionsResponse]], error)`
info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 76 additive change(s).

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Function `*ManagementClient.NewDisconnectActiveSessionsPager` has been removed
- Type of `BastionActiveSession.StartTime` has been changed from `any` to `*string`

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [Preview SDK Changes] Breaking Change Detected

azure-arm-network-34.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FirewallPolicyDeployments
info	[Changelog]   - Added operation group FirewallPolicyDrafts
info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraft
info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
info	[Changelog]   - Added Interface HeaderValueMatcher
info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
info	[Changelog]   - Added Interface PacketCaptureSettings
info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
info	[Changelog]   - Added Type Alias InboundSecurityRuleType
info	[Changelog]   - Added Type Alias NicTypeInRequest
info	[Changelog]   - Added Type Alias NicTypeInResponse
info	[Changelog]   - Added Type Alias SharingScope
info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
info	[Changelog]   - Interface DisconnectActiveSessionsOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface DisconnectActiveSessionsOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
info	[Changelog]   - Added Enum KnownNicTypeInRequest
info	[Changelog]   - Added Enum KnownNicTypeInResponse
info	[Changelog]   - Added Enum KnownSharingScope
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter startTime of interface BastionActiveSession is changed from Record<string, unknown> to string

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Type of parameter startTime of interface BastionActiveSession is changed from Record<string, unknown> to string

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

❌network/resource-manager [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from 419ab042b592008f463fc5a1a80b0a3627a4c977. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.network.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-19T19:15:58Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=9a05d046bb874b7d8b3112268f0b8af3
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=a0bd054b7eb24e9f9eae591d75f0b505
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=8772b4f242c7426dba05b0a9dc2d81cd
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/806ead8231374028b5c49cb90e200641?revisionId=92c10ff820884ba18e9e9c500b5482e2
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=790556f7fd094670ba9e775baa88e927

Fix get and disconnect Bastion sessions

fa3a602

azure-sdk added the BreakingChange-Go-Sdk label Apr 19, 2024

azure-sdk added the BreakingChange-JavaScript-Sdk label Apr 19, 2024

AzureRestAPISpecReview added the resource-manager label Apr 19, 2024

Joanna-Yang-Art deleted the branch Azure:release-network-Microsoft.Network-2024-01-01 June 21, 2024 06:55

Joanna-Yang-Art closed this Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bastion] Fix get and disconnect Bastion active sessions #28763

[Bastion] Fix get and disconnect Bastion active sessions #28763

abhi7860 commented Apr 19, 2024

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

[Bastion] Fix get and disconnect Bastion active sessions #28763

[Bastion] Fix get and disconnect Bastion active sessions #28763

Conversation

abhi7860 commented Apr 19, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Apr 19, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Apr 19, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 19, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Apr 19, 2024 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2024 •

edited

Loading