Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHub: Revert removing of messaging plan and updated with examples #2846

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Apr 10, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 10, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2051

@AutorestCI
Copy link

AutorestCI commented Apr 10, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1543

@AutorestCI
Copy link

AutorestCI commented Apr 10, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#53

@v-Ajnava
Copy link
Member Author

@sarangan12 , previous PR (#2831) where @hovsepm provided review comments which are addressed here.
previous PR was closed to address revert removing messaging plan commit.

ARM approval for MessagningPlan is in #2457

@AutorestCI
Copy link

AutorestCI commented Apr 10, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2658

@hovsepm
Copy link
Contributor

hovsepm commented Apr 10, 2018

this is rework of the PR #2831

@hovsepm hovsepm requested review from hovsepm and removed request for sarangan12 April 10, 2018 20:47
@hovsepm hovsepm assigned hovsepm and unassigned sarangan12 Apr 10, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Apr 10, 2018

@sarangan12 I'll take care of this one since I have more context through email communication.

@hovsepm hovsepm merged commit 607f9fa into Azure:master Apr 10, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants