Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify CircuitBreaker and BackendPool Contract #28397

Merged
merged 4 commits into from
Mar 26, 2024

Merge branch 'release-ApiManagement-2023-09-01-preview' into sadi/md-…

9ac097e
Select commit
Loading
Failed to load commit list.
Merged

Modify CircuitBreaker and BackendPool Contract #28397

Merge branch 'release-ApiManagement-2023-09-01-preview' into sadi/md-…
9ac097e
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Mar 22, 2024 in 15m 25s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-09 package-preview-2023-09(9ac097e) package-preview-2023-09(release-ApiManagement-2023-09-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L2353


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L9356
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8873
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8866
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8804
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8717
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8651
❌ TrackedResourcesMustHavePut The tracked resource DeletedServiceContract does not have a corresponding put operation.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8347
❌ TrackedResourcePatchOperation Tracked resource 'DeletedServiceContract' must have patch operation that at least supports the update of tags.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8347
❌ MissingTypeObject The schema 'ContentItemContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8324
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8324
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8311
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8294
❌ ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8207
❌ MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L8204
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6663
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6655
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6655
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6341
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6341
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6330
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6319
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6300
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6291
❌ NestedResourcesMustHaveListOperation The nested resource 'RecipientUserContract' does not have list operation, please add it.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6085
❌ NestedResourcesMustHaveListOperation The nested resource 'RecipientEmailContract' does not have list operation, please add it.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L6017
❌ RequiredPropertiesMissingInResourceModel Model definition 'QuotaCounterContract' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterContract' has extra properties ['value'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterContract' has extra properties ['periodEndTime'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterContract' has extra properties ['periodStartTime'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterContract' has extra properties ['periodKey'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterContract' has extra properties ['counterKey'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5921
❌ RequiredPropertiesMissingInResourceModel Model definition 'QuotaCounterCollection' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5895
❌ NestedResourcesMustHaveListOperation The nested resource 'QuotaCounterCollection' does not have list operation, please add it.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5895
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterCollection' has extra properties ['nextLink'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5895
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterCollection' has extra properties ['count'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5895
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaCounterCollection' has extra properties ['value'].
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5895
❌ ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L5205
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4719
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4708
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4664
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4631
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4631
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/definitions.json#L4631
View more details on openapi-pipeline-app