Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move previously approved Swagger from current to public master #2790

Merged
merged 1 commit into from
Mar 31, 2018
Merged

move previously approved Swagger from current to public master #2790

merged 1 commit into from
Mar 31, 2018

Conversation

olydis
Copy link
Contributor

@olydis olydis commented Mar 31, 2018 •
edited
Loading

@carlosscastro FYI

Will merge if CI passes

@olydis olydis assigned olydis and unassigned jhendrixMSFT Mar 31, 2018
@AutorestCI
Copy link

AutorestCI commented Mar 31, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 31, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@olydis olydis changed the title move to public master move previously approved Swagger from current to public master Mar 31, 2018
@olydis
Copy link
Contributor Author

olydis commented Mar 31, 2018 •
edited
Loading

Note to self or future reviewers: Validation succeeded except for the recent linter rule correctly pointing out that global botNameParameter should have x-ms-parameter-location. However:

  • that parameter isn't used anywhere, soooo...
  • there's a PR incoming that removes the parameter

So for the sake of consistent history, I'll merge this precisely as it was in current (modulo folder structure)

dsgouda
dsgouda approved these changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on @olydis 's recommendation

@dsgouda dsgouda merged commit 0c2eb3a into Azure:master Mar 31, 2018
@olydis olydis deleted the move-bot-service branch March 31, 2018 00:27
@AutorestCI
Copy link

AutorestCI commented Mar 31, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Mar 31, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees

@olydis olydis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olydis @AutorestCI @dsgouda @jhendrixMSFT