Update and add readme.nodejs.md files with latest generator arguments #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
requested review from
DeepakRajendranMsft,
hitenjava,
kay-owolabi and
schaabs
as code owners
RikkiGibson
reviewed
Mar 30, 2018
| ``` | ||
|
|
||
| ``` yaml $(nodejs) && $(tag) == 'package-catalog' |
There was a problem hiding this comment.
Beyond the output-folder changing to source-code-folder-path, is this a style change or a correctness change to add the additional yaml blocks?
There was a problem hiding this comment.
@lmazuel showed me to do it this way when I configured the Java Swagger To SDK readme files and I feel like it's a little easier to read (style change). I'm not sure if one way is more correct than the other.
There was a problem hiding this comment.
In this particular scenario, I feel both are fine.
However, for multi-api versionning, we want to have ONE "batch" at the beginning of the file to explain what ApiVersions are shipped by all SDKs. Then, this batch will have to be a list of tags.
RikkiGibson
approved these changes
Mar 30, 2018
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
amarzavery
reviewed
Mar 30, 2018
| @@ -6,6 +6,11 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f | |||
| ``` yaml $(nodejs) | |||
| nodejs: | |||
| package-name: azure-cognitiveservices-entitysearch | |||
| output-folder: $(node-sdks-folder)/lib/services/entitySearch/lib | |||
| package-version: 1.0.0-preview | |||
| output-folder: $(node-sdks-folder)/lib/services/entitySearch | |||
There was a problem hiding this comment.
Automation for azure-libraries-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
amarzavery
approved these changes
Mar 30, 2018
ghost
mentioned this pull request
lmazuel
approved these changes
Mar 30, 2018
schaabs
approved these changes
Mar 30, 2018
|
I think this looks good. I'm going to merge it. |
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger