Api center

cSpell.json

@@ -177,6 +177,13 @@
                 "Noreuse"
             ]
         },
+        {
+            "filename": "**/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/**/*json",
+            "words": [
+                "vtpm",
+                "trustedlaunch"
+            ]
+        },
         {
             "filename": "**/specification/containerregistry/data-plane/Microsoft.ContainerRegistry/preview/2018-08-10/containerregistry.json",
             "words": [
@@ -983,6 +990,12 @@
                 "mpga"
             ]
         },
+        {
+            "filename": "**/specification/appplatform/resource-manager/Microsoft.AppPlatform/preview/2024-01-01-preview/appplatform.json",
+            "words": [
+                "springboot"
+            ]
+        },
         {
             "filename": "**/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/**/*.json",
             "words": [

custom-words.txt

@@ -3108,6 +3108,7 @@ usermetadata
 userpreference
 userprincipalname
 usersetting
+usersync
 usertime
 usql
 usuk
@@ -3979,3 +3980,7 @@ proto
 msvideo
 SOQL
 Mulesoft
+retroperitoneal
+codeable
+telehealth
+loinc

documentation/ci-fix.md

@@ -16,6 +16,10 @@
     - [`Record<unkown>` causes `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`](#recordunkown-causes-avoidadditionalproperties-and-propertiestypeobjectnodefinition)
     - [`RequestBodyMustExistForPutPatch`](#requestbodymustexistforputpatch)
     - [`PatchPropertiesCorrespondToPutProperties`](#patchpropertiescorrespondtoputproperties)
+    - [`@singleton` causes `EvenSegmentedPathForPutOperation` and `XmsPageableForListCalls`](#singleton-causes-evensegmentedpathforputoperation-and-xmspageableforlistcalls)
+    - [`AvoidAnonymousParameter`, `AvoidAnonymousTypes`, `IntegerTypeMustHaveFormat`](#avoidanonymousparameter-avoidanonymoustypes-integertypemusthaveformat)
+    - [`AvoidAnonymousTypes` inside a 202 response](#avoidanonymoustypes-inside-a-202-response)
+    - [`OAuth2Auth` causes `XmsEnumValidation`](#oauth2auth-causes-xmsenumvalidation)
   - [`Swagger Avocado`](#swagger-avocado)
     - [Get help fixing Avocado validation failures](#get-help-fixing-avocado-validation-failures)
     - [Run avocado locally](#run-avocado-locally)
@@ -155,21 +159,53 @@ To reproduce LintDiff failures locally, see [CONTRIBUTING.md / How to locally re
 
 ## `Swagger LintDiff` for TypeSpec: troubleshooting guides
 
+Check `Swagger LintDiff` may fail for the OpenAPI generated from TypeSpec, even if there are no warnings or errors reported from the TypeSpec compiler.  Causes include bugs in the TypeSpec OpenAPI emitter, bugs in LintDiff rules, incompatibilities between TypeSpec and LintDiff, or checks duplicated in TypeSpec and LintDiff.
+
+We are working to address the root causes (where possible).  Until then, we recommend you [suppress](#suppression-process) these LintDiff errors, using a "permanent suppression" with a descriptive "reason", so we can revert your suppression when the root cause is fixed.
+
 ### `Record<unkown>` causes `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`
 
-The use of `Record<unkown>` in TypeSpec is discouraged, and there is a TypeSpec lint rule to enforce this.  If you still need to use `Record<unknown>`, the OpenAPI spec generated will cause many LintDiff errors of types `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`.  You will need to suppress both the TypeSpec violation (in TypeSpec source code) and the LintDiff violations (in `readme.md`).
+The use of `Record<unkown>` in TypeSpec is discouraged, and there is a TypeSpec lint rule to enforce this.  If you still need to use `Record<unknown>`, the OpenAPI spec generated will cause many LintDiff errors of types `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`.  You will need to suppress both the TypeSpec violation (in TypeSpec source code) and the LintDiff violations.
 
 ### `RequestBodyMustExistForPutPatch`
 
-We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/641.  Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors.
+We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/641
 
 ### `PatchPropertiesCorrespondToPutProperties`
 
-We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/642.  Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors.
+We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/642
 
 ### `@singleton` causes `EvenSegmentedPathForPutOperation` and `XmsPageableForListCalls`
 
-If `EvenSegmentedPathForPutOperation` and/or `XmsPageableForListCalls` are failing for OpenAPI generated from TypeSpec using `@singleton` (OpenAPI path ends with `/default`), we believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/646.  Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors.
+If `EvenSegmentedPathForPutOperation` and/or `XmsPageableForListCalls` are failing for OpenAPI generated from TypeSpec using `@singleton` (OpenAPI path ends with `/default`), we believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/646
+
+### `AvoidAnonymousParameter`, `AvoidAnonymousTypes`, `IntegerTypeMustHaveFormat`
+
+Data-plane specs can suppress violations of the following rules, since they only exist for the benefit of SDKs generated from swagger, and data-plane SDKs are generated directly from TypeSpec.  Resource-manager specs should **not** suppress violations of these rules, since resource-manager SDKs are generated from OpenAPI, and rely on these errors being fixed.
+
+* `AvoidAnonymousParameter`
+* `AvoidAnonymousTypes`
+* `IntegerTypeMustHaveFormat`
+
+### `AvoidAnonymousTypes` inside a 202 response
+
+As an exception to the previous note, resource-manager specs **may** be able to suppress `AvoidAnonymousTypes`, but only if the error is inside a 202 response from a long-running operation (LRO).  It is known that SDKs do not need to generate type names for such responses.
+
+### `OAuth2Auth` causes `XmsEnumValidation`
+
+TypeSpec using `OAuth2Auth` may generate the following OpenAPI:
+
+```
+"type": {
+  "type": "string",
+  "description": "OAuth2 authentication",
+  "enum": [
+    "oauth2"
+  ]
+},
+```
+
+Which causes error `XmsEnumValidation`.  The recommended workaround is to add `omit-unreachable-types: true` to your `tspconfig.yaml`.
 
 ## `Swagger Avocado`