Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodejs Swagger to SDK configs #2684

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Add nodejs Swagger to SDK configs #2684

merged 2 commits into from
Mar 19, 2018

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Mar 16, 2018 •
edited by azuresdkci
Loading

Adds Swagger to SDK config for all services we've currently shipped in the Azure SDK for Node.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@RikkiGibson RikkiGibson requested review from amarzavery, marstr and a user March 16, 2018 22:51
@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018 •
edited
Loading

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • eventgrid/resource-manager
  • automation/resource-manager
  • mediaservices/resource-manager
  • eventgrid/data-plane
  • servermanagement/resource-manager
  • cognitiveservices/data-plane/WebSearch
  • keyvault/data-plane
  • cognitiveservices/data-plane/TextAnalytics
  • batch/resource-manager
  • visualstudio/resource-manager
  • resourcehealth/resource-manager
  • network/resource-manager
  • storsimple8000series/resource-manager
  • batchai/resource-manager
  • storage/resource-manager
  • servicefabric/resource-manager
  • monitor/resource-manager
  • resources/resource-manager
  • billing/resource-manager
  • hdinsight/resource-manager
  • iothub/resource-manager
  • mysql/resource-manager
  • scheduler/resource-manager
  • sql/resource-manager
  • cognitiveservices/data-plane/ContentModerator
  • cosmos-db/resource-manager
  • recoveryservices/resource-manager
  • keyvault/resource-manager
  • trafficmanager/resource-manager
  • storageimportexport/resource-manager
  • applicationinsights/resource-manager
  • operationalinsights/resource-manager
  • postgresql/resource-manager
  • devtestlabs/resource-manager
  • authorization/resource-manager
  • containerinstance/resource-manager
  • relay/resource-manager
  • batch/data-plane
  • cognitiveservices/data-plane/Face
  • machinelearningcompute/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • datalake-analytics/data-plane
  • advisor/resource-manager
  • datalake-store/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • cognitiveservices/data-plane/CustomSearch
  • containerservices/resource-manager
  • dns/resource-manager
  • logic/resource-manager
  • datafactory/resource-manager
  • domainservices/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • eventhub/resource-manager
  • cognitiveservices/resource-manager
  • analysisservices/resource-manager
  • operationsmanagement/resource-manager
  • compute/resource-manager
  • graphrbac/data-plane
  • powerbiembedded/resource-manager
  • servicebus/resource-manager
  • commerce/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • cognitiveservices/data-plane/SpellCheck
  • containerregistry/resource-manager
  • datalake-store/data-plane
  • marketplaceordering/resource-manager
  • redis/resource-manager
  • search/resource-manager
  • service-map/resource-manager
  • notificationhubs/resource-manager
  • mobileengagement/resource-manager
  • apimanagement/resource-manager
  • web/resource-manager
  • consumption/resource-manager
  • servicefabric/data-plane
  • datalake-analytics/resource-manager
  • recoveryservicesbackup/resource-manager
  • machinelearning/resource-manager
  • customer-insights/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • recoveryservicessiterecovery/resource-manager
  • streamanalytics/resource-manager

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018 •
edited
Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/Face
  • cognitiveservices/data-plane/SpellCheck
  • recoveryservices/resource-manager
  • machinelearning/resource-manager
  • devtestlabs/resource-manager
  • eventgrid/data-plane
  • keyvault/resource-manager
  • apimanagement/resource-manager
  • batch/resource-manager
  • recoveryservicesbackup/resource-manager
  • batch/data-plane
  • commerce/resource-manager
  • logic/resource-manager
  • authorization/resource-manager
  • operationsmanagement/resource-manager
  • redis/resource-manager
  • storageimportexport/resource-manager
  • containerinstance/resource-manager
  • containerservices/resource-manager
  • visualstudio/resource-manager
  • resourcehealth/resource-manager
  • servicefabric/data-plane
  • eventgrid/resource-manager
  • servicebus/resource-manager
  • batchai/resource-manager
  • servermanagement/resource-manager
  • billing/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • consumption/resource-manager
  • machinelearningcompute/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • datalake-analytics/resource-manager
  • marketplaceordering/resource-manager
  • postgresql/resource-manager
  • powerbiembedded/resource-manager
  • service-map/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • cognitiveservices/data-plane/ContentModerator
  • compute/resource-manager
  • analysisservices/resource-manager
  • datalake-store/data-plane
  • web/resource-manager
  • monitor/resource-manager
  • cognitiveservices/data-plane/WebSearch
  • datafactory/resource-manager
  • eventhub/resource-manager
  • notificationhubs/resource-manager
  • datalake-store/resource-manager
  • operationalinsights/resource-manager
  • cosmos-db/resource-manager
  • cognitiveservices/resource-manager
  • cognitiveservices/data-plane/TextAnalytics
  • datalake-analytics/data-plane
  • relay/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • scheduler/resource-manager
  • applicationinsights/resource-manager
  • dns/resource-manager
  • servicefabric/resource-manager
  • storage/resource-manager
  • advisor/resource-manager
  • domainservices/resource-manager
  • resources/resource-manager
  • sql/resource-manager
  • trafficmanager/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • cognitiveservices/data-plane/CustomSearch
  • mobileengagement/resource-manager
  • hdinsight/resource-manager
  • mediaservices/resource-manager
  • network/resource-manager
  • search/resource-manager
  • graphrbac/data-plane
  • keyvault/data-plane
  • storsimple8000series/resource-manager
  • streamanalytics/resource-manager
  • customer-insights/resource-manager
  • iothub/resource-manager
  • automation/resource-manager
  • mysql/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • containerregistry/resource-manager

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018 •
edited
Loading

Automation for azure-libraries-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • mediaservices/resource-manager
  • storageimportexport/resource-manager
  • cosmos-db/resource-manager
  • network/resource-manager
  • keyvault/data-plane
  • machinelearningcompute/resource-manager
  • recoveryservicesbackup/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • servicebus/resource-manager
  • hdinsight/resource-manager
  • advisor/resource-manager
  • monitor/resource-manager
  • cognitiveservices/data-plane/WebSearch
  • scheduler/resource-manager
  • operationsmanagement/resource-manager
  • storsimple8000series/resource-manager
  • billing/resource-manager
  • servicefabric/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • apimanagement/resource-manager
  • containerinstance/resource-manager
  • streamanalytics/resource-manager
  • customer-insights/resource-manager
  • analysisservices/resource-manager
  • automation/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • keyvault/resource-manager
  • search/resource-manager
  • datalake-analytics/data-plane
  • datalake-store/data-plane
  • cognitiveservices/data-plane/ContentModerator
  • eventgrid/data-plane
  • iothub/resource-manager
  • mysql/resource-manager
  • cognitiveservices/resource-manager
  • datafactory/resource-manager
  • web/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • cognitiveservices/data-plane/CustomSearch
  • operationalinsights/resource-manager
  • postgresql/resource-manager
  • powerbiembedded/resource-manager
  • service-map/resource-manager
  • devtestlabs/resource-manager
  • resources/resource-manager
  • trafficmanager/resource-manager
  • domainservices/resource-manager
  • servicefabric/data-plane
  • recoveryservicessiterecovery/resource-manager
  • redis/resource-manager
  • graphrbac/data-plane
  • marketplaceordering/resource-manager
  • notificationhubs/resource-manager
  • servermanagement/resource-manager
  • compute/resource-manager
  • mobileengagement/resource-manager
  • storage/resource-manager
  • containerservices/resource-manager
  • batch/data-plane
  • resourcehealth/resource-manager
  • visualstudio/resource-manager
  • batch/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • dns/resource-manager
  • consumption/resource-manager
  • eventgrid/resource-manager
  • relay/resource-manager
  • cognitiveservices/data-plane/SpellCheck
  • eventhub/resource-manager
  • commerce/resource-manager
  • authorization/resource-manager
  • containerregistry/resource-manager
  • logic/resource-manager
  • batchai/resource-manager
  • datalake-store/resource-manager
  • applicationinsights/resource-manager
  • machinelearning/resource-manager
  • recoveryservices/resource-manager
  • cognitiveservices/data-plane/TextAnalytics
  • sql/resource-manager
  • cognitiveservices/data-plane/Face
  • datalake-analytics/resource-manager

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • commerce/resource-manager
  • analysisservices/resource-manager
  • scheduler/resource-manager
  • mediaservices/resource-manager
  • apimanagement/resource-manager
  • billing/resource-manager
  • service-map/resource-manager
  • relay/resource-manager
  • cognitiveservices/data-plane/CustomSearch
  • notificationhubs/resource-manager
  • cognitiveservices/data-plane/ContentModerator
  • keyvault/resource-manager
  • cognitiveservices/data-plane/TextAnalytics
  • hdinsight/resource-manager
  • postgresql/resource-manager
  • redis/resource-manager
  • storageimportexport/resource-manager
  • customer-insights/resource-manager
  • storsimple8000series/resource-manager
  • servicefabric/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • domainservices/resource-manager
  • streamanalytics/resource-manager
  • authorization/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • datalake-analytics/resource-manager
  • operationalinsights/resource-manager
  • datalake-store/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • mysql/resource-manager
  • applicationinsights/resource-manager
  • eventgrid/resource-manager
  • dns/resource-manager
  • advisor/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • datalake-analytics/data-plane
  • cognitiveservices/data-plane/WebSearch
  • automation/resource-manager
  • cosmos-db/resource-manager
  • machinelearningcompute/resource-manager
  • servicebus/resource-manager
  • cognitiveservices/data-plane/SpellCheck
  • servicefabric/data-plane
  • powerbiembedded/resource-manager
  • consumption/resource-manager
  • containerservices/resource-manager
  • search/resource-manager
  • mobileengagement/resource-manager
  • compute/resource-manager
  • keyvault/data-plane
  • trafficmanager/resource-manager
  • iothub/resource-manager
  • graphrbac/data-plane
  • network/resource-manager
  • storage/resource-manager
  • logic/resource-manager
  • batch/data-plane
  • cognitiveservices/resource-manager
  • cognitiveservices/data-plane/Face
  • monitor/resource-manager
  • datalake-store/data-plane
  • visualstudio/resource-manager
  • batchai/resource-manager
  • marketplaceordering/resource-manager
  • batch/resource-manager
  • recoveryservices/resource-manager
  • sql/resource-manager
  • web/resource-manager
  • resources/resource-manager
  • datafactory/resource-manager
  • eventhub/resource-manager
  • cognitiveservices/data-plane/ComputerVision
  • containerregistry/resource-manager
  • recoveryservicesbackup/resource-manager
  • containerinstance/resource-manager
  • devtestlabs/resource-manager
  • operationsmanagement/resource-manager
  • resourcehealth/resource-manager
  • eventgrid/data-plane
  • cognitiveservices/data-plane/VideoSearch
  • servermanagement/resource-manager
  • machinelearning/resource-manager

amarzavery
amarzavery approved these changes Mar 17, 2018
View reviewed changes
Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic Job @RikkiGibson 👍 . I searched for different cases like resource management, datalake, service fabric, storagemanagement, cognitiveServices, etc. and found everything in the respective config files to be fine.

@RikkiGibson
Copy link
Member Author

Thank you. I took a few notes when I found discrepancies while adding the configs, which I'm just now remembering to add:

  • monitor/data-plane merged into resource-management. Must deprecate and bump major version.

  • operationalinsights/data-plane missing from codegen_mappings.json in azure-sdk-for-node.

  • search/data-plane structure has changed-- looks like what codegen_mappings.json calls "searchindex" is probably now under "search/data-plane/Microsoft.Azure.Search.Data" in azure-rest-api-specs.

    • This one I can fix before merging

@RikkiGibson
Copy link
Member Author

The Search data-plane SDKs contain this note:

!!! READ THIS !!!
This swagger is not yet ready for languages other than C#.
!!! READ THIS !!!

So I think I'm good to merge as-is :)

@RikkiGibson
Copy link
Member Author

@amarzavery Looks like the MODE=python job is stalling out, is that relevant to us?

@RikkiGibson RikkiGibson merged commit 806bf80 into Azure:master Mar 19, 2018
@RikkiGibson RikkiGibson deleted the NodeSwaggerConfigs branch March 19, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery amarzavery approved these changes

@marstr marstr Awaiting requested review from marstr

@dedhar dedhar Awaiting requested review from dedhar

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

@dragav dragav Awaiting requested review from dragav

@erickson-doug erickson-doug Awaiting requested review from erickson-doug

@hvermis hvermis Awaiting requested review from hvermis

@jonpayne jonpayne Awaiting requested review from jonpayne

@kay-owolabi kay-owolabi Awaiting requested review from kay-owolabi

@schaabs schaabs Awaiting requested review from schaabs

@shawns1 shawns1 Awaiting requested review from shawns1

@tbombach tbombach Awaiting requested review from tbombach

@tiffanyachen tiffanyachen Awaiting requested review from tiffanyachen

@vladbarosan vladbarosan Awaiting requested review from vladbarosan

Assignees

@alvadb alvadb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RikkiGibson @AutorestCI @amarzavery @alvadb