Added reservation recommendations and tags #2679

asarkar84 · 2018-03-16T00:56:31Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Added Tags filter for budgets and updated the api version

Updated comments

Incorporated review comments

Incorporated review comment

Added Tags filter and grouping for UsageDetails

Added reservation recommendations and tags

AutorestCI · 2018-03-16T00:57:17Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-03-16T00:57:22Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-03-16T01:57:06Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2018-03-16T02:02:52Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1328

jhendrixMSFT

Also note that the addition of the '$apply' parameter will introduce a breaking change for some SDKs.

jhendrixMSFT · 2018-03-16T16:24:32Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/consumption.json

+            "$ref": "./examples/ReservationRecommendationsFilterByScopeLookBackPeriod.json"
+          }
+        },
+        "parameters": [          


The subscriptionId parameter is missing which is the cause of the travis failure, see the log.

Sure! Just missed it. I have added it.

jhendrixMSFT · 2018-03-16T16:27:13Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/consumption.json

+        "tags": [
+          "ReservationRecommendations"
+        ],
+        "operationId": "reservationRecommendations_List",


Should be "ReservationRecommendations_List" (upper-case 'r').

Sure! Corrected.

jhendrixMSFT · 2018-03-16T16:32:05Z

...manager/Microsoft.Consumption/stable/2018-03-31/examples/ReservationRecommendationsList.json

+              "recommendedQuantity": 1,
+              "totalCostWithReservedInstances": 0.0,
+              "netSavings": 4.634521202630137,
+              "firstUsageDate": "2018-03-06",


The schema defines this as date/time however you've only provided a date; this is causing model validation failures, see the log. This is applicable to other samples as well.

Thanks! for sharing this. I have changed the format to DateTime in example.

Incorporated review comments

asarkar84 · 2018-03-16T18:11:51Z

Review comments have been incorporated. Please take a look now.

Incorporated review comments

jhendrixMSFT · 2018-03-16T19:29:26Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/consumption.json

+        "firstUsageDate": {
+          "description": "The usage date for looking back.",
+          "type": "string",
+          "format": "date-time",


There are still model validation failure regarding this date-time, see the log. Is this supposed to be just date like the others you changed?

Sorry! Typo error. There was a space in the datetime string example. Just corrected it and waiting for build to complete.

Removed unwanted space

jhendrixMSFT · 2018-03-16T22:13:43Z

...manager/Microsoft.Consumption/stable/2018-03-31/examples/ReservationRecommendationsList.json

+              "recommendedQuantity": 1,
+              "totalCostWithReservedInstances": 0.0,
+              "netSavings": 4.634521202630137,
+              "firstUsageDate": "2018-03-06T00:00:00Z ",


Another extra whitespace, looks like there's on line 42 as well. Please scrub the remaining example files for this error.

Done! I have verified the other files as well.

Removed extra whitespace

jhendrixMSFT · 2018-03-16T23:20:07Z

@AutorestCI rebuild azure-sdk-for-go

asarkar84 · 2018-03-17T01:00:14Z

Please merge the PR if everything looks good. Thank you!

Adding arczoneid properties for the resources...

asarkar84 added 10 commits March 8, 2018 15:44

Added Tags filter for budgets and updated the api version

7b927cf

Added Tags filter for budgets and updated the api version

Updated comments

c641158

Updated comments

Incorporated review comments

0e276b2

Incorporated review comments

Incorporated review comments

7be4364

Incorporated review comments

Incorporated review comment

bff7aa7

Incorporated review comment

Merge remote-tracking branch 'upstream/master'

011c9f0

Added Tags filter and grouping for UsageDetails

002a6db

Added Tags filter and grouping for UsageDetails

Merge remote-tracking branch 'upstream/master'

020911c

Added reservation recommendations and tags

502d70e

Added reservation recommendations and tags

Merge remote-tracking branch 'upstream/master'

b41bd12

azuresdkci assigned jhendrixMSFT Mar 16, 2018

AutorestCI mentioned this pull request Mar 16, 2018

[AutoPR consumption/resource-manager] Added reservation recommendations and tags Azure/azure-sdk-for-python#2199

Merged

jhendrixMSFT requested changes Mar 16, 2018

View reviewed changes

jhendrixMSFT added the potential-sdk-breaking-change label Mar 16, 2018

Incorporated review comments

7956270

Incorporated review comments

Incorporated review comments

346ce83

Incorporated review comments

jhendrixMSFT reviewed Mar 16, 2018

View reviewed changes

Removed unwanted space

a0072f9

Removed unwanted space

asarkar84 requested a review from a user March 16, 2018 19:59

asarkar84 requested a review from vladbarosan as a code owner March 16, 2018 19:59

jhendrixMSFT reviewed Mar 16, 2018

View reviewed changes

Removed extra whitespace

ee9bfc3

Removed extra whitespace

add swagger->sdk config for go

6df7a9e

fix broken tags for go

7a5eab1

AutorestCI mentioned this pull request Mar 17, 2018

[AutoPR consumption/resource-manager] Added reservation recommendations and tags Azure/azure-sdk-for-go#1316

Merged

jhendrixMSFT approved these changes Mar 19, 2018

View reviewed changes

jhendrixMSFT merged commit 1ed1606 into Azure:master Mar 19, 2018

ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 21, 2018

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #2679 from Azure/arczone2020

018b76a

Adding arczoneid properties for the resources...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added reservation recommendations and tags #2679

Added reservation recommendations and tags #2679

asarkar84 commented Mar 16, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

jhendrixMSFT left a comment

jhendrixMSFT Mar 16, 2018

asarkar84 Mar 16, 2018

jhendrixMSFT Mar 16, 2018

asarkar84 Mar 16, 2018

jhendrixMSFT Mar 16, 2018

asarkar84 Mar 16, 2018 •

edited

Loading

asarkar84 commented Mar 16, 2018

jhendrixMSFT Mar 16, 2018

asarkar84 Mar 16, 2018

jhendrixMSFT Mar 16, 2018

asarkar84 Mar 16, 2018

jhendrixMSFT commented Mar 16, 2018

asarkar84 commented Mar 17, 2018

Added reservation recommendations and tags #2679

Added reservation recommendations and tags #2679

Conversation

asarkar84 commented Mar 16, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Mar 16, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 16, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 16, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 16, 2018 • edited Loading

Automation for azure-sdk-for-go

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asarkar84 Mar 16, 2018 • edited Loading

Choose a reason for hiding this comment

asarkar84 commented Mar 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhendrixMSFT commented Mar 16, 2018

asarkar84 commented Mar 17, 2018

asarkar84 commented Mar 16, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

AutorestCI commented Mar 16, 2018 •

edited

Loading

asarkar84 Mar 16, 2018 •

edited

Loading