[Cognitive Services] Add Microsoft.CognitiveServices/skus operation #2666

felixwa · 2018-03-15T09:45:47Z

Add Microsoft.CognitiveServices/skus operation
Add its example

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Add Microsoft.CognitiveServices/skus operation Add its example

AutorestCI · 2018-03-15T09:46:38Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2615

AutorestCI · 2018-03-15T09:47:15Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp9j53ewto/rest/specification/cognitiveservices/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp9j53ewto/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to resolve package '@microsoft.azure/autorest-core@preview'.
Error: Unable to resolve package '@microsoft.azure/autorest-core@preview'.
    at fetch (/node_modules/@microsoft.azure/extension/dist/main.js:295:26)
    at /node_modules/npm/node_modules/call-limit/call-limit.js:22:12
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

AutorestCI · 2018-03-15T09:47:33Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#40

AutorestCI · 2018-03-15T09:48:02Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1521

anuchandy · 2018-03-15T19:47:10Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+      "get": {
+        "tags": [
+          "Skus",
+          "AvailabilitySets"


not sure AvailabilitySets make sense here, if not please remove it

Right, that does not make sense, put CognitiveServicesAccounts there.

anuchandy · 2018-03-15T19:50:26Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+          "items": {
+            "type": "string"
+          },
+          "description": "Locations where the SKU is restricted"


just confirming - this is the list of location where the specific sku is not available, right?

I think so...but actually I took this from Compute/Skus.

anuchandy · 2018-03-16T17:19:26Z

@felixwa thank you. one question (this is just to understand the behavior of the API) Let say a specific resourceType, name, tier, kind combination is supported in multiple regions (locations). In this case, do we return (1). one entry with locations property with value as all locations or (2). we return one entry per location?

anuchandy · 2018-03-16T17:25:12Z

@ravbhatnagar PR enables new endpoint to retrieve SKUs, there is no breaking change. But in case you want to take a look to ensure that the API shape follows standard pattern defined for SKU API across RPs.

anuchandy · 2018-03-16T17:22:07Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+          ],
+          "x-ms-enum": {
+            "name": "ResourceSkuRestrictionsReasonCode",
+            "modelAsString": false


It's recommended to use "modelAsString": true so that languages generate extendable enum.

reasonCode modelAsString = true

felixwa · 2018-03-19T04:01:32Z

@anuchandy , for your question wrt the behavior, I believe it is (2). we return one entry per location. You can also verify this in the example file (GetSkus.json) of this PR.

anuchandy · 2018-03-19T17:12:13Z

@felixwa thank you for confirming.

@ravbhatnagar are you fine with these changes?

ravbhatnagar · 2018-03-21T07:03:12Z

Looks good. Signing off!

felixwa · 2018-03-22T07:32:13Z

@anuchandy , Gaurave has signed off, could you merge the change now?

lmazuel · 2018-03-28T21:37:59Z

@felixwa could you take the opportunity of this PR to change the incorrect value of usageFilterParameter for x-ms-parameter-location from client to method? Thank you!

x-ms-parameter-location 'client' to 'method'

felixwa · 2018-03-29T07:38:38Z

@lmazuel, done

Add Microsoft.CognitiveServices/skus operation

04a7ee2

Add Microsoft.CognitiveServices/skus operation Add its example

AutorestCI mentioned this pull request Mar 15, 2018

[AutoPR cognitiveservices/resource-manager] [Cognitive Services] Add Microsoft.CognitiveServices/skus operation Azure/azure-libraries-for-java#298

Closed

AutorestCI mentioned this pull request Mar 15, 2018

[AutoPR cognitiveservices/resource-manager] [Cognitive Services] Add Microsoft.CognitiveServices/skus operation Azure/azure-sdk-for-go#1267

Closed

azuresdkci assigned anuchandy Mar 15, 2018

anuchandy reviewed Mar 15, 2018

View reviewed changes

Correct tags for Microsoft.CognitiveServices/skus

5e85380

anuchandy requested a review from ravbhatnagar March 16, 2018 17:23

anuchandy reviewed Mar 16, 2018

View reviewed changes

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 16, 2018

reasonCode modelAsString = true

b43648f

reasonCode modelAsString = true

felixwa requested a review from a user March 19, 2018 03:57

felixwa requested review from tiffanyachen and vladbarosan as code owners March 19, 2018 03:57

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR cognitiveservices/resource-manager] [Cognitive Services] Add Microsoft.CognitiveServices/skus operation Azure/azure-sdk-for-go#1318

Closed

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2018

x-ms-parameter-location 'client' to 'method'

d5294e0

x-ms-parameter-location 'client' to 'method'

AutorestCI mentioned this pull request Mar 29, 2018

[AutoPR cognitiveservices/resource-manager] [Cognitive Services] Add Microsoft.CognitiveServices/skus operation Azure/azure-sdk-for-python#2301

Closed

lmazuel approved these changes Apr 6, 2018

View reviewed changes

anuchandy merged commit a93922b into Azure:master Apr 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cognitive Services] Add Microsoft.CognitiveServices/skus operation #2666

[Cognitive Services] Add Microsoft.CognitiveServices/skus operation #2666

felixwa commented Mar 15, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

anuchandy Mar 15, 2018

felixwa Mar 16, 2018

anuchandy Mar 15, 2018

felixwa Mar 16, 2018

anuchandy commented Mar 16, 2018

anuchandy commented Mar 16, 2018

anuchandy Mar 16, 2018

felixwa commented Mar 19, 2018 •

edited

Loading

anuchandy commented Mar 19, 2018

ravbhatnagar commented Mar 21, 2018

felixwa commented Mar 22, 2018

lmazuel commented Mar 28, 2018

felixwa commented Mar 29, 2018

[Cognitive Services] Add Microsoft.CognitiveServices/skus operation #2666

[Cognitive Services] Add Microsoft.CognitiveServices/skus operation #2666

Conversation

felixwa commented Mar 15, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Mar 15, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 15, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 15, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 15, 2018 • edited Loading

Automation for azure-sdk-for-go

anuchandy Mar 15, 2018

Choose a reason for hiding this comment

felixwa Mar 16, 2018

Choose a reason for hiding this comment

anuchandy Mar 15, 2018

Choose a reason for hiding this comment

felixwa Mar 16, 2018

Choose a reason for hiding this comment

anuchandy commented Mar 16, 2018

anuchandy commented Mar 16, 2018

anuchandy Mar 16, 2018

Choose a reason for hiding this comment

felixwa commented Mar 19, 2018 • edited Loading

anuchandy commented Mar 19, 2018

ravbhatnagar commented Mar 21, 2018

felixwa commented Mar 22, 2018

lmazuel commented Mar 28, 2018

felixwa commented Mar 29, 2018

felixwa commented Mar 15, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

felixwa commented Mar 19, 2018 •

edited

Loading