Fix arm review comments for container app #26455
Merged
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff
failed
Oct 30, 2023 in 2m 58s
~[NotRequired_Staging] Swagger LintDiff failed
ppe/LintDiff: 53 Errors, 14 Warnings
View more details.
Details
compared tags (via openapi-validator vbeta) | new version | base version |
---|---|---|
package-preview-2023-08 | package-preview-2023-08(0ad3763) | package-preview-2023-08(release-app-Microsoft.App-2023-08-01-preview) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Usages.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Subscriptions.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/SourceControls.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsStorages.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprComponentResiliencyPolicies.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprComponents.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ManagedEnvironments.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Jobs.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Global.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Diagnostics.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ContainerAppsRevisions.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ContainerApps.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsCertificates.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Builds.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/Builders.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/BillingMeters.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/AvailableWorkloadProfiles.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json'. Errors encountered: Error: Error running Nimma Error 1: Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/AppResiliency.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Location: azure-rest-api-specs/blob/0ad3763deafd1ecd3808a9cc60a54a33b70cb0f4/#L1 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1501 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1486 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1467 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1422 |
ArmResourcePropertiesBag |
Top level property names should not be repeated inside the properties bag for ARM resource 'Certificate'. Properties [properties.type] conflict with ARM top level properties. Please rename these. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1178 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1108 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1067 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1035 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1020 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1020 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L928 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L913 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L730 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L715 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L623 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L620 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L589 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L526 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L522 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L518 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L435 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L412 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L281 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L97 |
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1502 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1329 |
|
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1325 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1259 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1187 |
|
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1183 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1087 |
|
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1036 |
|
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L929 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L747 |
|
Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L731 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L350 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L230 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L156 |
Loading