Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SharingProfile to CapacityReservationGroup for CrossPartitionCapacityReservationGroup operations #26378

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Adding SharingProfile to CapacityReservationGroup for CrossPartitionCapacityReservationGroup operations #26378

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fc881ef
Adding Sharing Profile to CapacityReservationGroup
Oct 25, 2023
59716f6
Updating Sharingprofile property name to avoid confict
Oct 25, 2023
c533d42
Fixed formats
Oct 25, 2023
a964d07
Updating sharingprofile definition
Oct 25, 2023
881d1c9
Fixed issues reported from PR checks
Oct 25, 2023
4af4c49
Adding doc link
Oct 27, 2023
0292193
Fixed formatting
Oct 27, 2023
52fb407
Addressed PR comments
Oct 27, 2023
4cd4b87
Addressing PR comments
Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions ...e/resource-manager/Microsoft.Compute/ComputeRP/stable/2023-09-01/capacityReservation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"CapacityReservationGroups"
],
"operationId": "CapacityReservationGroups_CreateOrUpdate",
"description": "The operation to create or update a capacity reservation group. When updating a capacity reservation group, only tags may be modified. Please refer to https://aka.ms/CapacityReservation for more details.",
"description": "The operation to create or update a capacity reservation group. When updating a capacity reservation group, only tags and sharing profile may be modified. Please refer to https://aka.ms/CapacityReservation for more details.",
"parameters": [
{
"name": "resourceGroupName",
Expand Down Expand Up @@ -103,7 +103,7 @@
"CapacityReservationGroups"
],
"operationId": "CapacityReservationGroups_Update",
"description": "The operation to update a capacity reservation group. When updating a capacity reservation group, only tags may be modified.",
"description": "The operation to update a capacity reservation group. When updating a capacity reservation group, only tags and sharing profile may be modified.",
"parameters": [
{
"name": "resourceGroupName",
Expand Down Expand Up @@ -730,6 +730,27 @@
],
"readOnly": true,
"description": "List of instance view of the capacity reservations under the capacity reservation group."
},
"sharedSubscriptionIds": {
"type": "array",
"items": {
"$ref": "../../../common-types/v1/common.json#/definitions/SubResourceReadOnly"
},
"x-ms-identifiers": [],
nreact marked this conversation as resolved.
Show resolved Hide resolved
"readOnly": true,
"description": "List of the subscriptions that the capacity reservation group is shared with. **Note:** Minimum api-version: 2023-09-01. Please refer to https://aka.ms/computereservationsharing for more details."
}
}
},
"ResourceSharingProfile": {
"type": "object",
"properties": {
"subscriptionIds": {
"type": "array",
"description": "Specifies an array of references to subscriptionIds. **Note:** Minimum api-version: 2023-09-01. Please refer to https://aka.ms/computereservationsharing for more details.",
TimLovellSmith marked this conversation as resolved.
Show resolved Hide resolved
"items": {
"$ref": "../../../common-types/v1/common.json#/definitions/SubResource"
}
}
}
},
Expand All @@ -756,6 +777,10 @@
"$ref": "#/definitions/CapacityReservationGroupInstanceView",
"readOnly": true,
"description": "The capacity reservation group instance view which has the list of instance views for all the capacity reservations that belong to the capacity reservation group."
},
"sharingProfile": {
"$ref": "#/definitions/ResourceSharingProfile",
"description": "A list of all subscriptions that the capacity reservation group is shared with. **Note:** Minimum api-version: 2023-09-01. Please refer to https://aka.ms/computereservationsharing for more details."
TimLovellSmith marked this conversation as resolved.
Show resolved Hide resolved
}
},
"description": "capacity reservation group Properties."
Expand Down
42 changes: 39 additions & 3 deletions ...3-09-01/examples/capacityReservationExamples/CapacityReservationGroup_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,19 @@
"zones": [
"1",
"2"
]
],
"properties": {
"sharingProfile": {
"subscriptionIds": [
{
"id": "/subscriptions/{subscription-id1}"
},
{
"id": "/subscriptions/{subscription-id2}"
}
]
}
}
}
},
"responses": {
Expand All @@ -27,7 +39,19 @@
"zones": [
"1",
"2"
]
],
"properties": {
"sharingProfile": {
"subscriptionIds": [
{
"id": "/subscriptions/{subscription-id1}"
},
{
"id": "/subscriptions/{subscription-id2}"
}
]
}
}
}
},
"200": {
Expand All @@ -42,7 +66,19 @@
"zones": [
"1",
"2"
]
],
"properties": {
"sharingProfile": {
"subscriptionIds": [
{
"id": "/subscriptions/{subscription-id1}"
},
{
"id": "/subscriptions/{subscription-id2}"
}
]
}
}
}
}
}
Expand Down
18 changes: 18 additions & 0 deletions .../stable/2023-09-01/examples/capacityReservationExamples/CapacityReservationGroup_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@
"id": "subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup/capacityReservations/myCapacityReservation2"
}
],
"sharingProfile": {
"subscriptionIds": [
{
"id": "/subscriptions/{subscription-id1}"
},
{
"id": "/subscriptions/{subscription-id2}"
}
]
},
"instanceView": {
"capacityReservations": [
{
Expand Down Expand Up @@ -63,6 +73,14 @@
}
]
}
],
"sharedSubscriptionIds": [
{
"id": "/subscriptions/{subscription-id1}"
},
{
"id": "/subscriptions/{subscription-id2}"
}
]
}
},
Expand Down