Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2022-02-14 and stable/2023-07-01 #26309

Merged
merged 17 commits into from
Oct 30, 2023
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2022-02-14 and stable/2023-07-01 #26309

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
69c1892
Adds base for updating Microsoft.VirtualMachineImages from version st…
zdelacerda-microsoft Oct 18, 2023
4851661
Updates readme
zdelacerda-microsoft Oct 18, 2023
bb50b84
Updates API version in new specs and examples
zdelacerda-microsoft Oct 18, 2023
be9831b
copying changes from ADO repo
zdelacerda-microsoft Oct 19, 2023
19e8bd4
adding custom words
zdelacerda-microsoft Oct 19, 2023
aeeea8c
adding distribute to ImageTemplate
zdelacerda-microsoft Oct 23, 2023
180804a
adding bracket for distrubute
zdelacerda-microsoft Oct 23, 2023
ec1171f
replacing CloudError with ErrorResponse
zdelacerda-microsoft Oct 24, 2023
057648c
fixing ErrorResponse typo
zdelacerda-microsoft Oct 24, 2023
8c95d8c
added x-ms-identifiers and fixed other lintdiff
zdelacerda-microsoft Oct 25, 2023
c79d5ed
prettier update
zdelacerda-microsoft Oct 25, 2023
43b4cc7
removing response 200 from delete example files
zdelacerda-microsoft Oct 25, 2023
4593fa2
Merge remote-tracking branch 'refs/remotes/origin/zdelacerda-microsof…
zdelacerda-microsoft Oct 25, 2023
09f692f
fixing distribute for ImageTemplateUpdateParameters
zdelacerda-microsoft Oct 26, 2023
39f9f54
Revert "fixing distribute for ImageTemplateUpdateParameters"
zdelacerda-microsoft Oct 27, 2023
3a6979b
replacing distribute with properties
zdelacerda-microsoft Oct 27, 2023
d6a6895
prettier changes x2
zdelacerda-microsoft Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing distribute for ImageTemplateUpdateParameters
  • Loading branch information
@zdelacerda-microsoft
zdelacerda-microsoft committed Oct 26, 2023
commit 09f692fa75f5327d569a03e3bbb309e639f9fd81
38 changes: 19 additions & 19 deletions ...ilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json#L1 

specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json
zdelacerda-microsoft marked this conversation as resolved.
Show resolved Hide resolved
"swagger": "2.0",
"info": {
"title": "VirtualMachineImageTemplate",
Expand Down Expand Up @@ -1244,7 +1244,7 @@
"items": {
"$ref": "#/definitions/TargetRegion"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"description": "The target regions where the distributed Image Version is going to be replicated to. This object supersedes replicationRegions and can be specified only if replicationRegions is not specified."
},
"versioning": {
Expand Down Expand Up @@ -1503,7 +1503,7 @@
"items": {
"$ref": "#/definitions/ImageTemplateCustomizer"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"description": "Specifies the properties used to describe the customization steps of the image, like Image source etc"
},
"optimize": {
Expand Down Expand Up @@ -1549,7 +1549,7 @@
"items": {
"$ref": "#/definitions/ImageTemplateInVMValidator"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"description": "List of validations to be performed."
}
}
Expand All @@ -1559,7 +1559,7 @@
"items": {
"$ref": "#/definitions/ImageTemplateDistributor"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"description": "The distribution targets where the image output needs to go to."
},
"errorHandling": {
Expand Down Expand Up @@ -1706,28 +1706,28 @@
"required": [
"identity"
],
"x-ms-identifiers": []
"x-ms-identifiers": [ ]
},
"ImageTemplateUpdateParameters": {
"type": "object",
"properties": {
"identity": {
"$ref": "#/definitions/ImageTemplateIdentity",
"description": "The identity of the image template, if configured."
},
"tags": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "The user-specified tags associated with the image template."
"identity": {
"$ref": "#/definitions/ImageTemplateIdentity",
"description": "The identity of the image template, if configured."
},
"tags": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "The user-specified tags associated with the image template."
},
"properties": {
"distribute": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the last lint diff error, the root cause is at this line.

The definition ImageTemplateUpdateParameters is used to update the resource. But the definition of distribute is at a incorrect level, it should be like

identity: {}
tags: {}
properties: {
      distribute: {}
}

but now, distribute is at the same level with tags and identity, please check and fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new commit and it created a ton of new errors. I'm online now for the next hour if you are available to help me fix this. There is some urgency to this PR as I have deadlines to meet. Thank you

"type": "array",
"items": {
"$ref": "#/definitions/ImageTemplateDistributor"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"description": "The distribution targets where the image output needs to go to."
}
},
Expand Down Expand Up @@ -1825,7 +1825,7 @@
"$ref": "#/definitions/TriggerProperties"
}
],
"properties": {}
"properties": { }
},
"Trigger": {
"type": "object",
Expand Down Expand Up @@ -1918,7 +1918,7 @@
"items": {
"$ref": "#/definitions/Operation"
},
"x-ms-identifiers": [],
"x-ms-identifiers": [ ],
"title": "The list of operations supported by the resource provider."
},
"nextLink": {
Expand Down
Loading