Add AIToolchainOperator to AKS preview API #26115

helayoty · 2023-10-06T20:28:32Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-06T20:28:35Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-10-06T20:28:37Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 3 Errors, 9 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedClusters.json	2023-09-02-preview(af58a59)	2023-08-01(main)
managedClusters.json	2023-09-02-preview(af58a59)	2023-08-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: aks/preview/2023-09-02-preview/managedClusters.json#L1133:9 Old: aks/stable/2023-08-01/managedClusters.json#L1133:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: aks/preview/2023-09-02-preview/managedClusters.json#L1255:9 Old: aks/stable/2023-08-01/managedClusters.json#L1244:11
`❌` 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'name' than the previous one. New: aks/preview/2023-09-02-preview/managedClusters.json#L5810:9 Old: aks/stable/2023-08-01/managedClusters.json#L4760:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4288:9 Old: aks/stable/2023-08-01/managedClusters.json#L3302:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4292:9 Old: aks/stable/2023-08-01/managedClusters.json#L3330:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4296:9 Old: aks/stable/2023-08-01/managedClusters.json#L3347:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4300:9 Old: aks/stable/2023-08-01/managedClusters.json#L3374:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4305:9 Old: aks/stable/2023-08-01/managedClusters.json#L3397:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4361:9 Old: aks/stable/2023-08-01/managedClusters.json#L3471:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L4392:11 Old: aks/stable/2023-08-01/managedClusters.json#L3520:11
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-09-02-preview/managedClusters.json#L5278:13 Old: aks/stable/2023-08-01/managedClusters.json#L4286:13

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: aks/preview/2023-09-02-preview/managedClusters.json#L8107:9 Old: aks/preview/2023-08-02-preview/managedClusters.json#L8055:9

️⚠️LintDiff: 1 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-09	package-preview-2023-09(af58a59)	package-preview-2023-09(FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-09-02-preview/managedClusters.json#L8792

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: aks/preview/2023-09-02-preview/managedClusters.json#L52
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: aks/preview/2023-09-02-preview/managedClusters.json#L53
`❌` ParametersInPointGet	Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version. Location: aks/preview/2023-09-02-preview/managedClusters.json#L80
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: aks/preview/2023-09-02-preview/managedClusters.json#L137
`❌` ResourceNameRestriction	The resource name parameter 'roleName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-09-02-preview/managedClusters.json#L278
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-09-02-preview/managedClusters.json#L336
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-09-02-preview/managedClusters.json#L381
`❌` ParametersInPost	format is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-09-02-preview/managedClusters.json#L381
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-09-02-preview/managedClusters.json#L429
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L553
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: aks/preview/2023-09-02-preview/managedClusters.json#L660
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: aks/preview/2023-09-02-preview/managedClusters.json#L679
`❌` LroPatch202	The async patch operation should return 202. Location: aks/preview/2023-09-02-preview/managedClusters.json#L689
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L699
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L749
`❌` ResourceNameRestriction	The resource name parameter 'configName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-09-02-preview/managedClusters.json#L809
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-09-02-preview/managedClusters.json#L979
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1023
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1175
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1291
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1452
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1472
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1491
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1537
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1553
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1600
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1616
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1657
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1673
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-09-02-preview/managedClusters.json#L1710

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Code style issues found path: aks/preview/2023-09-02-preview/managedClusters.json

️❌SpellCheck: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Unknown word (Autp), please fix the error or add words to ./custom-words.txt path: aks/preview/2023-09-02-preview/managedClusters.json#L655:45
`❌` HowToFix	Unknown word (Karpenter), please fix the error or add words to ./custom-words.txt path: aks/preview/2023-09-02-preview/managedClusters.json#L8818:82

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-06T20:28:37Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-go - sdk/resourcemanager/containerservice/armcontainerservice - 4.4.0-beta.3

+	Operation `*TrustedAccessRoleBindingsClient.CreateOrUpdate` has been changed to LRO, use `*TrustedAccessRoleBindingsClient.BeginCreateOrUpdate` instead.
+	Operation `*TrustedAccessRoleBindingsClient.Delete` has been changed to LRO, use `*TrustedAccessRoleBindingsClient.BeginDelete` instead.

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 26.0.0

+	Model ManagedClusterIngressProfileWebAppRouting no longer has parameter dns_zone_resource_id
+	Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
+	Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerservice [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ManagedClustersOperations.get_guardrails_versions
info	[Changelog]   - Added operation ManagedClustersOperations.get_mesh_revision_profile
info	[Changelog]   - Added operation ManagedClustersOperations.get_mesh_upgrade_profile
info	[Changelog]   - Added operation ManagedClustersOperations.list_guardrails_versions
info	[Changelog]   - Added operation ManagedClustersOperations.list_mesh_revision_profiles
info	[Changelog]   - Added operation ManagedClustersOperations.list_mesh_upgrade_profiles
info	[Changelog]   - Added operation group MachinesOperations
info	[Changelog]   - Model AgentPool has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model AgentPool has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model AgentPool has a new parameter gpu_profile
info	[Changelog]   - Model AgentPool has a new parameter message_of_the_day
info	[Changelog]   - Model AgentPool has a new parameter network_profile
info	[Changelog]   - Model AgentPool has a new parameter security_profile
info	[Changelog]   - Model AgentPool has a new parameter windows_profile
info	[Changelog]   - Model AgentPoolUpgradeSettings has a new parameter node_soak_duration_in_minutes
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter kube_proxy_config
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter monitoring
info	[Changelog]   - Model IstioComponents has a new parameter egress_gateways
info	[Changelog]   - Model ManagedCluster has a new parameter ai_toolchain_operator_profile
info	[Changelog]   - Model ManagedCluster has a new parameter creation_data
info	[Changelog]   - Model ManagedCluster has a new parameter enable_namespace_resources
info	[Changelog]   - Model ManagedCluster has a new parameter guardrails_profile
info	[Changelog]   - Model ManagedCluster has a new parameter ingress_profile
info	[Changelog]   - Model ManagedCluster has a new parameter metrics_profile
info	[Changelog]   - Model ManagedCluster has a new parameter node_provisioning_profile
info	[Changelog]   - Model ManagedCluster has a new parameter node_resource_group_profile
info	[Changelog]   - Model ManagedCluster has a new parameter resource_uid
info	[Changelog]   - Model ManagedCluster has a new parameter service_mesh_profile
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter enable_vnet_integration
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter subnet_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter gpu_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter gpu_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAzureMonitorProfile has a new parameter logs
info	[Changelog]   - Model ManagedClusterAzureMonitorProfileMetrics has a new parameter app_monitoring_open_telemetry_metrics
info	[Changelog]   - Model ManagedClusterHTTPProxyConfig has a new parameter effective_no_proxy
info	[Changelog]   - Model ManagedClusterIngressProfileWebAppRouting has a new parameter dns_zone_resource_ids
info	[Changelog]   - Model ManagedClusterLoadBalancerProfile has a new parameter backend_pool_type
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_empty_nodes
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_occupied_nodes
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter expanders
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter ignore_daemonsets_utilization
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter image_integrity
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter node_restriction
info	[Changelog]   - Model ManagedClusterStorageProfileDiskCSIDriver has a new parameter version
info	[Changelog]   - Model ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new parameter addon_autoscaling
info	[Changelog]   - Operation AgentPoolsOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]   - Operation ManagedClustersOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ManagedClusterIngressProfileWebAppRouting no longer has parameter dns_zone_resource_id
info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*TrustedAccessRoleBindingsClient.CreateOrUpdate` has been changed to LRO, use `*TrustedAccessRoleBindingsClient.BeginCreateOrUpdate` instead.
info	[Changelog] - Operation `*TrustedAccessRoleBindingsClient.Delete` has been changed to LRO, use `*TrustedAccessRoleBindingsClient.BeginDelete` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `AgentPoolTypeVirtualMachines` added to enum type `AgentPoolType`
info	[Changelog] - New value `NetworkPolicyNone` added to enum type `NetworkPolicy`
info	[Changelog] - New value `OSSKUWindowsAnnual` added to enum type `OSSKU`
info	[Changelog] - New enum type `AddonAutoscaling` with values `AddonAutoscalingDisabled`, `AddonAutoscalingEnabled`
info	[Changelog] - New enum type `NodeProvisioningMode` with values `NodeProvisioningModeAuto`, `NodeProvisioningModeManual`
info	[Changelog] - New struct `AgentPoolGPUProfile`
info	[Changelog] - New struct `IstioEgressGateway`
info	[Changelog] - New struct `ManagedClusterAIToolchainOperatorProfile`
info	[Changelog] - New struct `ManagedClusterNodeProvisioningProfile`
info	[Changelog] - New field `NodeSoakDurationInMinutes` in struct `AgentPoolUpgradeSettings`
info	[Changelog] - New field `EgressGateways` in struct `IstioComponents`
info	[Changelog] - New field `GpuProfile` in struct `ManagedClusterAgentPoolProfile`
info	[Changelog] - New field `GpuProfile` in struct `ManagedClusterAgentPoolProfileProperties`
info	[Changelog] - New field `AiToolchainOperatorProfile`, `NodeProvisioningProfile` in struct `ManagedClusterProperties`
info	[Changelog] - New field `DaemonsetEvictionForEmptyNodes`, `DaemonsetEvictionForOccupiedNodes`, `Expanders`, `IgnoreDaemonsetsUtilization` in struct `ManagedClusterPropertiesAutoScalerProfile`
info	[Changelog] - New field `AddonAutoscaling` in struct `ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 24 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerservice [View full logs] [Preview SDK Changes]

azure-arm-containerservice-19.4.0-beta.2.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface PortRange
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface ServiceMeshProfile
info	[Changelog]   - Added Interface TrustedAccessRole
info	[Changelog]   - Added Interface TrustedAccessRoleBinding
info	[Changelog]   - Added Interface TrustedAccessRoleBindingListResult
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteHeaders
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsGetOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleListResult
info	[Changelog]   - Added Interface TrustedAccessRoleRule
info	[Changelog]   - Added Interface TrustedAccessRolesListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRolesListOptionalParams
info	[Changelog]   - Added Type Alias AddonAutoscaling
info	[Changelog]   - Added Type Alias AgentPoolSSHAccess
info	[Changelog]   - Added Type Alias BackendPoolType
info	[Changelog]   - Added Type Alias GuardrailsSupport
info	[Changelog]   - Added Type Alias IpvsScheduler
info	[Changelog]   - Added Type Alias IstioIngressGatewayMode
info	[Changelog]   - Added Type Alias Level
info	[Changelog]   - Added Type Alias MachinesGetResponse
info	[Changelog]   - Added Type Alias MachinesListNextResponse
info	[Changelog]   - Added Type Alias MachinesListResponse
info	[Changelog]   - Added Type Alias ManagedClustersGetGuardrailsVersionsResponse
info	[Changelog]   - Added Type Alias ManagedClustersGetMeshRevisionProfileResponse
info	[Changelog]   - Added Type Alias ManagedClustersGetMeshUpgradeProfileResponse
info	[Changelog]   - Added Type Alias ManagedClustersListGuardrailsVersionsNextResponse
info	[Changelog]   - Added Type Alias ManagedClustersListGuardrailsVersionsResponse
info	[Changelog]   - Added Type Alias ManagedClustersListMeshRevisionProfilesNextResponse
info	[Changelog]   - Added Type Alias ManagedClustersListMeshRevisionProfilesResponse
info	[Changelog]   - Added Type Alias ManagedClustersListMeshUpgradeProfilesNextResponse
info	[Changelog]   - Added Type Alias ManagedClustersListMeshUpgradeProfilesResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsGetResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsUpdateTagsResponse
info	[Changelog]   - Added Type Alias Mode
info	[Changelog]   - Added Type Alias NodeProvisioningMode
info	[Changelog]   - Added Type Alias Protocol
info	[Changelog]   - Added Type Alias RestrictionLevel
info	[Changelog]   - Added Type Alias ServiceMeshMode
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsDeleteResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsGetResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListResponse
info	[Changelog]   - Interface AgentPool has a new optional parameter capacityReservationGroupID
info	[Changelog]   - Interface AgentPool has a new optional parameter enableCustomCATrust
info	[Changelog]   - Interface AgentPool has a new optional parameter gpuProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter messageOfTheDay
info	[Changelog]   - Interface AgentPool has a new optional parameter networkProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter securityProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter windowsProfile
info	[Changelog]   - Interface AgentPoolsDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface AgentPoolUpgradeSettings has a new optional parameter nodeSoakDurationInMinutes
info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter kubeProxyConfig
info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter monitoring
info	[Changelog]   - Interface ManagedCluster has a new optional parameter aiToolchainOperatorProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter creationData
info	[Changelog]   - Interface ManagedCluster has a new optional parameter enableNamespaceResources
info	[Changelog]   - Interface ManagedCluster has a new optional parameter guardrailsProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter ingressProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter metricsProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter nodeProvisioningProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter nodeResourceGroupProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter resourceUID
info	[Changelog]   - Interface ManagedCluster has a new optional parameter serviceMeshProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter capacityReservationGroupID
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter enableCustomCATrust
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter gpuProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter messageOfTheDay
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter networkProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter securityProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter windowsProfile
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter enableVnetIntegration
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter subnetId
info	[Changelog]   - Interface ManagedClusterAzureMonitorProfile has a new optional parameter logs
info	[Changelog]   - Interface ManagedClusterAzureMonitorProfileMetrics has a new optional parameter appMonitoringOpenTelemetryMetrics
info	[Changelog]   - Interface ManagedClusterHttpProxyConfig has a new optional parameter effectiveNoProxy
info	[Changelog]   - Interface ManagedClusterLoadBalancerProfile has a new optional parameter backendPoolType
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter daemonsetEvictionForEmptyNodes
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter daemonsetEvictionForOccupiedNodes
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter expanders
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter ignoreDaemonsetsUtilization
info	[Changelog]   - Interface ManagedClustersDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter customCATrustCertificates
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter imageIntegrity
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter nodeRestriction
info	[Changelog]   - Interface ManagedClusterStorageProfileDiskCSIDriver has a new optional parameter version
info	[Changelog]   - Interface ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new optional parameter addonAutoscaling
info	[Changelog]   - Added Enum KnownAddonAutoscaling
info	[Changelog]   - Added Enum KnownAgentPoolSSHAccess
info	[Changelog]   - Added Enum KnownBackendPoolType
info	[Changelog]   - Added Enum KnownGuardrailsSupport
info	[Changelog]   - Added Enum KnownIpvsScheduler
info	[Changelog]   - Added Enum KnownIstioIngressGatewayMode
info	[Changelog]   - Added Enum KnownLevel
info	[Changelog]   - Added Enum KnownMode
info	[Changelog]   - Added Enum KnownNodeProvisioningMode
info	[Changelog]   - Added Enum KnownProtocol
info	[Changelog]   - Added Enum KnownRestrictionLevel
info	[Changelog]   - Added Enum KnownServiceMeshMode
info	[Changelog]   - Added Enum KnownTrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Enum KnownAgentPoolType has a new value VirtualMachines
info	[Changelog]   - Enum KnownNetworkPolicy has a new value None
info	[Changelog]   - Enum KnownNodeOSUpgradeChannel has a new value SecurityPatch
info	[Changelog]   - Enum KnownOssku has a new value Mariner
info	[Changelog]   - Enum KnownOssku has a new value WindowsAnnual
info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
info	[Changelog]   - Enum KnownSnapshotType has a new value ManagedCluster
info	[Changelog]   - Enum KnownWorkloadRuntime has a new value KataMshvVmIsolation

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ContainerService [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.ContainerService.1.2.0-alpha.20231010.1.nupkg
```
info	[Changelog]
```

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
cannot force update branch 'sdkAuto/26115/containerservice' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/26115/containerservice' as it is the current HEAD of the repository.

️✔️containerservice [View full logs]

️✔️containerservice [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/26115/containerservice' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		containerservice
error		containerservice

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 2a138245a5de65c527c3bf2b06af1ee7a8536855. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerservice.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-06T20:28:38Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerservice/armcontainerservice	https://apiview.dev/Assemblies/Review/f72392ab69d346d48034a085d9eaace9
.Net	Azure.ResourceManager.ContainerService	There is no API change compared with the previous version
Java	azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated	https://apiview.dev/Assemblies/Review/2663bb65b2df45e79842973931ed63df
JavaScript	@azure/arm-containerservice	https://apiview.dev/Assemblies/Review/3203839faf384cc8b578ca5c1856ef53
Swagger	Microsoft.ContainerService	https://apiview.dev/Assemblies/Review/d37b56ba3a244d4a91e6d062777659ce

custom-words.txt

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

…-2023-09-02-preview' into FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview

FumingZhang · 2023-10-10T05:02:02Z

Replaced by #26151

helayoty requested review from palma21, weinong, alvinli222, matthchr and circy9 as code owners October 6, 2023 20:28

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Oct 6, 2023

azure-sdk mentioned this pull request Oct 6, 2023

[AutoPR sdk/resourcemanager/containerservice/armcontainerservice] Add AIToolchainOperator to AKS preview API azure-sdk/azure-sdk-for-go#7576

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 6, 2023

helayoty force-pushed the FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview branch from 1313c99 to 7ec07d8 Compare October 6, 2023 20:36

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 6, 2023

FumingZhang reviewed Oct 9, 2023

View reviewed changes

custom-words.txt Outdated Show resolved Hide resolved

helayoty added 2 commits October 9, 2023 10:40

Add AIToolchainOperator to AKS preview API

087f9db

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

Remove custom name from the PR

62fbd87

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview branch from ad9a96b to 62fbd87 Compare October 9, 2023 17:40

Merge branch 'FumingZhang-containerservice-Microsoft.ContainerService…

af58a59

…-2023-09-02-preview' into FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview

FumingZhang closed this Oct 10, 2023

helayoty deleted the FumingZhang-containerservice-Microsoft.ContainerService-2023-09-02-preview branch October 10, 2023 20:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AIToolchainOperator to AKS preview API #26115

Add AIToolchainOperator to AKS preview API #26115

helayoty commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

FumingZhang commented Oct 10, 2023

Add AIToolchainOperator to AKS preview API #26115

Add AIToolchainOperator to AKS preview API #26115

Conversation

helayoty commented Oct 6, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 6, 2023 • edited Loading

openapi-pipeline-app bot commented Oct 6, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 6, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 6, 2023 • edited Loading

Generated ApiView

FumingZhang commented Oct 10, 2023

helayoty commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 6, 2023 •

edited

Loading