Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ZRS support for snapshots, new apiversion 2018-04-01 #2552

Merged
merged 9 commits into from
Mar 8, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4502,7 +4502,7 @@
],
"x-ms-enum": {
"name": "DiskCreateOptionTypes",
"modelAsString": false
"modelAsString": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olydis Does this constitute a breaking change for C#?

Copy link
Contributor Author

@carissasun carissasun Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is needed in order to add new create types, in addition I'm changing it in disk.json so the two need to match

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhendrixMSFT yes (and for other languages)

}
},
"StorageAccountType": {
Expand All @@ -4514,7 +4514,7 @@
],
"x-ms-enum": {
"name": "StorageAccountTypes",
"modelAsString": false
"modelAsString": true
}
},
"ManagedDiskParameters": {
Expand Down
Loading