Add type to Certificate #25380

zhenqxuMSFT · 2023-08-18T05:15:46Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-18T05:15:49Z

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

⌛ Please wait, next steps to merge this PR are being evaluated by automation. ⌛

openapi-pipeline-app · 2023-08-18T05:15:50Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
CommonDefinitions.json	2023-08-01-preview(6c0014a)	2023-05-01(main)
CommonDefinitions.json	2023-08-01-preview(6c0014a)	2023-05-02-preview(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-preview-2023-08	package-preview-2023-08(6c0014a)	package-preview-2023-08(release-app-Microsoft.App-2023-08-01-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L97
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L281
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L412
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L435
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L518
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L522
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L526
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L589
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L715
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L730
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L906
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1020
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1035
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1048
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1109
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1128
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1146
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L156
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L230
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L350
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L731
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L747
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L907
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L911

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-18T05:15:51Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsAPIClientOperationsMixin.get_custom_domain_verification_id
info	[Changelog]   - Added operation group ManagedEnvironmentUsagesOperations
info	[Changelog]   - Added operation group UsagesOperations
info	[Changelog]   - Model AuthConfig has a new parameter encryption_settings
info	[Changelog]   - Model CertificateProperties has a new parameter type
info	[Changelog]   - Model Ingress has a new parameter additional_port_mappings
info	[Changelog]   - Model Login has a new parameter token_store

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `CertificateType` with values `CertificateTypeImagePullTrustedCA`, `CertificateTypeServerSSLCertificate`
info	[Changelog] - New function `*ClientFactory.NewManagedEnvironmentUsagesClient() *ManagedEnvironmentUsagesClient`
info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
info	[Changelog] - New function `*ContainerAppsAPIClient.GetCustomDomainVerificationID(context.Context, *ContainerAppsAPIClientGetCustomDomainVerificationIDOptions) (ContainerAppsAPIClientGetCustomDomainVerificationIDResponse, error)`
info	[Changelog] - New function `NewManagedEnvironmentUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentUsagesClient, error)`
info	[Changelog] - New function `*ManagedEnvironmentUsagesClient.NewListPager(string, string, *ManagedEnvironmentUsagesClientListOptions) *runtime.Pager[ManagedEnvironmentUsagesClientListResponse]`
info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
info	[Changelog] - New function `*UsagesClient.NewListPager(string, *UsagesClientListOptions) *runtime.Pager[UsagesClientListResponse]`
info	[Changelog] - New struct `BlobStorageTokenStore`
info	[Changelog] - New struct `EncryptionSettings`
info	[Changelog] - New struct `IngressPortMapping`
info	[Changelog] - New struct `ListUsagesResult`
info	[Changelog] - New struct `TokenStore`
info	[Changelog] - New struct `Usage`
info	[Changelog] - New struct `UsageName`
info	[Changelog] - New field `EncryptionSettings` in struct `AuthConfigProperties`
info	[Changelog] - New field `Type` in struct `CertificateProperties`
info	[Changelog] - New field `AdditionalPortMappings` in struct `Ingress`
info	[Changelog] - New field `TokenStore` in struct `Login`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 28 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes]

azure-arm-appcontainers-2.1.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ManagedEnvironmentUsages
info	[Changelog]   - Added operation group Usages
info	[Changelog]   - Added Interface BlobStorageTokenStore
info	[Changelog]   - Added Interface EncryptionSettings
info	[Changelog]   - Added Interface GetCustomDomainVerificationIdOptionalParams
info	[Changelog]   - Added Interface IngressPortMapping
info	[Changelog]   - Added Interface ListUsagesResult
info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListNextOptionalParams
info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListOptionalParams
info	[Changelog]   - Added Interface TokenStore
info	[Changelog]   - Added Interface Usage
info	[Changelog]   - Added Interface UsageName
info	[Changelog]   - Added Interface UsagesListNextOptionalParams
info	[Changelog]   - Added Interface UsagesListOptionalParams
info	[Changelog]   - Added Type Alias CertificateType
info	[Changelog]   - Added Type Alias GetCustomDomainVerificationIdResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListResponse
info	[Changelog]   - Added Type Alias UsagesListNextResponse
info	[Changelog]   - Added Type Alias UsagesListResponse
info	[Changelog]   - Interface AuthConfig has a new optional parameter encryptionSettings
info	[Changelog]   - Interface CertificateProperties has a new optional parameter type
info	[Changelog]   - Interface Ingress has a new optional parameter additionalPortMappings
info	[Changelog]   - Interface Login has a new optional parameter tokenStore
info	[Changelog]   - Added Enum KnownCertificateType

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 41003cc04ffe06ff7b38984671347b1bd8655c9c. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.app.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.app.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-18T05:15:51Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/341724ffdd354401997a897d8d6db4c8
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/368ee9ef83c64de4ac7be2282544ae12
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/a7273eb9b88e4b30b92a2273afc7169c
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/29524b8fa373453b8b57c711ba5c1754

openapi-pipeline-app · 2023-08-18T07:08:07Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json

kazrael2119 · 2023-08-28T07:10:37Z

/azp run

azure-pipelines · 2023-08-28T07:10:49Z

Azure Pipelines successfully started running 2 pipeline(s).

kazrael2119 · 2023-08-28T07:20:48Z

remove "CI-BreakingChange-JavaScript" label because there is not any breaking

Juliehzl · 2023-08-29T05:44:26Z

/pr RequestMerge

sjanamma

approved for merge

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate * update tests for jobs * update tests for jobs * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples * fix name and resource values in examples --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

Add type to Certificate

bd2d8b1

openapi-assignment-bot bot assigned rkmanda Aug 18, 2023

azure-sdk mentioned this pull request Aug 18, 2023

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Add type to Certificate azure-sdk/azure-sdk-for-go#6991

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 18, 2023

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 18, 2023

This was referenced Aug 18, 2023

[AutoPR app] Add type to Certificate azure-sdk/azure-resource-manager-schemas#3103

Draft

[AutoPR track2_azure-mgmt-appcontainers] Add type to Certificate azure-sdk/azure-sdk-for-python#4429

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Aug 18, 2023

azure-sdk mentioned this pull request Aug 18, 2023

[AutoPR @azure/arm-appcontainers] Add type to Certificate azure-sdk/azure-sdk-for-js#6360

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 18, 2023

azure-sdk mentioned this pull request Aug 18, 2023

[AutoPR azure-resourcemanager-appcontainers] Add type to Certificate azure-sdk/azure-sdk-for-java#6593

Closed

lint

6c0014a

Juliehzl reviewed Aug 21, 2023

View reviewed changes

...ication/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json Show resolved Hide resolved

ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 25, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 25, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Aug 28, 2023

kazrael2119 removed the CI-BreakingChange-JavaScript label Aug 28, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 28, 2023

msyyc added the Approved-SdkBreakingChange-Python label Aug 29, 2023

qiaozha added the Approved-SdkBreakingChange-JavaScript label Aug 29, 2023

github-actions bot added the MergeRequested label Aug 29, 2023

sjanamma approved these changes Aug 29, 2023

View reviewed changes

sjanamma merged commit 4486efe into Azure:release-app-Microsoft.App-2023-08-01-preview Aug 29, 2023
26 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add type to Certificate #25380

Add type to Certificate #25380

zhenqxuMSFT commented Aug 18, 2023 •

edited by Juliehzl

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

kazrael2119 commented Aug 28, 2023

azure-pipelines bot commented Aug 28, 2023

kazrael2119 commented Aug 28, 2023

Juliehzl commented Aug 29, 2023

sjanamma left a comment

Add type to Certificate #25380

Add type to Certificate #25380

Conversation

zhenqxuMSFT commented Aug 18, 2023 • edited by Juliehzl Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Getting help

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

kazrael2119 commented Aug 28, 2023

azure-pipelines bot commented Aug 28, 2023

kazrael2119 commented Aug 28, 2023

Juliehzl commented Aug 29, 2023

sjanamma left a comment

Choose a reason for hiding this comment

zhenqxuMSFT commented Aug 18, 2023 •

edited by Juliehzl

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading