Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add force upgrade option #25100

Merged
merged 2 commits into from
Aug 3, 2023
Merged

add force upgrade option #25100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dabe0b
add force upgrade option
Aug 1, 2023
8678fb6
update msg
Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...crosoft.ContainerService/aks/stable/2023-07-01/examples/ManagedClustersCreate_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@
}
}
},
"upgradeSettings": {
"overrideSettings": {
"forceUpgrade": false,
"until": "2022-11-01T13:00:00Z"
}
},
"autoScalerProfile": {
"balance-similar-node-groups": "true",
"expander": "priority",
Expand Down Expand Up @@ -175,6 +181,12 @@
]
}
},
"upgradeSettings": {
"overrideSettings": {
"forceUpgrade": false,
"until": "2022-11-01T13:00:00Z"
}
},
"autoScalerProfile": {
"balance-similar-node-groups": "true",
"expander": "priority",
Expand Down
6 changes: 6 additions & 0 deletions ...manager/Microsoft.ContainerService/aks/stable/2023-07-01/examples/ManagedClustersGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@
}
]
}
},
"upgradeSettings": {
"overrideSettings": {
"forceUpgrade": true,
"until": "2022-11-01T13:00:00Z"
}
}
}
}
Expand Down
29 changes: 29 additions & 0 deletions ...ce/resource-manager/Microsoft.ContainerService/aks/stable/2023-07-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4092,6 +4092,10 @@
"$ref": "#/definitions/ManagedClusterAutoUpgradeProfile",
"description": "The auto upgrade configuration."
},
"upgradeSettings": {
"$ref": "#/definitions/ClusterUpgradeSettings",
"description": "Settings for upgrading a cluster."
},
"autoScalerProfile": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -4597,6 +4601,31 @@
},
"description": "Auto upgrade profile for a managed cluster."
},
"UpgradeOverrideSettings": {
"type": "object",
"properties": {
"forceUpgrade": {
"type": "boolean",
"description": "Whether to force upgrade the cluster."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Might be worth clarifying what exactly force means? It bypasses certain checks? What checks? Are they documented someplace (can we link to aka.ms?)

Also might be worth leaving a note here that users should use force with caution as the checks that are being bypassed exist to prevent the users workloads from breaking on upgrade?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment will apply to the documentation in the other PR as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPdated

},
"until": {
"type": "string",
"format": "date-time",
"description": "Until when the overrides are effective. Note that this only matches the start time of an upgrade, and the effectiveness won't change once an upgrade starts even if the `until` expires as upgrade proceeds. This field is not set by default. It must be set for the overrides to take effect."
}
},
"description": "Settings for overrides when upgrading a cluster."
},
"ClusterUpgradeSettings": {
"type": "object",
"properties": {
"overrideSettings": {
"$ref": "#/definitions/UpgradeOverrideSettings",
"description": "Settings for overrides."
}
},
"description": "Settings for upgrading a cluster."
},
"ManagedClusterAADProfile": {
"type": "object",
"properties": {
Expand Down