Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2023-06-01 #25004

Merge branch 'main' into prateekprshr-nith-azurestackhci-Microsoft.Az…

12b3503
Select commit
Loading
Failed to load commit list.
Merged

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2023-06-01 #25004

Merge branch 'main' into prateekprshr-nith-azurestackhci-Microsoft.Az…
12b3503
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff completed Aug 23, 2023 in 3m 37s

Swagger LintDiff failed

LintDiff: 8 Errors, 8 Warnings
The check status is neutral due to the check was suppressed by label Approved-LintDiff. If you have any question, pls contact vscswagger@microsoft.com
View more details.

Details

compared tags (via openapi-validator v2.1.4) new version base version
package-2023-06 package-2023-06(12b3503) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.AzureStackHCI/stable/2023-06-01/arcSettings.json#L607
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.AzureStackHCI/stable/2023-06-01/extensions.json#L437
TrackedResourcePatchOperation Tracked resource 'UpdateRun' must have patch operation that at least supports the update of tags.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateRuns.json#L255
RPC-Patch-V1-03
TrackedResourcePatchOperation Tracked resource 'Update' must have patch operation that at least supports the update of tags.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L313
RPC-Patch-V1-03
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L427
MissingTypeObject The schema 'PrecheckResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L553
TrackedResourcePatchOperation Tracked resource 'UpdateSummaries' must have patch operation that at least supports the update of tags.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L235
RPC-Patch-V1-03
MissingTypeObject The schema 'PrecheckResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L389
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'createarcidentity' in:'ArcSettings_CreateIdentity'. Consider updating the operationId
Location: Microsoft.AzureStackHCI/stable/2023-06-01/arcSettings.json#L316
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'createclusteridentity' in:'Clusters_CreateIdentity'. Consider updating the operationId
Location: Microsoft.AzureStackHCI/stable/2023-06-01/clusters.json#L359
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create cluster Identity
Location: Microsoft.AzureStackHCI/stable/2023-06-01/clusters.json#L410
⚠️ PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.AzureStackHCI/stable/2023-06-01/operations.json#L38
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Update runs under cluster resource
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateRuns.json#L228
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'apply' in:'Updates_Post'. Consider updating the operationId
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L39
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List available updates
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L121
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Update summaries under cluster resource
Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L207