Add OT and AI config #24777

michaelkira · 2023-07-12T02:32:36Z

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

openapi-workflow-bot · 2023-07-12T02:32:39Z

Hi, @michaelkira! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-07-12T02:32:41Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 8 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
ManagedEnvironments.json	2023-05-02-preview(4d73efe)	2022-10-01(main)
ManagedEnvironments.json	2023-05-02-preview(4d73efe)	2023-04-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'EnvironmentSkuProperties' removed or renamed? New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1046:3 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L751:3
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1444:7 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L1029:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'sku' renamed or removed? New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1242:7 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L857:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'runtimeSubnetId' renamed or removed? New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1181:7 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L794:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'outboundSettings' renamed or removed? New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1181:7 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L794:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'name' that was not found in the old version. New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1444:7 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L1029:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'name' that was not found in the old version. New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1333:15 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L944:15
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'name' that was not found in the old version. New: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1441:5 Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L1026:5

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.3)	new version	base version
package-preview-2023-05	package-preview-2023-05(4d73efe)	package-preview-2023-05(release-Microsoft.App-2023-05-02-preview)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L101
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L181
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L197
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L240
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L249
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L286
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L301
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L307
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L319
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L369
`❌` ResourceNameRestriction	The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L369
`❌` PutResponseSchemaDescription	Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L462
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L597
`❌` ResourceNameRestriction	The resource name parameter 'managedCertificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L597
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L690
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L703
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L710
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L839
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L889
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L948
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L995
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1182
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1228
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1313
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1356
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1478

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-12T02:32:42Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsOperations.begin_start
info	[Changelog]   - Added operation ContainerAppsOperations.begin_stop
info	[Changelog]   - Added operation group BuildersOperations
info	[Changelog]   - Added operation group BuildsOperations
info	[Changelog]   - Added operation group ContainerAppsAPIClientOperationsMixin
info	[Changelog]   - Model AzureCredentials has a new parameter kind
info	[Changelog]   - Model Configuration has a new parameter service
info	[Changelog]   - Model GithubActionConfiguration has a new parameter github_personal_access_token
info	[Changelog]   - Model Ingress has a new parameter additional_port_mappings
info	[Changelog]   - Model JobConfiguration has a new parameter event_trigger_config
info	[Changelog]   - Model Login has a new parameter token_store
info	[Changelog]   - Model ManagedEnvironment has a new parameter app_insights_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter open_telemetry_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter peer_authentication
info	[Changelog]   - Model Replica has a new parameter init_containers
info	[Changelog]   - Model Replica has a new parameter running_state
info	[Changelog]   - Model Replica has a new parameter running_state_details
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state_details
info	[Changelog]   - Model Revision has a new parameter running_state
info	[Changelog]   - Model Template has a new parameter service_binds
info	[Changelog]   - Model Template has a new parameter termination_grace_period_seconds
info	[Changelog]   - Model Volume has a new parameter mount_options
info	[Changelog]   - Model VolumeMount has a new parameter sub_path
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Operation JobsOperations.begin_stop_multiple_executions no longer has parameter job_execution_name

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*JobsClient.BeginStopMultipleExecutions` parameter(s) have been changed from `(context.Context, string, string, JobExecutionNamesCollection, *JobsClientBeginStopMultipleExecutionsOptions)` to `(context.Context, string, string, *JobsClientBeginStopMultipleExecutionsOptions)`
info	[Changelog] - `TriggerTypeScheduled` from enum `TriggerType` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `TriggerTypeSchedule` added to enum type `TriggerType`
info	[Changelog] - New enum type `BuildStatus` with values `BuildStatusCanceled`, `BuildStatusFailed`, `BuildStatusInProgress`, `BuildStatusNotStarted`, `BuildStatusSucceeded`
info	[Changelog] - New enum type `ContainerAppContainerRunningState` with values `ContainerAppContainerRunningStateRunning`, `ContainerAppContainerRunningStateTerminated`, `ContainerAppContainerRunningStateWaiting`
info	[Changelog] - New enum type `ContainerAppReplicaRunningState` with values `ContainerAppReplicaRunningStateNotRunning`, `ContainerAppReplicaRunningStateRunning`, `ContainerAppReplicaRunningStateUnknown`
info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
info	[Changelog] - New enum type `RevisionRunningState` with values `RevisionRunningStateDegraded`, `RevisionRunningStateFailed`, `RevisionRunningStateProcessing`, `RevisionRunningStateRunning`, `RevisionRunningStateStopped`, `RevisionRunningStateUnknown`
info	[Changelog] - New function `NewBuildersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildersClient, error)`
info	[Changelog] - New function `*BuildersClient.BeginCreateOrUpdate(context.Context, string, string, BuilderResource, *BuildersClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildersClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*BuildersClient.BeginDelete(context.Context, string, string, *BuildersClientBeginDeleteOptions) (*runtime.Poller[BuildersClientDeleteResponse], error)`
info	[Changelog] - New function `*BuildersClient.Get(context.Context, string, string, *BuildersClientGetOptions) (BuildersClientGetResponse, error)`
info	[Changelog] - New function `*BuildersClient.NewListByResourceGroupPager(string, *BuildersClientListByResourceGroupOptions) *runtime.Pager[BuildersClientListByResourceGroupResponse]`
info	[Changelog] - New function `*BuildersClient.NewListBySubscriptionPager(*BuildersClientListBySubscriptionOptions) *runtime.Pager[BuildersClientListBySubscriptionResponse]`
info	[Changelog] - New function `*BuildersClient.BeginUpdate(context.Context, string, string, BuilderResourceUpdate, *BuildersClientBeginUpdateOptions) (*runtime.Poller[BuildersClientUpdateResponse], error)`
info	[Changelog] - New function `NewBuildsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildsClient, error)`
info	[Changelog] - New function `*BuildsClient.BeginCreateOrUpdate(context.Context, string, string, string, BuildResource, *BuildsClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*BuildsClient.BeginDelete(context.Context, string, string, string, *BuildsClientBeginDeleteOptions) (*runtime.Poller[BuildsClientDeleteResponse], error)`
info	[Changelog] - New function `*BuildsClient.Get(context.Context, string, string, string, *BuildsClientGetOptions) (BuildsClientGetResponse, error)`
info	[Changelog] - New function `*BuildsClient.NewListByBuilderResourcePager(string, string, *BuildsClientListByBuilderResourceOptions) *runtime.Pager[BuildsClientListByBuilderResourceResponse]`
info	[Changelog] - New function `*ClientFactory.NewBuildersClient() *BuildersClient`
info	[Changelog] - New function `*ClientFactory.NewBuildsClient() *BuildsClient`
info	[Changelog] - New function `*ClientFactory.NewContainerAppsAPIClient() *ContainerAppsAPIClient`
info	[Changelog] - New function `NewContainerAppsAPIClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ContainerAppsAPIClient, error)`
info	[Changelog] - New function `*ContainerAppsAPIClient.GetVerificationID(context.Context, *ContainerAppsAPIClientGetVerificationIDOptions) (ContainerAppsAPIClientGetVerificationIDResponse, error)`
info	[Changelog] - New function `*ContainerAppsAPIClient.JobExecution(context.Context, string, string, string, *ContainerAppsAPIClientJobExecutionOptions) (ContainerAppsAPIClientJobExecutionResponse, error)`
info	[Changelog] - New function `*ContainerAppsClient.BeginStart(context.Context, string, string, *ContainerAppsClientBeginStartOptions) (*runtime.Poller[ContainerAppsClientStartResponse], error)`
info	[Changelog] - New function `*ContainerAppsClient.BeginStop(context.Context, string, string, *ContainerAppsClientBeginStopOptions) (*runtime.Poller[ContainerAppsClientStopResponse], error)`
info	[Changelog] - New struct `AppInsightsConfiguration`
info	[Changelog] - New struct `BlobStorageTokenStore`
info	[Changelog] - New struct `BuildCollection`
info	[Changelog] - New struct `BuildConfiguration`
info	[Changelog] - New struct `BuildProperties`
info	[Changelog] - New struct `BuildResource`
info	[Changelog] - New struct `BuilderCollection`
info	[Changelog] - New struct `BuilderProperties`
info	[Changelog] - New struct `BuilderResource`
info	[Changelog] - New struct `BuilderResourceUpdate`
info	[Changelog] - New struct `BuilderResourceUpdateProperties`
info	[Changelog] - New struct `ContainerRegistry`
info	[Changelog] - New struct `ContainerRegistryWithCustomImage`
info	[Changelog] - New struct `DataDogConfiguration`
info	[Changelog] - New struct `DestinationsConfiguration`
info	[Changelog] - New struct `EnvironmentVariable`
info	[Changelog] - New struct `HTTPGet`
info	[Changelog] - New struct `IngressPortMapping`
info	[Changelog] - New struct `JobConfigurationEventTriggerConfig`
info	[Changelog] - New struct `JobScale`
info	[Changelog] - New struct `JobScaleRule`
info	[Changelog] - New struct `LogsConfiguration`
info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerAuthentication`
info	[Changelog] - New struct `MetricsConfiguration`
info	[Changelog] - New struct `Mtls`
info	[Changelog] - New struct `OpenTelemetryConfiguration`
info	[Changelog] - New struct `PreBuildStep`
info	[Changelog] - New struct `Service`
info	[Changelog] - New struct `ServiceBind`
info	[Changelog] - New struct `TokenStore`
info	[Changelog] - New struct `TracesConfiguration`
info	[Changelog] - New field `Kind` in struct `AzureCredentials`
info	[Changelog] - New field `Service` in struct `Configuration`
info	[Changelog] - New field `GithubPersonalAccessToken` in struct `GithubActionConfiguration`
info	[Changelog] - New field `AdditionalPortMappings` in struct `Ingress`
info	[Changelog] - New field `EventTriggerConfig` in struct `JobConfiguration`
info	[Changelog] - New field `TokenStore` in struct `Login`
info	[Changelog] - New field `AppInsightsConfiguration`, `OpenTelemetryConfiguration`, `PeerAuthentication` in struct `ManagedEnvironmentProperties`
info	[Changelog] - New field `RunningState`, `RunningStateDetails` in struct `ReplicaContainer`
info	[Changelog] - New field `InitContainers`, `RunningState`, `RunningStateDetails` in struct `ReplicaProperties`
info	[Changelog] - New field `RunningState` in struct `RevisionProperties`
info	[Changelog] - New field `ServiceBinds`, `TerminationGracePeriodSeconds` in struct `Template`
info	[Changelog] - New field `MountOptions` in struct `Volume`
info	[Changelog] - New field `SubPath` in struct `VolumeMount`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 124 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-appcontainers-2.0.0-beta.4.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ContainerAppsStartResponse
info	[Changelog]   - Added Type Alias ContainerAppsStopResponse
info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
info	[Changelog]   - Added Type Alias ExtendedLocationTypes
info	[Changelog]   - Added Type Alias GetVerificationIdResponse
info	[Changelog]   - Added Type Alias IngressClientCertificateMode
info	[Changelog]   - Added Type Alias JobExecutionResponse
info	[Changelog]   - Added Type Alias JobExecutionRunningState
info	[Changelog]   - Added Type Alias JobProvisioningState
info	[Changelog]   - Added Type Alias JobsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListNextResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListResponse
info	[Changelog]   - Added Type Alias JobsGetResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias JobsListSecretsResponse
info	[Changelog]   - Added Type Alias JobsStartResponse
info	[Changelog]   - Added Type Alias JobsStopMultipleExecutionsResponse
info	[Changelog]   - Added Type Alias JobsUpdateResponse
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias ProvisioningState
info	[Changelog]   - Added Type Alias RevisionRunningState
info	[Changelog]   - Added Type Alias TriggerType
info	[Changelog]   - Interface AzureCredentials has a new optional parameter kind
info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
info	[Changelog]   - Interface Configuration has a new optional parameter service
info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
info	[Changelog]   - Interface ContainerApp has a new optional parameter managedBy
info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileName
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter identity
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter githubPersonalAccessToken
info	[Changelog]   - Interface Ingress has a new optional parameter additionalPortMappings
info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
info	[Changelog]   - Interface Login has a new optional parameter tokenStore
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter appInsightsConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter daprConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter infrastructureResourceGroup
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kedaConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter openTelemetryConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter peerAuthentication
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
info	[Changelog]   - Interface Replica has a new optional parameter initContainers
info	[Changelog]   - Interface Replica has a new optional parameter runningState
info	[Changelog]   - Interface Replica has a new optional parameter runningStateDetails
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningState
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningStateDetails
info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
info	[Changelog]   - Interface Revision has a new optional parameter runningState
info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
info	[Changelog]   - Interface Secret has a new optional parameter identity
info	[Changelog]   - Interface Secret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface Template has a new optional parameter initContainers
info	[Changelog]   - Interface Template has a new optional parameter serviceBinds
info	[Changelog]   - Interface Template has a new optional parameter terminationGracePeriodSeconds
info	[Changelog]   - Interface Volume has a new optional parameter mountOptions
info	[Changelog]   - Interface Volume has a new optional parameter secrets
info	[Changelog]   - Interface VolumeMount has a new optional parameter subPath
info	[Changelog]   - Added Enum KnownAction
info	[Changelog]   - Added Enum KnownAffinity
info	[Changelog]   - Added Enum KnownApplicability
info	[Changelog]   - Added Enum KnownBuildStatus
info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Enum KnownContainerAppContainerRunningState
info	[Changelog]   - Added Enum KnownContainerAppReplicaRunningState
info	[Changelog]   - Added Enum KnownExtendedLocationTypes
info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
info	[Changelog]   - Added Enum KnownJobExecutionRunningState
info	[Changelog]   - Added Enum KnownJobProvisioningState
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
info	[Changelog]   - Added Enum KnownProvisioningState
info	[Changelog]   - Added Enum KnownRevisionRunningState
info	[Changelog]   - Added Enum KnownTriggerType
info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
info	[Changelog]   - Enum KnownStorageType has a new value Secret
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface VnetConfiguration no longer has parameter runtimeSubnetId
info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 5de1e2677400a321c7566f4ddfb086ffa91b815f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.app.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.app.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-12T02:32:42Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/d3935d74e8f64c1887fad1a4eb94bcfb
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/882936c2d8e0457697712fc84eafcd31
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/2d23c4122c524d0c95fbdbe839a95f53

openapi-workflow-bot · 2023-07-12T02:39:14Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

openapi-workflow-bot · 2023-07-12T02:39:14Z

Hi @michaelkira! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

You cannot proceed with merging this PR until you complete one of the following action items:

ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.

ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

michaelkira · 2023-07-12T03:50:18Z

@rkmanda the breaking change is not introduced by my PR and it's already been approved in this PR. #24103

Add OT and AI config

f1b0f51

openapi-assignment-bot bot assigned rkmanda Jul 12, 2023

AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Jul 12, 2023

michaelkira added 2 commits July 12, 2023 15:23

add example

6bda6d1

fix code style

4d73efe

rkmanda added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 17, 2023

jijohn14 closed this Jul 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OT and AI config #24777

Add OT and AI config #24777

michaelkira commented Jul 12, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jul 12, 2023

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jul 12, 2023

openapi-workflow-bot bot commented Jul 12, 2023

michaelkira commented Jul 12, 2023

Add OT and AI config #24777

Add OT and AI config #24777

Conversation

michaelkira commented Jul 12, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-workflow-bot bot commented Jul 12, 2023

openapi-pipeline-app bot commented Jul 12, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 12, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 12, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jul 12, 2023

openapi-workflow-bot bot commented Jul 12, 2023

michaelkira commented Jul 12, 2023

michaelkira commented Jul 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 12, 2023 •

edited

Loading