-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OT and AI config #24777
Add OT and AI config #24777
Conversation
Hi, @michaelkira! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
ManagedEnvironments.json | 2023-05-02-preview(4d73efe) | 2022-10-01(main) |
ManagedEnvironments.json | 2023-05-02-preview(4d73efe) | 2023-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-preview-2023-05 | package-preview-2023-05(4d73efe) | package-preview-2023-05(release-Microsoft.App-2023-05-02-preview) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L101 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L181 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L197 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L240 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L249 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L286 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L301 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L307 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L319 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L369 |
ResourceNameRestriction |
The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L369 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L462 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L597 |
ResourceNameRestriction |
The resource name parameter 'managedCertificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L597 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L690 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L703 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L710 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L839 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L889 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L948 |
ResourceNameRestriction |
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L995 |
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1182 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1228 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1313 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1356 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-05-02-preview/ManagedEnvironments.json#L1478 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Hi @michaelkira! The automation detected breaking changes in this pull request. As a result, it added the |
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.