Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment.yml (workflow-bot comments): update breaking changes alternative C to point to alternative B #24770

Merged
merged 1 commit into from
Jul 11, 2023
Merged

comment.yml (workflow-bot comments): update breaking changes alternative C to point to alternative B #24770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
**ACTION ITEM ALTERNATIVE C**: Report false positive. <br/>
If you think there are no breaking changes,
i.e. the validation should pass yet it fails,
then please explain why in a PR comment and @ the PR assignee.
then proceed as explained in **ACTION ITEM ALTERNATIVE B**.<br/>
This applies even if the breaking change tool fails with internal runtime error.
In such case a manual breaking change review is necessary.
- rule:
type: label
Expand All @@ -47,7 +49,9 @@
**ACTION ITEM ALTERNATIVE C**: Report false positive. <br/>
If you think there are no changes in existing API version,
i.e. there should be no `NewApiVersionRequired` label,
then please explain why in a PR comment and @ the PR assignee.
then proceed as explained in **ACTION ITEM ALTERNATIVE B**.<br/>
This applies even if the breaking change tool fails with internal runtime error.
In such case a manual breaking change review is necessary.
<br/><br/>
For additional guidance, please see https://aka.ms/NewApiVersionRequired
Expand Down