Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Moving 2016-09-01-preview spec from private repo #2427

Merged
merged 2 commits into from
Feb 6, 2018

Conversation

brjohnstmsft
Copy link
Member

@brjohnstmsft brjohnstmsft commented Feb 6, 2018

Prior to the reorganization of the azure-rest-api-specs repo structure, the Swagger specs for the Azure Search data plane API version 2016-09-01-preview lived in the search-service branch of the azure-rest-api-specs-pr repo. Now that there is a place for preview/incomplete Swagger specs in the public repo,
we'd like to move this spec there so all the specs are in one place.

The specs themselves have not changed; This is just a repo-to-repo copy.

Like all Azure Search data plane specs, these are incomplete. See this issue for details: #1085


This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Prior to the reorganization of the azure-rest-api-specs repo structure, the
Swagger specs for the Azure Search data plane API version 2016-09-01-preview
lived in the search-service branch of the azure-rest-api-specs-pr repo. Now
that there is a place for preview/incomplete Swagger specs in the public repo,
we'd like to move this spec there so all the specs are in one place.

The specs themselves have not changed; This is just a repo-to-repo copy.

Like all Azure Search data plane specs, these are incomplete. See this issue
for details: Azure#1085
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2018

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/search/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/search/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Member

@fearthecowboy fearthecowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comments in the PR, I'm allowing this thru into preview as it's just a copy of existing files in -PR repo

@fearthecowboy fearthecowboy merged commit 6fa97c2 into Azure:master Feb 6, 2018
@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

@brjohnstmsft brjohnstmsft deleted the search-2016-09-01-Preview branch February 6, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants