Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new stable version for PaloAltoNetworks #24005

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

rheajain
Copy link
Contributor

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    The new stable version of the APIs will be public in GA on 1st August
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    With GA, 1st August
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @rheajain Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    PaloAltoNetworks.Cloudngfw.json 2022-08-29(7f205c5) 2022-08-29-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2022-08-29 package-2022-08-29(7f205c5) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'LocalRules' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L3865
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L777
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L783
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L790
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L830
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L843
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L849
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L855
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L861
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L894
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L907
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L913
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L946
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L985
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L998
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1004
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1050
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1056
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1063
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1313
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1361
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1406
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1834
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1882
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L1927
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L2533
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L3501
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L3507
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L3514
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: PaloAltoNetworks.Cloudngfw/stable/2022-08-29/PaloAltoNetworks.Cloudngfw.json#L3554
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 81 Errors, 0 Warnings failed [Detail]

    Tag package-2022-08-29; Prod region: Deployed

    Test run on region: westeurope; Operation coverage: total: 88, untested: 0, failed: 81, passed: 7

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/write' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_CreateOrUpdate
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/read' over scope '/providers/PaloAltoNetworks.Cloudngfw' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/read' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/write' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_Update
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/getChangeLog/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_getChangeLog
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listAppIds/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listAppIds
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listCountries/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listCountries
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listAdvancedSecurityObjects/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listAdvancedSecurityObjects
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/commit/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_commit
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/revert/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_revert
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listFirewalls/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listFirewalls
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listSecurityServices/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listSecurityServices
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listPredefinedUrlCategories/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GlobalRulestack_listPredefinedUrlCategories
    CLIENT_ERROR statusCode: 400,
    errorCode: LinkedInvalidPropertyId,
    errorMessage: Property id 'key16' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'.
    Source: runtime
    OperationId: LocalRulestacks_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_Get
    CLIENT_ERROR statusCode: 400,
    errorCode: LinkedInvalidPropertyId,
    errorMessage: Property id 'key16' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'.
    Source: runtime
    OperationId: LocalRulestacks_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_commit
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listSecurityServices
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_revert
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listAppIds
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_getChangeLog
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listCountries
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listPredefinedUrlCategories
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listFirewalls
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_getSupportInfo
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: LocalRulestacks_listAdvancedSecurityObjects
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'PaloAltoNetworks.Cloudngfw/firewalls/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-CUaOtU-24005/providers/PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp'; however, it does not have permission to perform action 'Microsoft.Network/virtualNetworks/subnets/join/action' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/os-liftr-integration/providers/Microsoft.Network/virtualNetworks/os-liftr-integration-vnet/subnets/os-liftr-integration-trust-subnet' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: Firewalls_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Firewalls_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'PaloAltoNetworks.Cloudngfw/firewalls/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-CUaOtU-24005/providers/PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp'; however, it does not have permission to perform action 'Microsoft.Network/virtualNetworks/subnets/join/action' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/os-liftr-integration/providers/Microsoft.Network/virtualNetworks/os-liftr-integration-vnet/subnets/os-liftr-integration-trust-subnet' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: Firewalls_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Firewalls_getGlobalRulestack
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 53f6cce. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-paloaltonetworksngfw [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 53f6cce. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/paloaltonetworksngfw/armpanngfw [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 53f6cce. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-paloaltonetworksngfw [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group FirewallStatus
      info	[Changelog]   - Added Interface FirewallStatusGetOptionalParams
      info	[Changelog]   - Added Interface FirewallStatusListByFirewallsNextOptionalParams
      info	[Changelog]   - Added Interface FirewallStatusListByFirewallsOptionalParams
      info	[Changelog]   - Added Interface FirewallStatusResource
      info	[Changelog]   - Added Interface FirewallStatusResourceListResult
      info	[Changelog]   - Added Interface PanoramaStatus
      info	[Changelog]   - Added Type Alias FirewallStatusGetResponse
      info	[Changelog]   - Added Type Alias FirewallStatusListByFirewallsNextResponse
      info	[Changelog]   - Added Type Alias FirewallStatusListByFirewallsResponse
      info	[Changelog]   - Added Type Alias HealthStatus
      info	[Changelog]   - Added Type Alias ReadOnlyProvisioningState
      info	[Changelog]   - Added Type Alias ServerStatus
      info	[Changelog]   - Added Enum KnownHealthStatus
      info	[Changelog]   - Added Enum KnownReadOnlyProvisioningState
      info	[Changelog]   - Added Enum KnownServerStatus
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 53f6cce. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️paloaltonetworks [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/paloaltonetworksngfw/armpanngfw There is no API change compared with the previous version
    Java azure-resourcemanager-paloaltonetworks-ngfw There is no API change compared with the previous version
    JavaScript @azure/arm-paloaltonetworksngfw https://apiview.dev/Assemblies/Review/27902bb44dd14200b92eb1f38575b741

    @openapi-workflow-bot
    Copy link

    Hi, @rheajain, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @openapi-workflow-bot
    Copy link

    Hi @rheajain, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels May 17, 2023
    @raosuhas
    Copy link

    Hi, @rheajain, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Can you please fix this so that the previous version is present as the base commit ?

    @raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 17, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2023
    @v-jiaodi
    Copy link
    Member

    v-jiaodi commented Jun 1, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @rheajain rheajain removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2023
    @rheajain
    Copy link
    Contributor Author

    rheajain commented Jun 6, 2023

    These changes are already approved in the private repo and merged in RPSaaSMaster with this PR- https://github.com/Azure/azure-rest-api-specs-pr/pull/12630

    @ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2023
    @v-jiaodi v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 6, 2023
    @weidongxu-microsoft weidongxu-microsoft merged commit 53f6cce into main Jun 7, 2023
    @weidongxu-microsoft weidongxu-microsoft deleted the rhjai/PAN_stable branch June 7, 2023 00:03
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    * Add new stable version for PaloAltoNetworks
    
    * change version in readme
    
    * Add API version tag
    
    * Rectify Certificate and Firewalls example Ids
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants