-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new stable version for PaloAltoNetworks #24005
Conversation
Hi, @rheajain Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
PaloAltoNetworks.Cloudngfw.json | 2022-08-29(7f205c5) | 2022-08-29-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.2) | new version | base version |
---|---|---|
package-2022-08-29 | package-2022-08-29(7f205c5) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 81 Errors, 0 Warnings failed [Detail]
Tag package-2022-08-29; Prod region: Deployed
Test run on region: westeurope; Operation coverage: total: 88, untested: 0, failed: 81, passed: 7
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/write' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/read' over scope '/providers/PaloAltoNetworks.Cloudngfw' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_List |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/read' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/write' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_Update |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/getChangeLog/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_getChangeLog |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listAppIds/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listAppIds |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listCountries/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listCountries |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listAdvancedSecurityObjects/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listAdvancedSecurityObjects |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/commit/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_commit |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/revert/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_revert |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listFirewalls/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listFirewalls |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listSecurityServices/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listSecurityServices |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'PaloAltoNetworks.Cloudngfw/globalRulestacks/listPredefinedUrlCategories/action' over scope '/providers/PaloAltoNetworks.Cloudngfw/globalRulestacks/globalruqmupze' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: GlobalRulestack_listPredefinedUrlCategories |
CLIENT_ERROR |
statusCode: 400, errorCode: LinkedInvalidPropertyId, errorMessage: Property id 'key16' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'. Source: runtime OperationId: LocalRulestacks_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_Get |
CLIENT_ERROR |
statusCode: 400, errorCode: LinkedInvalidPropertyId, errorMessage: Property id 'key16' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'. Source: runtime OperationId: LocalRulestacks_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_commit |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listSecurityServices |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_revert |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listAppIds |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_getChangeLog |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listCountries |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listPredefinedUrlCategories |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listFirewalls |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_getSupportInfo |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/localRulestacks/localrul43luym' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: LocalRulestacks_listAdvancedSecurityObjects |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'PaloAltoNetworks.Cloudngfw/firewalls/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-CUaOtU-24005/providers/PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp'; however, it does not have permission to perform action 'Microsoft.Network/virtualNetworks/subnets/join/action' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/os-liftr-integration/providers/Microsoft.Network/virtualNetworks/os-liftr-integration-vnet/subnets/os-liftr-integration-trust-subnet' or the linked scope(s) are invalid. Source: runtime OperationId: Firewalls_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Firewalls_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'PaloAltoNetworks.Cloudngfw/firewalls/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-CUaOtU-24005/providers/PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp'; however, it does not have permission to perform action 'Microsoft.Network/virtualNetworks/subnets/join/action' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/os-liftr-integration/providers/Microsoft.Network/virtualNetworks/os-liftr-integration-vnet/subnets/os-liftr-integration-trust-subnet' or the linked scope(s) are invalid. Source: runtime OperationId: Firewalls_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'PaloAltoNetworks.Cloudngfw/firewalls/firewallyspcpp' under resource group 'apiTest-CUaOtU-24005' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Firewalls_getGlobalRulestack |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @rheajain, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
Hi @rheajain, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Can you please fix this so that the previous version is present as the base commit ? |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
These changes are already approved in the private repo and merged in RPSaaSMaster with this PR- https://github.com/Azure/azure-rest-api-specs-pr/pull/12630 |
* Add new stable version for PaloAltoNetworks * change version in readme * Add API version tag * Rectify Certificate and Firewalls example Ids
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
The new stable version of the APIs will be public in GA on 1st August
With GA, 1st August
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.