-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeSpec-Clean]: Updates for AnomalyDetector #23972
Conversation
markcowl
commented
May 12, 2023
•
edited by mikeharder
Loading
edited by mikeharder
- Passing CI pipeline: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2772571&view=logs&j=9cd39ef8-47c1-5b58-08db-8c3708712f1b&t=46aa8e9f-34a9-5191-842b-906b756357f0
Hi, @markcowl Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
@@ -14,10 +14,11 @@ emit: [ | |||
] | |||
options: | |||
"@azure-tools/typespec-autorest": | |||
azure-resource-provider-folder: "./data-plane" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl do you know why this property is needed explicitly? I tried to just hardcode it in the output-file path directly but when I did the output didn't go to the correct place because it seems as though service-name, version, version-status were all null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is essentially a toggle switch that is necessary for example inclusion to work correctly with versioning. We should make it unnecessary.