Updating the name for Storage Account Type for Edgzones #23741

kjilla · 2023-04-26T20:36:03Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…ations in Gallery.json

Updating the name for Storage Account Type for Edgzones

openapi-workflow-bot · 2023-04-26T20:36:06Z

Hi, @kjilla Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-04-26T20:36:08Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
gallery.json	2022-03-03(200d15d)	2022-03-03(main)

Rule	Message
`❌` 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'name' than the previous one. New: GalleryRP/stable/2022-03-03/gallery.json#L2560:9 Old: GalleryRP/stable/2022-03-03/gallery.json#L2560:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-03-01	package-2023-03-01(200d15d)	package-2023-03-01(main)
package-2022-11-01	package-2022-11-01(200d15d)	package-2022-11-01(main)
package-2022-09-04	package-2022-09-04(200d15d)	package-2022-09-04(main)
package-2022-03-03	package-2022-03-03(200d15d)	package-2022-03-03(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-03-03/gallery.json#L37
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` LongRunningResponseStatusCode	A 'put' operation 'Galleries_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: GalleryRP/stable/2022-03-03/gallery.json#L38
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-03-03/gallery.json#L84
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: GalleryRP/stable/2022-03-03/gallery.json#L136
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-03-03/gallery.json#L146
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-03-03/gallery.json#L146

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2023-03-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 61 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L16:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L29:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create.json#L42:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L19:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L35:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_WithSharingProfile.json#L51:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L19:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L35:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Create_SoftDeletionEnabled.json#L51:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L25:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L47:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Create.json#L69:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get.json#L10:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get_WithSelectPermissions.json#L11:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Get_WithExpandSharingProfileGroups.json#L11:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L1738:16 ExampleUrl: 2022-03-03/examples/galleryExamples/CommunityGallery_Get.json#L10:15
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: GalleryRP/stable/2022-03-03/gallery.json#L261:22 ExampleUrl: 2022-03-03/examples/galleryExamples/Gallery_Delete.json
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L24:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L41:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Create.json#L58:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2260:21 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Get.json#L11:15
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: GalleryRP/stable/2022-03-03/gallery.json#L503:22 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImage_Delete.json
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L70:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L154:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create.json#L238:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L74:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L153:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithSnapshotsAsSource.json#L232:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithVmAsSource.json#L70:15
`❌` MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: GalleryRP/stable/2022-03-03/gallery.json#L2384:28 ExampleUrl: 2022-03-03/examples/galleryExamples/GalleryImageVersion_Create_WithVmAsSource.json#L154:15

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-26T20:36:09Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/compute/armcompute - Approved - 5.0.0

+	Field `ID` of struct `VirtualMachineScaleSetIPConfiguration` has been removed
+	Field `ID` of struct `VirtualMachineScaleSetNetworkConfiguration` has been removed
+	Field `ID` of struct `VirtualMachineScaleSetUpdateIPConfiguration` has been removed
+	Field `ID` of struct `VirtualMachineScaleSetUpdateNetworkConfiguration` has been removed
+	Type of `GalleryTargetExtendedLocation.StorageAccountType` has been changed from `*StorageAccountType` to `*EdgeZoneStorageAccountType`
+	Type of `RestorePointSourceVMDataDisk.DiskRestorePoint` has been changed from `*APIEntityReference` to `*DiskRestorePointAttributes`
+	Type of `RestorePointSourceVMOSDisk.DiskRestorePoint` has been changed from `*APIEntityReference` to `*DiskRestorePointAttributes`
+	`StorageAccountTypeStandardSSDLRS` from enum `StorageAccountType` has been removed

❌azure-sdk-for-js - @azure/arm-compute - Approved - 21.0.0

+	Type of parameter diskRestorePoint of interface RestorePointSourceVMDataDisk is changed from ApiEntityReference to DiskRestorePointAttributes
+	Type of parameter diskRestorePoint of interface RestorePointSourceVmosDisk is changed from ApiEntityReference to DiskRestorePointAttributes
+	Type of parameter storageAccountType of interface GalleryTargetExtendedLocation is changed from StorageAccountType to EdgeZoneStorageAccountType

❌azure-sdk-for-python-track2 - track2_azure-mgmt-compute - Approved - 29.1.0

+	Model VirtualMachineScaleSetIPConfiguration no longer has parameter id
+	Model VirtualMachineScaleSetNetworkConfiguration no longer has parameter id
+	Model VirtualMachineScaleSetUpdateIPConfiguration no longer has parameter id
+	Model VirtualMachineScaleSetUpdateNetworkConfiguration no longer has parameter id

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Compute [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.Compute.1.2.0-alpha.20230517.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-compute [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation DedicatedHostsOperations.list_available_sizes
info	[Changelog]   - Added operation VirtualMachineScaleSetsOperations.begin_reapply
info	[Changelog]   - Model DedicatedHostUpdate has a new parameter sku
info	[Changelog]   - Model LinuxVMGuestPatchAutomaticByPlatformSettings has a new parameter bypass_platform_safety_checks_on_user_schedule
info	[Changelog]   - Model RestorePointSourceMetadata has a new parameter hyper_v_generation
info	[Changelog]   - Model RestorePointSourceVMDataDisk has a new parameter write_accelerator_enabled
info	[Changelog]   - Model RestorePointSourceVMOSDisk has a new parameter write_accelerator_enabled
info	[Changelog]   - Model VirtualMachineExtension has a new parameter provision_after_extensions
info	[Changelog]   - Model VirtualMachineRunCommand has a new parameter error_blob_managed_identity
info	[Changelog]   - Model VirtualMachineRunCommand has a new parameter output_blob_managed_identity
info	[Changelog]   - Model VirtualMachineRunCommand has a new parameter treat_failure_as_deployment_failure
info	[Changelog]   - Model VirtualMachineRunCommandScriptSource has a new parameter script_uri_managed_identity
info	[Changelog]   - Model VirtualMachineRunCommandUpdate has a new parameter error_blob_managed_identity
info	[Changelog]   - Model VirtualMachineRunCommandUpdate has a new parameter output_blob_managed_identity
info	[Changelog]   - Model VirtualMachineRunCommandUpdate has a new parameter treat_failure_as_deployment_failure
info	[Changelog]   - Model VirtualMachineScaleSetUpdate has a new parameter priority_mix_policy
info	[Changelog]   - Model VirtualMachineScaleSetUpdate has a new parameter spot_restore_policy
info	[Changelog]   - Model VirtualMachineScaleSetVMExtension has a new parameter location
info	[Changelog]   - Model VirtualMachineScaleSetVMExtension has a new parameter provision_after_extensions
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter computer_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter hyper_v_generation
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_version
info	[Changelog]   - Model VirtualMachineScaleSetVMProfile has a new parameter security_posture_reference
info	[Changelog]   - Model WindowsVMGuestPatchAutomaticByPlatformSettings has a new parameter bypass_platform_safety_checks_on_user_schedule
info	[Changelog]   - Operation VirtualMachineScaleSetsOperations.begin_deallocate has a new optional parameter hibernate
info	[Changelog]   - Operation VirtualMachinesOperations.list has a new optional parameter expand
info	[Changelog]   - Operation VirtualMachinesOperations.list_all has a new optional parameter expand
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model VirtualMachineScaleSetIPConfiguration no longer has parameter id
info	[Changelog]   - Model VirtualMachineScaleSetNetworkConfiguration no longer has parameter id
info	[Changelog]   - Model VirtualMachineScaleSetUpdateIPConfiguration no longer has parameter id
info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkConfiguration no longer has parameter id

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-compute-21.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation DedicatedHosts.listAvailableSizes
info	[Changelog]   - Added operation VirtualMachineScaleSets.beginReapply
info	[Changelog]   - Added operation VirtualMachineScaleSets.beginReapplyAndWait
info	[Changelog]   - Added Interface DedicatedHostSizeListResult
info	[Changelog]   - Added Interface DedicatedHostsListAvailableSizesOptionalParams
info	[Changelog]   - Added Interface DiskRestorePointAttributes
info	[Changelog]   - Added Interface RestorePointEncryption
info	[Changelog]   - Added Interface RunCommandManagedIdentity
info	[Changelog]   - Added Interface SecurityPostureReference
info	[Changelog]   - Added Interface VirtualMachineScaleSetsReapplyHeaders
info	[Changelog]   - Added Interface VirtualMachineScaleSetsReapplyOptionalParams
info	[Changelog]   - Added Type Alias DedicatedHostsListAvailableSizesResponse
info	[Changelog]   - Added Type Alias EdgeZoneStorageAccountType
info	[Changelog]   - Added Type Alias ExpandTypeForListVMs
info	[Changelog]   - Added Type Alias ExpandTypesForListVMs
info	[Changelog]   - Added Type Alias RestorePointEncryptionType
info	[Changelog]   - Interface DedicatedHostUpdate has a new optional parameter sku
info	[Changelog]   - Interface LinuxVMGuestPatchAutomaticByPlatformSettings has a new optional parameter bypassPlatformSafetyChecksOnUserSchedule
info	[Changelog]   - Interface RestorePointSourceMetadata has a new optional parameter hyperVGeneration
info	[Changelog]   - Interface RestorePointSourceVMDataDisk has a new optional parameter writeAcceleratorEnabled
info	[Changelog]   - Interface RestorePointSourceVmosDisk has a new optional parameter writeAcceleratorEnabled
info	[Changelog]   - Interface VirtualMachineExtension has a new optional parameter provisionAfterExtensions
info	[Changelog]   - Interface VirtualMachineRunCommand has a new optional parameter errorBlobManagedIdentity
info	[Changelog]   - Interface VirtualMachineRunCommand has a new optional parameter outputBlobManagedIdentity
info	[Changelog]   - Interface VirtualMachineRunCommand has a new optional parameter treatFailureAsDeploymentFailure
info	[Changelog]   - Interface VirtualMachineRunCommandScriptSource has a new optional parameter scriptUriManagedIdentity
info	[Changelog]   - Interface VirtualMachineRunCommandUpdate has a new optional parameter errorBlobManagedIdentity
info	[Changelog]   - Interface VirtualMachineRunCommandUpdate has a new optional parameter outputBlobManagedIdentity
info	[Changelog]   - Interface VirtualMachineRunCommandUpdate has a new optional parameter treatFailureAsDeploymentFailure
info	[Changelog]   - Interface VirtualMachineScaleSetsDeallocateOptionalParams has a new optional parameter hibernate
info	[Changelog]   - Interface VirtualMachineScaleSetUpdate has a new optional parameter priorityMixPolicy
info	[Changelog]   - Interface VirtualMachineScaleSetUpdate has a new optional parameter spotRestorePolicy
info	[Changelog]   - Interface VirtualMachineScaleSetVMExtension has a new optional parameter location
info	[Changelog]   - Interface VirtualMachineScaleSetVMExtension has a new optional parameter provisionAfterExtensions
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter computerName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter hyperVGeneration
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osVersion
info	[Changelog]   - Interface VirtualMachineScaleSetVMProfile has a new optional parameter securityPostureReference
info	[Changelog]   - Interface VirtualMachinesListAllOptionalParams has a new optional parameter expand
info	[Changelog]   - Interface VirtualMachinesListOptionalParams has a new optional parameter expand
info	[Changelog]   - Interface WindowsVMGuestPatchAutomaticByPlatformSettings has a new optional parameter bypassPlatformSafetyChecksOnUserSchedule
info	[Changelog]   - Added Enum KnownEdgeZoneStorageAccountType
info	[Changelog]   - Added Enum KnownExpandTypeForListVMs
info	[Changelog]   - Added Enum KnownExpandTypesForListVMs
info	[Changelog]   - Added Enum KnownRestorePointEncryptionType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter storageAccountType of interface GalleryTargetExtendedLocation is changed from StorageAccountType to EdgeZoneStorageAccountType
info	[Changelog]   - Type of parameter diskRestorePoint of interface RestorePointSourceVMDataDisk is changed from ApiEntityReference to DiskRestorePointAttributes
info	[Changelog]   - Type of parameter diskRestorePoint of interface RestorePointSourceVmosDisk is changed from ApiEntityReference to DiskRestorePointAttributes

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `GalleryTargetExtendedLocation.StorageAccountType` has been changed from `*StorageAccountType` to `*EdgeZoneStorageAccountType`
info	[Changelog] - Type of `RestorePointSourceVMDataDisk.DiskRestorePoint` has been changed from `*APIEntityReference` to `*DiskRestorePointAttributes`
info	[Changelog] - Type of `RestorePointSourceVMOSDisk.DiskRestorePoint` has been changed from `*APIEntityReference` to `*DiskRestorePointAttributes`
info	[Changelog] - `StorageAccountTypeStandardSSDLRS` from enum `StorageAccountType` has been removed
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetIPConfiguration` has been removed
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetNetworkConfiguration` has been removed
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetUpdateIPConfiguration` has been removed
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetUpdateNetworkConfiguration` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `EdgeZoneStorageAccountType` with values `EdgeZoneStorageAccountTypePremiumLRS`, `EdgeZoneStorageAccountTypeStandardLRS`, `EdgeZoneStorageAccountTypeStandardSSDLRS`, `EdgeZoneStorageAccountTypeStandardZRS`
info	[Changelog] - New enum type `ExpandTypeForListVMs` with values `ExpandTypeForListVMsInstanceView`
info	[Changelog] - New enum type `ExpandTypesForListVMs` with values `ExpandTypesForListVMsInstanceView`
info	[Changelog] - New enum type `RestorePointEncryptionType` with values `RestorePointEncryptionTypeEncryptionAtRestWithCustomerKey`, `RestorePointEncryptionTypeEncryptionAtRestWithPlatformAndCustomerKeys`, `RestorePointEncryptionTypeEncryptionAtRestWithPlatformKey`
info	[Changelog] - New function `*DedicatedHostsClient.NewListAvailableSizesPager(string, string, string, *DedicatedHostsClientListAvailableSizesOptions) *runtime.Pager[DedicatedHostsClientListAvailableSizesResponse]`
info	[Changelog] - New function `*VirtualMachineScaleSetsClient.BeginReapply(context.Context, string, string, *VirtualMachineScaleSetsClientBeginReapplyOptions) (*runtime.Poller[VirtualMachineScaleSetsClientReapplyResponse], error)`
info	[Changelog] - New struct `DedicatedHostSizeListResult`
info	[Changelog] - New struct `DiskRestorePointAttributes`
info	[Changelog] - New struct `RestorePointEncryption`
info	[Changelog] - New struct `RunCommandManagedIdentity`
info	[Changelog] - New struct `SecurityPostureReference`
info	[Changelog] - New field `SKU` in struct `DedicatedHostUpdate`
info	[Changelog] - New field `BypassPlatformSafetyChecksOnUserSchedule` in struct `LinuxVMGuestPatchAutomaticByPlatformSettings`
info	[Changelog] - New field `HyperVGeneration` in struct `RestorePointSourceMetadata`
info	[Changelog] - New field `WriteAcceleratorEnabled` in struct `RestorePointSourceVMDataDisk`
info	[Changelog] - New field `WriteAcceleratorEnabled` in struct `RestorePointSourceVMOSDisk`
info	[Changelog] - New field `ProvisionAfterExtensions` in struct `VirtualMachineExtensionProperties`
info	[Changelog] - New field `ErrorBlobManagedIdentity`, `OutputBlobManagedIdentity`, `TreatFailureAsDeploymentFailure` in struct `VirtualMachineRunCommandProperties`
info	[Changelog] - New field `ScriptURIManagedIdentity` in struct `VirtualMachineRunCommandScriptSource`
info	[Changelog] - New field `PriorityMixPolicy`, `SpotRestorePolicy` in struct `VirtualMachineScaleSetUpdateProperties`
info	[Changelog] - New field `Location` in struct `VirtualMachineScaleSetVMExtension`
info	[Changelog] - New field `SecurityPostureReference` in struct `VirtualMachineScaleSetVMProfile`
info	[Changelog] - New field `Hibernate` in struct `VirtualMachineScaleSetsClientBeginDeallocateOptions`
info	[Changelog] - New field `Expand` in struct `VirtualMachinesClientListAllOptions`
info	[Changelog] - New field `Expand` in struct `VirtualMachinesClientListOptions`
info	[Changelog] - New field `BypassPlatformSafetyChecksOnUserSchedule` in struct `WindowsVMGuestPatchAutomaticByPlatformSettings`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 40 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 89af33c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 89af33c. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.compute.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.compute.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-26T20:36:09Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/ece092dace414fe3ba4921b0fa8acfc5
Java	azure-resourcemanager-compute-generated	Create ApiView failed. Please ask PR assignee for help
.Net	Azure.ResourceManager.Compute	https://apiview.dev/Assemblies/Review/c2a9575dfbd043efa401af7addaac661
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/906a35d362a440948df96568a3e38d2f

kjilla · 2023-04-26T20:37:00Z

Fixing the build issue raised here.
#23588

openapi-workflow-bot · 2023-04-26T20:48:04Z

Hi @kjilla, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2023-04-26T20:48:04Z

Hi @kjilla, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

kjilla · 2023-04-27T17:52:06Z

@ArcturusZhang

Justification for breaking change:
generating track 1 .net sdk from main was getting this error:
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountType' and different values: StandardLRS,Standard_ZRS,Premium_LRS vs. Standard_LRS,Standard_ZRS,StandardSSD_LRS,PremiumLRS

Because GalleryTargetExtendedLocation.StorageAccountType was added "StandardSSD_LRS" from #22255 while TargetRegion.StorageAccountType and GalleryArtifactPublishingProfileBase.StorageAccountType did not.

So I am renaming the enum here. Added breaking change intake form here.

The original change to add a new enum was approved by breaking change board earlier. Here the first PR.

kjilla · 2023-04-27T17:58:59Z

Hi, I followed the guidance and updated the PR with the comment. #23741 (comment) I raised a breaking change intake form. The original PR<#22255> was approved by the review board. Thanks, Kusuma From: Dapeng Zhang ***@***.***> Sent: Thursday, April 27, 2023 02:25 AM To: Azure/azure-rest-api-specs ***@***.***> Cc: Kusuma Jilla ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-rest-api-specs] Updating the name for Storage Account Type for Edgzones (PR #23741) Hi @kjilla<https://github.com/kjilla> please follow the guidance here<#23741 (comment)> to get approval from the breaking change review board because your change just introduces a breaking change. - Reply to this email directly, view it on GitHub<#23741 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHVQH5ZQ75ZESMU47SPGEY3XDI3QFANCNFSM6AAAAAAXM6GRMQ>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

ArcturusZhang · 2023-04-28T03:55:20Z

@ArcturusZhang

Justification for breaking change: generating track 1 .net sdk from main was getting this error: FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountType' and different values: StandardLRS,Standard_ZRS,Premium_LRS vs. Standard_LRS,Standard_ZRS,StandardSSD_LRS,PremiumLRS

Because GalleryTargetExtendedLocation.StorageAccountType was added "StandardSSD_LRS" from #22255 while TargetRegion.StorageAccountType and GalleryArtifactPublishingProfileBase.StorageAccountType did not.

So I am renaming the enum here. Added breaking change intake form here.

The original change to add a new enum was approved by breaking change board earlier. Here the first PR.

This justification is not quite justified - the track 1 SDK generation issue has been resolved in this way:

azure-rest-api-specs/specification/compute/resource-manager/readme.csharp.md

Line 39 in 38311a1

transform: return "EdgeZoneStorageAccountType"

grizzlytheodore · 2023-04-28T19:20:35Z

@ArcturusZhang , since it is enum model-as-string: true, isn't the breaking change non-impacting? they can still provide StorageAccountType.Standard_SSD or EdgeZoneStorageAccountType.Standard_SSD ?

I see the only other resolution would be adding directives to all other languages as we did for readme.csharp.md

grizzlytheodore · 2023-05-08T17:04:27Z

please merge @ArcturusZhang . the model validations for galleryRP are all getting addressed in 2022-08-03 release that is in progress

tombuildsstuff · 2023-05-11T16:39:54Z

I'll add a more detailed comment in #23588 to confirm, but from our side, I can confirm this fixes the issue outlined in #23588 👍

JackTn · 2023-05-12T02:53:36Z

please merge @ArcturusZhang . the model validations for galleryRP are all getting addressed in 2022-08-03 release that is in progress

@ArcturusZhang can you take a look on this pr and merge it ！ Thanks

tombuildsstuff · 2023-05-15T11:08:14Z

@ArcturusZhang - is it possible for this one to get merged? It's blocking two projects on our side. Thanks!

ArcturusZhang · 2023-05-16T08:35:41Z

@ArcturusZhang - is it possible for this one to get merged? It's blocking two projects on our side. Thanks!

Hey I am sorry but we still have some discussion on our side because this change introduces breaking changes to all of our SDKs.
We are consolidating those changes, and this is planned to merge by the end of this week

kjilla added 2 commits April 24, 2023 11:11

Updating the name of the Storage Account Type for Target Extended Loc…

9361d82

…ations in Gallery.json

Merge pull request #1 from kjilla/kjilla-renamestorageaccounttype

200d15d

Updating the name for Storage Account Type for Edgzones

kjilla requested review from Sandido, dkulkarni-ms, haagha, madewithsmiles, MS-syh2qs, grizzlytheodore and hyonholee as code owners April 26, 2023 20:36

openapi-assignment-bot bot assigned ArcturusZhang Apr 26, 2023

ghost added the Compute label Apr 26, 2023

azure-sdk mentioned this pull request Apr 26, 2023

[AutoPR sdk/resourcemanager/compute/armcompute] Updating the name for Storage Account Type for Edgzones azure-sdk/azure-sdk-for-go#5528

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 26, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Apr 26, 2023

azure-sdk mentioned this pull request Apr 26, 2023

[AutoPR @azure/arm-compute] Updating the name for Storage Account Type for Edgzones azure-sdk/azure-sdk-for-js#4932

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 26, 2023

raych1 assigned JackTn Apr 27, 2023

raych1 requested a review from JackTn April 27, 2023 01:21

azure-sdk mentioned this pull request Apr 27, 2023

[AutoPR track2_azure-mgmt-compute] Updating the name for Storage Account Type for Edgzones azure-sdk/azure-sdk-for-python#3417

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 27, 2023

ArcturusZhang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 28, 2023

grizzlytheodore mentioned this pull request May 5, 2023

2022-03-03 Compute/GalleryRP StorageAccountType Swagger failing #23588

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 5, 2023

msyyc added the Approved-SdkBreakingChange-Python label May 16, 2023

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 16, 2023

qiaozha added the Approved-SdkBreakingChange-JavaScript label May 16, 2023

ArcturusZhang approved these changes May 16, 2023

View reviewed changes

ArcturusZhang added Approved-ModelValidation and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels May 17, 2023

ArcturusZhang merged commit 89af33c into Azure:main May 17, 2023

tadelesh mentioned this pull request May 17, 2023

[Release] sdk/resourcemanager/compute/armcompute/5.0.0 Azure/azure-sdk-for-go#20784

Merged

This was referenced Jul 26, 2023

mgmt compute, update api-version to 2023-01-02 Azure/azure-sdk-for-java#36107

Merged

java compute mgmt, add directive to rename EdgeZoneStorageAccountType back to StorageAccountType #24988

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating the name for Storage Account Type for Edgzones #23741

Updating the name for Storage Account Type for Edgzones #23741

kjilla commented Apr 26, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 26, 2023

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

kjilla commented Apr 26, 2023

openapi-workflow-bot bot commented Apr 26, 2023

openapi-workflow-bot bot commented Apr 26, 2023

kjilla commented Apr 27, 2023 •

edited

Loading

kjilla commented Apr 27, 2023 via email

ArcturusZhang commented Apr 28, 2023

grizzlytheodore commented Apr 28, 2023

grizzlytheodore commented May 8, 2023

tombuildsstuff commented May 11, 2023

JackTn commented May 12, 2023

tombuildsstuff commented May 15, 2023

ArcturusZhang commented May 16, 2023

Updating the name for Storage Account Type for Edgzones #23741

Updating the name for Storage Account Type for Edgzones #23741

Conversation

kjilla commented Apr 26, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 26, 2023

openapi-pipeline-app bot commented Apr 26, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 26, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 26, 2023 • edited Loading

Generated ApiView

kjilla commented Apr 26, 2023

openapi-workflow-bot bot commented Apr 26, 2023

openapi-workflow-bot bot commented Apr 26, 2023

kjilla commented Apr 27, 2023 • edited Loading

kjilla commented Apr 27, 2023 via email

ArcturusZhang commented Apr 28, 2023

grizzlytheodore commented Apr 28, 2023

grizzlytheodore commented May 8, 2023

tombuildsstuff commented May 11, 2023

JackTn commented May 12, 2023

tombuildsstuff commented May 15, 2023

ArcturusZhang commented May 16, 2023

kjilla commented Apr 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2023 •

edited

Loading

kjilla commented Apr 27, 2023 •

edited

Loading