-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AnomalyDetector] Fix for SDK clients due to associative arrays #23664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @catalinaperalta Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L9 |
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L10 |
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
unknown-identifier |
Unknown identifier route Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
unknown-identifier |
Unknown identifier get Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
import-not-found |
Couldn't resolve import "@azure-tools/typespec-client-generator-core" Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L4 |
invalid-ref |
Namespace Azure doesn't have member ClientGenerator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L12 |
unknown-identifier |
Unknown identifier convenientAPI Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L19 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L19 |
unknown-identifier |
Unknown identifier convenientAPI Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L26 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L26 |
SwaggerNotExistInPR |
"details":"The generated swagger file specification/cognitiveservices/AnomalyDetector/openapi.json from typespec specification/cognitiveservices/AnomalyDetector is not in the PR, please make sure it presents into the PR." |
MissingExamplesDirectory |
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Authoring, please ensure the 'examples' is added in the PR." |
MissingExamplesDirectory |
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference, please ensure the 'examples' is added in the PR." |
"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/AnomalyDetector, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
"details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
"details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
Cognitive Services
label
Apr 20, 2023
This was referenced Apr 20, 2023
catalinaperalta
changed the title
[AnomalyDetector] Associative arrays solution for SDK clients
[AnomalyDetector] Associative arrays fix for SDK clients
Apr 20, 2023
catalinaperalta
changed the title
[AnomalyDetector] Associative arrays fix for SDK clients
[AnomalyDetector] Fix for SDK clients due to associative arrays
Apr 20, 2023
srnagar
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added options for ts emitter java emitter.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 24, 2023
I have added myself as a reviewer so that I can recommend changes based on the Python and (ongoing) .NET user studies. |
minkefusiji
approved these changes
Apr 25, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off @convenientAPI generation for
DetectUnivariateEntireSeries
.Also, cleaned up client.tsp, using @convenientAPI with a
true
value is redundant since the convenience methods are now generated by default.NOTE: The change to
DetectUnivariateEntireSeries
affects .NET and Java, this method should be handwritten