Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosDB Mongo RBAC fix MongoRoleDefinitionType #23190

Merged
merged 5 commits into from
May 4, 2023
Merged

CosmosDB Mongo RBAC fix MongoRoleDefinitionType #23190

merged 5 commits into from
May 4, 2023

Conversation

ashwinisingh01
Copy link
Contributor

@ashwinisingh01 ashwinisingh01 commented Mar 21, 2023 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ashwinisingh01 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 20 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    mongorbac.json 2022-08-15-preview(f810268) 2022-08-15-preview(main)
    mongorbac.json 2022-11-15-preview(f810268) 2022-11-15-preview(main)
    mongorbac.json 2023-03-01-preview(f810268) 2023-03-01-preview(main)
    mongorbac.json 2022-08-15(f810268) 2022-08-15(main)
    mongorbac.json 2022-11-15(f810268) 2022-11-15(main)
    Rule Message
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'BuiltInRole, CustomRole' from the old version.
    New: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'BuiltInRole, CustomRole' from the old version.
    New: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'BuiltInRole, CustomRole' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'BuiltInRole, CustomRole' from the old version.
    New: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'BuiltInRole, CustomRole' from the old version.
    New: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    ❌ 1020 - AddedEnumValue The new version is adding enum value(s) '0, 1' from the old version.
    New: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    ❌ 1020 - AddedEnumValue The new version is adding enum value(s) '0, 1' from the old version.
    New: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    ❌ 1020 - AddedEnumValue The new version is adding enum value(s) '0, 1' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    ❌ 1020 - AddedEnumValue The new version is adding enum value(s) '0, 1' from the old version.
    New: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    ❌ 1020 - AddedEnumValue The new version is adding enum value(s) '0, 1' from the old version.
    New: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    ❌ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L408:9
    ❌ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L408:9
    ❌ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/mongorbac.json#L408:9
    ❌ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L408:9
    ❌ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    Old: Microsoft.DocumentDB/stable/2022-11-15/mongorbac.json#L408:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-11 package-2022-11(f810268) package-2022-11(main)
    package-2022-08 package-2022-08(f810268) package-2022-08(main)
    package-preview-2022-11 package-preview-2022-11(f810268) package-preview-2022-11(main)
    package-preview-2022-08 package-preview-2022-08(f810268) package-preview-2022-08(main)
    package-preview-2023-03 package-preview-2023-03(f810268) package-preview-2023-03(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L38
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L78
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L78
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L113
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L120
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L120
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L131
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L131
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L161
    ❌ ParametersOrder The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L219
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L259
    ❌ ParametersOrder The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L259
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L294
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L301
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L301
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L312
    ❌ ParametersOrder The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L312
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L342
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L437
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L444
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L555
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L38
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L78
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L78
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L113
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L120
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L120
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L131
    ❌ ParametersOrder The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L131
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DocumentDB/preview/2022-11-15-preview/mongorbac.json#L161
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 8 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L157:22
    ExampleUrl: preview/2022-08-15-preview/examples/CosmosDBMongoDBRoleDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L338:22
    ExampleUrl: preview/2022-08-15-preview/examples/CosmosDBMongoDBUserDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L157:22
    ExampleUrl: stable/2022-08-15/examples/CosmosDBMongoDBRoleDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L338:22
    ExampleUrl: stable/2022-08-15/examples/CosmosDBMongoDBUserDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L157:22
    ExampleUrl: preview/2022-08-15-preview/examples/CosmosDBMongoDBRoleDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/preview/2022-08-15-preview/mongorbac.json#L338:22
    ExampleUrl: preview/2022-08-15-preview/examples/CosmosDBMongoDBUserDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L157:22
    ExampleUrl: stable/2022-08-15/examples/CosmosDBMongoDBRoleDefinitionDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DocumentDB/stable/2022-08-15/mongorbac.json#L338:22
    ExampleUrl: stable/2022-08-15/examples/CosmosDBMongoDBUserDefinitionDelete.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 898ced2. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ContinuousModeBackupPolicy has a new parameter continuous_mode_properties
info	[Changelog]   - Model RestorableDatabaseAccountGetResult has a new parameter oldest_restorable_time
info	[Changelog]   - Model ThroughputSettingsGetPropertiesResource has a new parameter instant_maximum_throughput
info	[Changelog]   - Model ThroughputSettingsGetPropertiesResource has a new parameter soft_allowed_maximum_throughput
info	[Changelog]   - Model ThroughputSettingsResource has a new parameter instant_maximum_throughput
info	[Changelog]   - Model ThroughputSettingsResource has a new parameter soft_allowed_maximum_throughput
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from 898ced2. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.ResourceManager.CosmosDB [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.CosmosDB/Debug/netstandard2.0/Azure.ResourceManager.CosmosDB.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 898ced2. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/cosmos/armcosmos [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess`
info	[Changelog] - New enum type `ContinuousTier` with values `ContinuousTierContinuous30Days`, `ContinuousTierContinuous7Days`
info	[Changelog] - New struct `ContinuousModeProperties`
info	[Changelog] - New field `ContinuousModeProperties` in struct `ContinuousModeBackupPolicy`
info	[Changelog] - New field `OldestRestorableTime` in struct `RestorableDatabaseAccountProperties`
info	[Changelog] - New field `InstantMaximumThroughput`, `SoftAllowedMaximumThroughput` in struct `ThroughputSettingsGetPropertiesResource`
info	[Changelog] - New field `InstantMaximumThroughput`, `SoftAllowedMaximumThroughput` in struct `ThroughputSettingsResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 898ced2. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ContinuousModeProperties
info	[Changelog]   - Added Type Alias ContinuousTier
info	[Changelog]   - Interface ContinuousModeBackupPolicy has a new optional parameter continuousModeProperties
info	[Changelog]   - Interface RestorableDatabaseAccountGetResult has a new optional parameter oldestRestorableTime
info	[Changelog]   - Interface ThroughputSettingsResource has a new optional parameter instantMaximumThroughput
info	[Changelog]   - Interface ThroughputSettingsResource has a new optional parameter softAllowedMaximumThroughput
info	[Changelog]   - Added Enum KnownContinuousTier
info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 898ced2. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from 898ced2. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.cosmos-db.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.cosmos-db.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Cosmos label Mar 21, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/cosmos/armcosmos https://apiview.dev/Assemblies/Review/474f6b7761f6481d912145a72f48ff3e
    Java azure-resourcemanager-cosmos-generated https://apiview.dev/Assemblies/Review/5d7e25408fb74bf8bfc8e6f4be41bbec
    JavaScript @azure/arm-cosmosdb https://apiview.dev/Assemblies/Review/3e9e1f58d4e9497c994337754c8fe83c
    .Net Azure.ResourceManager.CosmosDB There is no API change compared with the previous version

    @azure-sdk azure-sdk mentioned this pull request Mar 21, 2023
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @ashwinisingh01, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Mar 21, 2023
    Draft
    Closed
    Closed
    Closed
    Closed
    Closed
    @ArcturusZhang ArcturusZhang added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Mar 22, 2023
    @openapi-workflow-bot
    Copy link

    Hi @ashwinisingh01, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    This was referenced Mar 27, 2023
    Closed
    Closed
    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ghost
    Copy link

    ghost commented Apr 30, 2023

    Hi, @ashwinisingh01. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Apr 30, 2023
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 1, 2023
    @ghost ghost removed the no-recent-activity label May 1, 2023
    @ArcturusZhang ArcturusZhang merged commit 898ced2 into Azure:main May 4, 2023
    This was referenced May 4, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @neil-yechenwei neil-yechenwei neil-yechenwei left review comments

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @pjohari-ms pjohari-ms Awaiting requested review from pjohari-ms pjohari-ms is a code owner

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-FixRequiredOnFailure Cosmos resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @ashwinisingh01 @ArcturusZhang @neil-yechenwei @JeffreyRichter @weidongxu-microsoft @AzureRestAPISpecReview