Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Properties in DataFlow Runtime IR #22907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anjaliOra
Copy link
Contributor

@anjaliOra anjaliOra commented Mar 4, 2023

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@openapi-workflow-bot
Copy link

Hi, @anjaliOra Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 4, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    integrationRuntime.json 2019-06-01-preview(6c2747c) 2019-06-01-preview(main)
    integrationRuntime.json 2021-06-01-preview(6c2747c) 2021-06-01-preview(main)
    Rule Message
    1045 - AddedOptionalProperty The new version has a new optional property 'customProperties' that was not found in the old version.
    New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L1401:7
    Old: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L1401:7
    1045 - AddedOptionalProperty The new version has a new optional property 'customProperties' that was not found in the old version.
    New: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1652:7
    Old: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1652:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2019-06-01-preview package-2019-06-01-preview(6c2747c) package-2019-06-01-preview(main)
    package-preview-2021-06 package-preview-2021-06(6c2747c) package-preview-2021-06(main)
    package-composite-v2 package-composite-v2(6c2747c) package-composite-v2(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1681


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L24
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L24
    ConsistentPatchProperties The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L54
    ConsistentPatchProperties The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L54
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L124
    ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L146
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L146
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L188
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L195
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L201
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L247
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L256
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L273
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L273
    ResourceNameRestriction The resource name parameter 'nodeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L273
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L333
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L333
    SyncPostReturn 200 response for a synchronous POST operation must have a response schema specified.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L334
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L383
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L383
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L445
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L445
    ResourceNameRestriction The resource name parameter 'nodeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L445
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L626
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L626
    SyncPostReturn 200 response for a synchronous POST operation must have a response schema specified.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L627
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L676
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L727
    ResourceNameRestriction The resource name parameter 'integrationRuntimeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L727
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L780
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 206 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L243:22
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimes_Delete.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: type
    Url: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2553:27
    ExampleUrl: preview/2019-06-01-preview/examples/IntegrationRuntimeObjectMetadata_List.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 4, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b7
    -	Removed operation SqlPoolsOperations.rename
    azure-sdk-for-js - @azure/arm-synapse - 9.0.0-beta.2
    -	Removed operation SqlPools.rename
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 881 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cannot force update branch 'sdkAuto/22907/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/22907/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
    • ️✔️Azure.ResourceManager.Synapse [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    • Azure.ResourceManager.Synapse [View full logsBreaking Change Detected
      error	Fatal error: cannot force update branch 'sdkAuto/22907/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		Azure.ResourceManager.Synapse
      error		Azure.ResourceManager.Synapse
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-synapse [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface EventHubDataConnection
      info	[Changelog]   - Added Interface ExtendedServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ExtendedSqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface GeoBackupPolicy
      info	[Changelog]   - Added Interface GetIntegrationRuntimeEnableInteractivequeryOptionalParams
      info	[Changelog]   - Added Interface GetIntegrationRuntimeStartOptionalParams
      info	[Changelog]   - Added Interface GetIntegrationRuntimeStopOptionalParams
      info	[Changelog]   - Added Interface IntegrationRuntimeDataFlowPropertiesCustomPropertiesItem
      info	[Changelog]   - Added Interface IntegrationRuntimeEnableinteractivequery
      info	[Changelog]   - Added Interface IntegrationRuntimeOperationStatus
      info	[Changelog]   - Added Interface IntegrationRuntimeResource
      info	[Changelog]   - Added Interface IntegrationRuntimeStopOperationStatus
      info	[Changelog]   - Added Interface IotHubDataConnection
      info	[Changelog]   - Added Interface IpFirewallRuleInfo
      info	[Changelog]   - Added Interface Key
      info	[Changelog]   - Added Interface KustoPool
      info	[Changelog]   - Added Interface KustoPoolPrivateLinkResources
      info	[Changelog]   - Added Interface KustoPoolPrivateLinkResourcesListOptionalParams
      info	[Changelog]   - Added Interface KustoPoolUpdate
      info	[Changelog]   - Added Interface LibraryResource
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeKeyAuthorization
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeRbacAuthorization
      info	[Changelog]   - Added Interface MaintenanceWindowOptions
      info	[Changelog]   - Added Interface MaintenanceWindows
      info	[Changelog]   - Added Interface ManagedIdentitySqlControlSettingsModel
      info	[Changelog]   - Added Interface ManagedIntegrationRuntime
      info	[Changelog]   - Added Interface ManagedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface MetadataSyncConfig
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateEndpointConnectionForPrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface PrivateLinkResources
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface ReadOnlyFollowingDatabase
      info	[Changelog]   - Added Interface ReadWriteDatabase
      info	[Changelog]   - Added Interface RecommendedSensitivityLabelUpdate
      info	[Changelog]   - Added Interface RecoverableSqlPool
      info	[Changelog]   - Added Interface ReplicationLink
      info	[Changelog]   - Added Interface RestorableDroppedSqlPool
      info	[Changelog]   - Added Interface RestorePoint
      info	[Changelog]   - Added Interface SecureString
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntime
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface SensitivityLabel
      info	[Changelog]   - Added Interface SensitivityLabelUpdate
      info	[Changelog]   - Added Interface ServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
      info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
      info	[Changelog]   - Added Interface SparkConfigurationResource
      info	[Changelog]   - Added Interface SqlPool
      info	[Changelog]   - Added Interface SqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface SqlPoolColumn
      info	[Changelog]   - Added Interface SqlPoolConnectionPolicy
      info	[Changelog]   - Added Interface SqlPoolOperation
      info	[Changelog]   - Added Interface SqlPoolSchema
      info	[Changelog]   - Added Interface SqlPoolSecurityAlertPolicy
      info	[Changelog]   - Added Interface SqlPoolTable
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessment
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentRuleBaseline
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentScansExport
      info	[Changelog]   - Added Interface SsisEnvironment
      info	[Changelog]   - Added Interface SsisFolder
      info	[Changelog]   - Added Interface SsisPackage
      info	[Changelog]   - Added Interface SsisProject
      info	[Changelog]   - Added Interface SubResource
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface TransparentDataEncryption
      info	[Changelog]   - Added Interface VulnerabilityAssessmentScanRecord
      info	[Changelog]   - Added Interface WorkloadClassifier
      info	[Changelog]   - Added Interface WorkloadGroup
      info	[Changelog]   - Added Interface Workspace
      info	[Changelog]   - Added Interface WorkspaceAadAdminInfo
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
      info	[Changelog]   - Added Type Alias ActualState
      info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Type Alias DesiredState
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeEnableInteractivequeryResponse
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStartResponse
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStopResponse
      info	[Changelog]   - Added Type Alias KustoPoolPrivateLinkResourcesListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
      info	[Changelog]   - Added Type Alias WorkspaceStatus
      info	[Changelog]   - Interface IntegrationRuntimeDataFlowProperties has a new optional parameter customProperties
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter dataFactoryName
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter state
      info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Enum KnownWorkspaceStatus
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group PrivateLinkResources
      info	[Changelog]   - Removed operation SqlPoolOperationResults.getLocationHeaderResult
      info	[Changelog]   - Removed operation SqlPools.update
      info	[Changelog]   - Class SynapseManagementClient has a new signature
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse no longer has parameter properties
      info	[Changelog]   - Interface SqlPoolSchemasListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListCurrentNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter includeDisabledRecommendations
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface SqlPoolTableColumnsListByTableNameNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolTablesListBySchemaNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new required parameter type
      info	[Changelog]   - Type of parameter actualState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState to ActualState
      info	[Changelog]   - Type of parameter desiredState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState to DesiredState
      info	[Changelog]   - Class SynapseManagementClient no longer has parameter privateLinkResources
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model IntegrationRuntimeDataFlowProperties has a new parameter custom_properties
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter os_type
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter target_framework
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/synapse/armsynapse [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - Type of `WorkspaceProperties.ExtraProperties` has been changed from `map[string]any` to `any`
      info	[Changelog] - New struct `IntegrationRuntimeDataFlowPropertiesCustomPropertiesItem`
      info	[Changelog] - New field `CustomProperties` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog] - New field `OSType`, `TargetFramework` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 4 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️synapse [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 761a75d8d65c8debc8f4204a2aa2f508aded48da. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.synapse.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.synapse.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 4, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Synapse Create ApiView failed. Please ask PR assignee for help
    Go sdk/resourcemanager/synapse/armsynapse Create ApiView failed. Please ask PR assignee for help
    Java azure-resourcemanager-synapse Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-synapse Create ApiView failed. Please ask PR assignee for help
    .Net Azure.ResourceManager.Synapse Create ApiView failed. Please ask PR assignee for help

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 4, 2023
    @ghost
    Copy link

    ghost commented Mar 4, 2023

    Thank you for your contribution anjaliOra! We will review the pull request and get back to you soon.

    @kazrael2119
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 22907 in repo Azure/azure-rest-api-specs

    @AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 10, 2023
    @openapi-workflow-bot
    Copy link

    Hi @anjaliOra! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @anjaliOra! The automation detected this pull request introduces changes to at least one existing API version that violate Azure's versioning policy. To comply with the policy, these changes must be made in a new API version. As a result, the automation added the NewApiVersionRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Introduce a new API version.
    Submit a new PR instead of this one, or modify this PR, so that it adds a new API version instead of introducing changes to existing API versions.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot avoid modifying existing API versions, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no changes in existing API version, i.e. there should be no NewApiVersionRequired label, then please explain why in a PR comment and @ the PR assignee.

    For additional guidance, please see https://aka.ms/NewApiVersionRequired

    @raosuhas
    Copy link

    Can you please fix the newly added swagger lint diff violations : https://github.com/Azure/azure-rest-api-specs/pull/22907/checks?check_run_id=14904983273

    @raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 10, 2023
    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 10, 2023
    @konrad-jamrozik konrad-jamrozik added the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Mar 11, 2024
    Copy link

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired). You must introduce a new API version with these changes instead of modifying an existing one. See the PR description for help.
    • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

    @konrad-jamrozik
    Copy link

    @anjaliOra I have removed the Approved-BreakingChange label because it is obsolete. Your PR will have to be re-approved. Please follow the instructions at https://aka.ms/brch. If you provide the reason why your PR was approved in the first place, this will speed up the process and help the Breaking Change Review Board apply appropriate new label. Apologies for the inconvenience!

    @konrad-jamrozik konrad-jamrozik removed the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 12, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager Synapses VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants