Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java configuration for Swagger to SDK bot #2290

Merged
merged 5 commits into from
Feb 1, 2018
Merged

Add Java configuration for Swagger to SDK bot #2290

merged 5 commits into from
Feb 1, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2018 •
edited by azuresdkci
Loading

The Azure REST API Specs portion of onboarding the Java SDK to be generated by the Swagger -> SDK bot.

@ghost ghost requested review from lmazuel and marstr January 18, 2018 20:27
@ghost ghost assigned ghost and unassigned anuchandy Jan 18, 2018
@ghost
Copy link
Author

ghost commented Jan 29, 2018

@lmazuel Merge conflicts resolved. Please take a look. Thanks!

@lmazuel
Copy link
Member

lmazuel commented Jan 31, 2018

@daschult Hum, conflicts are back :(
Should not prevent me to test it though, I do that asap!

@lmazuel
Copy link
Member

lmazuel commented Feb 1, 2018

@daschult LGTM, I merge it to avoid more conflicts, we can refine it later anyway. Thanks!!

@lmazuel lmazuel merged commit 9c66201 into master Feb 1, 2018
@lmazuel lmazuel deleted the daschult/AddJavaBatches branch February 1, 2018 18:15
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/advisor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/applicationinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 54
After the PR: Warning(s): 0 Error(s): 54

File: specification/azsadmin/resource-manager/InfrastructureInsights/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/azsadmin/resource-manager/commerce/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/azsadmin/resource-manager/fabric/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/batch/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/batch/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/batchai/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/billing/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cdn/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ComputerVision/readme.md
Before the PR: Warning(s): 0 Error(s): 14
After the PR: Warning(s): 0 Error(s): 14

File: specification/cognitiveservices/data-plane/ContentModerator/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/CustomSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/EntitySearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/data-plane/Face/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ImageSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Runtime/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/NewsSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/SpellCheck/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/TextAnalytics/readme.md
Before the PR: Warning(s): 0 Error(s): 3
After the PR: Warning(s): 0 Error(s): 3

File: specification/cognitiveservices/data-plane/VideoSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/WebSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/commerce/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 29
After the PR: Warning(s): 0 Error(s): 29

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 39
After the PR: Warning(s): 0 Error(s): 39

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/containerinstance/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/containerregistry/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/containerservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/cosmos-db/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/customer-insights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datacatalog/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-store/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datamigration/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/devtestlabs/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/dns/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 13
After the PR: Warning(s): 0 Error(s): 13

File: specification/domainservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/eventgrid/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/eventgrid/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 19
After the PR: Warning(s): 0 Error(s): 19

File: specification/hanaonazure/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/hdinsight/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 16
After the PR: Warning(s): 0 Error(s): 16

File: specification/intune/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 5

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 17

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

File: specification/keyvault/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/locationbasedservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/logic/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/machinelearning/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningcompute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningexperimentation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/marketplaceordering/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mediaservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mobileengagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 16
After the PR: Warning(s): 0 Error(s): 16

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/msi/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mysql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

File: specification/notificationhubs/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

File: specification/operationalinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/operationalinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/operationsmanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/postgresql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/powerbidedicated/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/powerbiembedded/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/provisioningservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/recoveryservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/recoveryservicessiterecovery/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 23
After the PR: Warning(s): 0 Error(s): 23

File: specification/redis/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/relay/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/reservations/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/resourcehealth/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

File: specification/scheduler/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 7
After the PR: Warning(s): 0 Error(s): 7

File: specification/search/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/search/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/servermanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/service-map/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/servicefabric/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 690
After the PR: Warning(s): 0 Error(s): 690

File: specification/servicefabric/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 44
After the PR: Warning(s): 0 Error(s): 44

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storage/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storageimportexport/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storsimple8000series/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/streamanalytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/subscription/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/timeseriesinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/trafficmanager/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/visualstudio/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 45
After the PR: Warning(s): 0 Error(s): 45

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI AutorestCI mentioned this pull request Feb 1, 2018
Closed
@AutorestCI
Copy link

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

@Azure Azure deleted a comment from azuresdkciprbot Feb 1, 2018
@jianghaolu
Copy link
Contributor

jianghaolu commented Feb 3, 2018 •
edited
Loading

I appreciate the changes being done here for Java to catch up with Python but this has broken the code generation for the Java SDK. If I'm understanding it correctly, an extra required parameter is added here for Java code generation: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storage/resource-manager/readme.md#java, while I think it will be nice to make azure-libraries-for-java-folder an optional parameter defaulted to the current folder.

As a matter of fact, I'm a little concerned about service teams that own their own data plane Java SDKs. Despite the vision we might want to bring them all together, which is another debate, most of them will want to specify output-folder explicitly instead of trying to guess which argument to provide for azure-libraries-for-java-folder. Hard-coding the output folder partially might be helpful for us in building 18, but introduces pain for anyone who wants to generate in a different folder.

Also, I'd recommend fluent argument to be removed too from the readme. The current default behavior for the Java generator is to not generate fluent code. Service teams are generating with that today. Some customers are actually generating non-fluent code from the latest Swagger specs like that today as well. Fluent is our special scenario actually, which we are already adding extra arguments for in our gulp files. If we leave fluent false by default, no one will be surprised :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@marstr marstr Awaiting requested review from marstr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmazuel @azuresdkciprbot @AutorestCI @jianghaolu @anuchandy