Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev migrate microsoft.off azure 2022 10 27 #22739

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tarsharm
Copy link
Contributor

@tarsharm tarsharm commented Feb 22, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tarsharm Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    migrate.json 2022-10-27(8b10982) 2020-07-07(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 198 Errors, 167 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-10 package-2022-10(8b10982) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 30 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44
    PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44
    RPC-Put-V1-12
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44
    RPC-Uri-V1-05
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L164
    RPC-Async-V1-01
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L166
    RPC-Async-V1-07
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L188
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L188
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256
    PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256
    RPC-Put-V1-12
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'hostName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256
    RPC-Uri-V1-05
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L376
    RPC-Async-V1-01
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L378
    RPC-Async-V1-07
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L400
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L400
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs/{jobName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'jobName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L534
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L534
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines/{machineName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'machineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L662
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L662
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/operationsStatus/{operationStatusName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752
    ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'operationStatusName' should be defined with a 'pattern' restriction.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752
    RPC-Uri-V1-05
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts/{accountName}'
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L818


    The following errors/warnings exist before current PR submission:

    Rule Message
    XmsParameterLocation The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L17
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5845
    XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5845
    XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5876
    MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L6424
    MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L6433
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5831
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5931
    ️❌Avocado: 29 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.Migrate/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/machines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/machines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/updateMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/downloadUrl is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/assessedMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/assessedMachines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/hypervcollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/hypervcollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/servercollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/servercollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/vmwarecollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/vmwarecollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/migrate/resource-manager/readme.md
    json: Microsoft.Migrate/stable/2019-10-01/migrate.json
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: MissingApiVersionParameter,
    message: The api-version query parameter (?api-version=) is required for all requests."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from afd9734a131bc38a7fe0e9f4cd45546b91831145. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Migrate [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️❌ azure-sdk-for-go failed [Detail]
    • Code Generator Failed [Logs] Generate from afd9734a131bc38a7fe0e9f4cd45546b91831145. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate�[0m
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/migrate/armmigrate, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] autorest --version=3.8.2 --use=@autorest/go@4.0.0-preview.45 --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.19.1]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] info    | AutoRest core version selected from configuration: 3.8.2.
      cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.6.3).
      cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.8.2/nodemodules/@autorest/core/dist' (3.8.2)
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.45 -> 4.0.0-preview.45)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.45->4.0.0-preview.45)
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.23.1 -> 4.23.1)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.23.1->4.23.1)
      cmderr	[generator automation-v2] [ERROR] error   | [Exception] No input files provided.
      cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
      cmderr	[generator automation-v2] [ERROR] error   |   Error: [Exception] No input files provided.
      cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
      cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from afd9734a131bc38a7fe0e9f4cd45546b91831145. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/22739/migrate' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/22739/migrate' as it is the current HEAD of the repository.
    • ️✔️migrate [View full logs]  [Preview Schema Changes]
    • ️✔️migrate [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/22739/migrate' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		migrate
      error		migrate
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from afd9734a131bc38a7fe0e9f4cd45546b91831145. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.migrate [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.OffAzure https://apiview.dev/Assemblies/Review/cbd2854b6f3c4a2f91091be4c36a57f4

    @openapi-workflow-bot
    Copy link

    Hi @tarsharm, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @tarsharm, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @tarsharm
    Copy link
    Contributor Author

    tarsharm commented Mar 1, 2023

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @TimLovellSmith TimLovellSmith added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 16, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 16, 2023
    @TimLovellSmith
    Copy link
    Member

    Please fill in the PR description + survey and then remove the ARMChangesRequested tag.

    @raych1 raych1 assigned rkmanda and unassigned raych1 Jun 27, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants