-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev migrate microsoft.off azure 2022 10 27 #22739
base: main
Are you sure you want to change the base?
Conversation
Hi, @tarsharm Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
migrate.json | 2022-10-27(8b10982) | 2020-07-07(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 198 Errors, 167 Warnings failed [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-10 | package-2022-10(8b10982) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44 |
|
PutGetPatchResponseSchema |
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44 |
RPC-Put-V1-12 |
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44 |
RPC-Uri-V1-05 |
ResourceNameRestriction |
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L44 |
RPC-Uri-V1-05 |
CreateOperationAsyncResponseValidation |
Only 201 is the supported response code for PUT async response. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L164 |
RPC-Async-V1-01 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L166 |
RPC-Async-V1-07 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L188 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L188 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256 |
|
PutGetPatchResponseSchema |
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256 |
RPC-Put-V1-12 |
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256 |
RPC-Uri-V1-05 |
ResourceNameRestriction |
The resource name parameter 'hostName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L256 |
RPC-Uri-V1-05 |
CreateOperationAsyncResponseValidation |
Only 201 is the supported response code for PUT async response. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L376 |
RPC-Async-V1-01 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L378 |
RPC-Async-V1-07 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L400 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L400 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs/{jobName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468 |
RPC-Uri-V1-05 |
ResourceNameRestriction |
The resource name parameter 'jobName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L468 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L534 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L534 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines/{machineName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596 |
RPC-Uri-V1-05 |
ResourceNameRestriction |
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L596 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L662 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L662 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/operationsStatus/{operationStatusName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752 |
|
ResourceNameRestriction |
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752 |
RPC-Uri-V1-05 |
ResourceNameRestriction |
The resource name parameter 'operationStatusName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L752 |
RPC-Uri-V1-05 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts/{accountName}' Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L818 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
XmsParameterLocation |
The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L17 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5845 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5845 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5876 |
MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L6424 |
MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L6433 |
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5831 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.OffAzure/stable/2022-10-27/migrate.json#L5931 |
️❌
Avocado: 29 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /providers/Microsoft.Migrate/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/machines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/machines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/updateMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/downloadUrl is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/assessedMachines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/assessedMachines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/hypervcollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/hypervcollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/servercollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/servercollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/vmwarecollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/vmwarecollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: Microsoft.Migrate/stable/2019-10-01/migrate.json |
️❌
ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
API Readiness check failed. Please make sure your service is deployed. |
"code: MissingApiVersionParameter, message: The api-version query parameter (?api-version=) is required for all requests." |
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @tarsharm, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @tarsharm, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
Please fill in the PR description + survey and then remove the ARMChangesRequested tag. |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.