Add go batches #2273

marstr · 2018-01-17T00:42:24Z

The Azure REST API Specs portion of onboarding the Go SDK to be generated by the Swagger -> SDK bot.

marstr · 2018-01-17T00:42:59Z

This is still in progress, and shouldn't be merged until I remove the DoNotMerge tag.

marstr · 2018-01-18T18:45:08Z

@lmazuel I believe this is all ready for your consideration now. Let me know, and we'll get this merged in. :)

lmazuel · 2018-01-18T20:47:23Z

specification/azsadmin/resource-manager/commerce/readme.md

+
+``` yaml $(swagger-to-sdk)
+swagger-to-sdk:
+  - repo: azure-sdk-for-python


I'm not generating this package

lmazuel · 2018-01-18T20:49:23Z

specification/compute/resource-manager/readme.md

+``` yaml $(go) && $(multiapi)
+batch:
+  - tag: package-compute-2017-03
+  - tag: package-container-service-2017-01


Current recommendation is to ship "containerservice" outside of compute. These files are even deprecated, the new can be found here:
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/containerservices/resource-manager

Ah, for the moment I am publishing the union of API Versions that are present in both locations. There seems to be no overlap, so at the moment we don't have to choose how to resolve any conflicts.

marstr · 2018-01-22T16:53:51Z

Anything else that needs to be changed before this is merged, @lmazuel? :)

azuresdkciprbot · 2018-01-25T03:31:03Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/advisor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/applicationinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 59
After the PR: Warning(s): 0 Error(s): 59

File: specification/azsadmin/resource-manager/InfrastructureInsights/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/azsadmin/resource-manager/commerce/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/azsadmin/resource-manager/fabric/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/batch/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/batch/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/batchai/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/billing/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cdn/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ComputerVision/readme.md
Before the PR: Warning(s): 0 Error(s): 14
After the PR: Warning(s): 0 Error(s): 14

File: specification/cognitiveservices/data-plane/ContentModerator/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/CustomSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/EntitySearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/data-plane/Face/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ImageSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Runtime/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/NewsSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/SpellCheck/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/TextAnalytics/readme.md
Before the PR: Warning(s): 0 Error(s): 3
After the PR: Warning(s): 0 Error(s): 3

File: specification/cognitiveservices/data-plane/VideoSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/WebSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/commerce/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 29
After the PR: Warning(s): 0 Error(s): 29

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 32
After the PR: Warning(s): 0 Error(s): 32

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/containerinstance/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/containerregistry/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/containerservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/cosmos-db/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 7
After the PR: Warning(s): 0 Error(s): 7

File: specification/customer-insights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datacatalog/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datalake-store/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datamigration/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/devtestlabs/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/dns/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 13
After the PR: Warning(s): 0 Error(s): 13

File: specification/domainservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/eventgrid/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/eventgrid/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/eventhub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 19
After the PR: Warning(s): 0 Error(s): 19

File: specification/hanaonazure/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/hdinsight/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 16
After the PR: Warning(s): 0 Error(s): 16

File: specification/intune/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 5

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 17

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

File: specification/keyvault/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/locationbasedservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/logic/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/machinelearning/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningcompute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningexperimentation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/marketplaceordering/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mediaservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mobileengagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 16
After the PR: Warning(s): 0 Error(s): 16

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/msi/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/mysql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

File: specification/notificationhubs/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

File: specification/operationalinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/operationalinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 27
After the PR: Warning(s): 0 Error(s): 27

File: specification/operationsmanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/postgresql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/powerbidedicated/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/powerbiembedded/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/provisioningservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/recoveryservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/recoveryservicessiterecovery/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 23
After the PR: Warning(s): 0 Error(s): 23

File: specification/redis/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/relay/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/reservations/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/resourcehealth/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

File: specification/scheduler/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 7
After the PR: Warning(s): 0 Error(s): 7

File: specification/search/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/servermanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/service-map/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/servicefabric/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 690
After the PR: Warning(s): 0 Error(s): 690

File: specification/servicefabric/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 44
After the PR: Warning(s): 0 Error(s): 44

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storage/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storageimportexport/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/storsimple8000series/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 13
After the PR: Warning(s): 0 Error(s): 13

File: specification/streamanalytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 5

File: specification/subscription/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/timeseriesinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/trafficmanager/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/visualstudio/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 45
After the PR: Warning(s): 0 Error(s): 45

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

lmazuel · 2018-01-25T17:33:14Z

Manual testing content is good, let's merge!!!!

AutorestCI · 2018-01-25T17:33:22Z

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

marstr added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 17, 2018

marstr self-assigned this Jan 17, 2018

marstr requested a review from lmazuel January 17, 2018 00:42

marstr removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 18, 2018

marstr force-pushed the addGoBatches branch from 4abfae8 to 76d3a58 Compare January 18, 2018 18:27

lmazuel reviewed Jan 18, 2018

View reviewed changes

marstr force-pushed the addGoBatches branch 2 times, most recently from 6d201db to e62c8bb Compare January 22, 2018 16:52

lmazuel approved these changes Jan 22, 2018

View reviewed changes

marstr force-pushed the addGoBatches branch from e62c8bb to 62fefbc Compare January 22, 2018 21:51

marstr added 6 commits January 23, 2018 08:38

First swath of changes.

8bf30fb

Second swath of work.

210aee6

Third swath of work.

a603cc0

Fourth swath of work.

439c384

Adding missing repo links for Swagger -> SDK bot.

e02fb1a

Addressing feedback.

99f6045

marstr force-pushed the addGoBatches branch from 62fefbc to 99f6045 Compare January 23, 2018 16:39

Azure deleted a comment from azuresdkciprbot Jan 23, 2018

marstr and others added 2 commits January 24, 2018 15:46

Fixing malformed go tags.

eca52b4

Fix go condition

9d9b0ef

lmazuel merged commit 635c479 into Azure:master Jan 25, 2018

Azure deleted a comment from azuresdkciprbot Jan 25, 2018

marstr deleted the addGoBatches branch January 30, 2018 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add go batches #2273

Add go batches #2273

marstr commented Jan 17, 2018

marstr commented Jan 17, 2018

marstr commented Jan 18, 2018

lmazuel Jan 18, 2018

marstr Jan 18, 2018

lmazuel Jan 18, 2018

marstr Jan 18, 2018

marstr commented Jan 22, 2018

azuresdkciprbot commented Jan 25, 2018

lmazuel commented Jan 25, 2018

AutorestCI commented Jan 25, 2018

Add go batches #2273

Add go batches #2273

Conversation

marstr commented Jan 17, 2018

marstr commented Jan 17, 2018

marstr commented Jan 18, 2018

lmazuel Jan 18, 2018

Choose a reason for hiding this comment

marstr Jan 18, 2018

Choose a reason for hiding this comment

lmazuel Jan 18, 2018

Choose a reason for hiding this comment

marstr Jan 18, 2018

Choose a reason for hiding this comment

marstr commented Jan 22, 2018

azuresdkciprbot commented Jan 25, 2018

lmazuel commented Jan 25, 2018

AutorestCI commented Jan 25, 2018