[Draft] Controllable and Interactive Summarization #21787
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @wangyuantao Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
ghost
added
the
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| analyzetext.json | 2023-05-01(8c1ba26) | 2023-05-01(main) |
| common.json | 2023-05-01(8c1ba26) | 2023-05-01(main) |
| Rule | Message |
|---|---|
|
The new version has a new optional property 'summaryLength' that was not found in the old version. |
|
The new version has a new optional property 'phraseControls' that was not found in the old version. |
|
The new version has a new optional property 'sessionId' that was not found in the old version. |
|
The new version has a new optional property 'phraseControlsRecommendationOption' that was not found in the old version. |
|
The new version has a new optional property 'enableInteractiveSummarizationSession' that was not found in the old version. |
|
The new version has a new optional property 'prefix' that was not found in the old version. |
|
The new version has a new optional property 'suffix' that was not found in the old version. |
️❌Breaking Change(Cross-Version): 18 Errors, 22 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| analyzetext.json | 2023-05-01(8c1ba26) | 2022-05-01(main) |
| analyzetext.json | 2023-05-01(8c1ba26) | 2022-10-01-preview(main) |
| common.json | 2023-05-01(8c1ba26) | 2022-05-01(main) |
| common.json | 2023-05-01(8c1ba26) | 2022-10-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version has new required property 'entities' that was not found in the old version. |
|
The new version has new required property 'relations' that was not found in the old version. |
|
The new version has new required property 'id' that was not found in the old version. |
|
The new version has new required property 'warnings' that was not found in the old version. |
|
The new version has new required property 'entities, relations, id, warnings' that was not found in the old version. New: cognitiveservices/data-plane/Language/analyzetext.json#L853:11 Old: Language/stable/2022-05-01/analyzetext.json#L779:11 |
|
The new version has new required property 'entities' that was not found in the old version. |
|
The new version has new required property 'id' that was not found in the old version. |
|
The new version has new required property 'warnings' that was not found in the old version. |
|
The new version has new required property 'entities, id, warnings' that was not found in the old version. New: cognitiveservices/data-plane/Language/analyzetext.json#L1524:11 Old: Language/stable/2022-05-01/analyzetext.json#L1430:11 |
|
The new version has new required property 'entities' that was not found in the old version. |
|
The new version has new required property 'id' that was not found in the old version. |
|
The new version has new required property 'warnings' that was not found in the old version. |
|
The new version has new required property 'entities, id, warnings' that was not found in the old version. New: cognitiveservices/data-plane/Language/analyzetext.json#L1677:11 Old: Language/stable/2022-05-01/analyzetext.json#L1559:11 |
|
The new version has new required property 'redactedText' that was not found in the old version. |
|
The new version has new required property 'entities' that was not found in the old version. |
|
The new version has new required property 'id' that was not found in the old version. |
|
The new version has new required property 'warnings' that was not found in the old version. |
|
The new version has new required property 'redactedText, entities, id, warnings' that was not found in the old version. New: cognitiveservices/data-plane/Language/analyzetext.json#L2512:11 Old: Language/stable/2022-05-01/analyzetext.json#L1728:11 |
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/analyzetext.json#L853:11 Old: Language/stable/2022-05-01/analyzetext.json#L779:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/analyzetext.json#L1524:11 Old: Language/stable/2022-05-01/analyzetext.json#L1430:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/analyzetext.json#L1555:11 Old: Language/stable/2022-05-01/analyzetext.json#L1454:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/analyzetext.json#L1677:11 Old: Language/stable/2022-05-01/analyzetext.json#L1559:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/analyzetext.json#L2512:11 Old: Language/stable/2022-05-01/analyzetext.json#L1728:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
|
| The '$ref' property points to different models in the old and new versions. New: cognitiveservices/data-plane/Language/common.json#L383:11 Old: Language/stable/2022-05-01/analyzetext.json#L517:11 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| release_2022-07-01-preview | release_2022-07-01-preview(8c1ba26) | release_2022-07-01-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: cognitiveservices/data-plane/Language/common.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @wangyuantao, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
fillmore
reviewed
Dec 8, 2022
wangyuantao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design consideration: