-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iothub: fixing a constant naming bug #21710
base: main
Are you sure you want to change the base?
Conversation
Swagger pipeline started successfully, please wait for status update in this comment. |
1 similar comment
Swagger pipeline started successfully, please wait for status update in this comment. |
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon. |
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
455be4c
to
2a8e952
Compare
Swagger Generation Artifacts
|
Generated ApiView
|
ping @rkmanda @tianxchen-ms - any update on this one? |
Please address or respond to feedback from the ARM API reviewer. |
Hi @tombuildsstuff! The automation detected breaking changes in this pull request. As a result, it added the |
Hi @tombuildsstuff! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
Per the comment above:
So AFAICT this PR is good to review / the build failures are misleading and this is waiting on the Service Team to review this |
Hi @rkmanda, @tianxchen-ms, since this PR has been signedoff, could you kindly help approve and merge this PR? Thanks. |
Pl fix the model validation and prettier required checks |
Once you have fixed the modelvalidation and prettier required checks, add the label "Mergerequested" to bring this back to the merge queue |
Next Steps to MergeNext steps that must be taken to merge this PR:
|
These two constants have the same name but different values, thus aren't valid.
This includes an autorest directive to ensure the Azure SDK keeps outputting the existing name
da1fae1
to
495983c
Compare
@rkmanda the I believe that's everything needed for this one, but lmk if there's anything else? |
@rkmanda any update on this one? |
@tombuildsstuff I have removed the |
These two constants have the same name but different values, thus aren't valid.