[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

vineetmimrot · 2022-11-21T15:53:28Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
January, 2023
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-11-21T15:53:31Z

Hi, @vineetmimrot Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-11-21T15:53:31Z

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
networkSecurityPerimeter.json	2021-02-01-preview(4f9f6a3)	2021-02-01-preview(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1798:9 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1780:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1913:9 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1890:9
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'remotePerimeterLocation' in response that was not found in the old version. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1797:7 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1779:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'remotePerimeterLocation' in response that was not found in the old version. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1912:7 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1889:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'remotePerimeterLocation' that was not found in the old version. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1797:7 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1779:7
`❌` 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'name' than the previous one. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1798:9 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1780:9
`❌` 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'name' than the previous one. New: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1913:9 Old: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1890:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2021-02-preview	package-2021-02-preview(4f9f6a3)	package-2021-02-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` TrackedResourcePatchOperation	Tracked resource 'NetworkSecurityPerimeter' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L37
`❌` TrackedResourcePatchOperation	Tracked resource 'NspProfile' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L241
`❌` TrackedResourcePatchOperation	Tracked resource 'NspAccessRule' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L406
`❌` TrackedResourcePatchOperation	Tracked resource 'NspAssociation' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L577
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L664
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'NetworkSecurityPerimeter' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1305
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'NspProfile' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1372
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'NspAccessRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1435
`❌` RequiredPropertiesMissingInResourceModel	Model definition 'NspAssociation' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1563
⚠️ PreviewVersionOverOneYear	The API version:2021-02-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L6
⚠️ RequiredReadOnlySystemData	The response of operation:'NetworkSecurityPerimeters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L52
⚠️ RequiredReadOnlySystemData	The response of operation:'NetworkSecurityPerimeters_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L78
⚠️ RequiredReadOnlySystemData	The response of operation:'NspProfiles_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L259
⚠️ RequiredReadOnlySystemData	The response of operation:'NspProfiles_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L285
⚠️ RequiredReadOnlySystemData	The response of operation:'NspAccessRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L427
⚠️ RequiredReadOnlySystemData	The response of operation:'NspAccessRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L453
⚠️ RequiredReadOnlySystemData	The response of operation:'NspAssociations_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L595
⚠️ RequiredReadOnlySystemData	The response of operation:'NspAssociations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L621
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'reconcile' in:'NspAssociationReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L774
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'reconcile' in:'NspAccessRulesReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L872
⚠️ RequiredReadOnlySystemData	The response of operation:'NspLinks_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L924
⚠️ RequiredReadOnlySystemData	The response of operation:'NspLinks_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L950
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'reconcile' in:'NspLinkReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1106
⚠️ RequiredReadOnlySystemData	The response of operation:'NspLinkReferences_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1144
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'reconcile' in:'NspLinkReferenceReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1283

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-21T15:53:32Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-network - 31.0.0

+	Interface DdosProtectionPlan no longer has parameter publicIpAddresses

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Network.25.0.0.nupkg
- Microsoft.Azure.Management.Network.25.0.0.symbols.nupkg

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:698
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 698 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Network [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model BackendAddressPool has a new parameter virtual_network
info	[Changelog]   - Model NetworkVirtualAppliance has a new parameter delegation
info	[Changelog]   - Model NetworkVirtualAppliance has a new parameter deployment_type
info	[Changelog]   - Model NetworkVirtualAppliance has a new parameter partner_managed_resource
info	[Changelog]   - Model NspLink has a new parameter remote_perimeter_location
info	[Changelog]   - Model NspLinkReference has a new parameter remote_perimeter_location
info	[Changelog]   - Model PolicySettings has a new parameter custom_block_response_body
info	[Changelog]   - Model PolicySettings has a new parameter custom_block_response_status_code

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `DelegationProperties`
info	[Changelog] - New struct `PartnerManagedResourceProperties`
info	[Changelog] - New field `VirtualNetwork` in struct `BackendAddressPoolPropertiesFormat`
info	[Changelog] - New field `CustomBlockResponseBody` in struct `PolicySettings`
info	[Changelog] - New field `CustomBlockResponseStatusCode` in struct `PolicySettings`
info	[Changelog] - New field `Delegation` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `DeploymentType` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `PartnerManagedResource` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 7 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-network-31.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface DdosProtectionPlansDeleteHeaders
info	[Changelog]   - Added Interface DelegationProperties
info	[Changelog]   - Added Interface PartnerManagedResourceProperties
info	[Changelog]   - Added Interface PublicIPAddressesDdosProtectionStatusHeaders
info	[Changelog]   - Added Interface PublicIPAddressesDeleteHeaders
info	[Changelog]   - Interface BackendAddressPool has a new optional parameter virtualNetwork
info	[Changelog]   - Interface DdosProtectionPlan has a new optional parameter publicIPAddresses
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter delegation
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter deploymentType
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter partnerManagedResource
info	[Changelog]   - Interface PolicySettings has a new optional parameter customBlockResponseBody
info	[Changelog]   - Interface PolicySettings has a new optional parameter customBlockResponseStatusCode
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface DdosProtectionPlan no longer has parameter publicIpAddresses

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 62c8da7. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.network [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-21T15:53:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/b47a0a36e30e461589268f8bb6ed8cc5
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/985915f9cd954963bd61b30c1d7f0615
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/4545f94dd0d34f7680d6f4d670821cb9
Python	track2_azure-mgmt-network	https://apiview.dev/Assemblies/Review/4b0776d6d7af4ff18d0f72ae08c94c24

openapi-workflow-bot · 2022-11-21T16:08:20Z

Hi @vineetmimrot, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2022-11-21T16:08:20Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

vineetmimrot · 2022-11-22T10:20:39Z

...ce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json

@@ -6,6 +6,7 @@
    "resourceGroupName": "rg1",
    "networkSecurityPerimeterName": "nsp1",
    "profileName": "profile1",
+    "accessRuleName": "accessRule1",


This change is done to fix model validation check . No change is made in its API swagger.

vineetmimrot · 2022-11-28T05:42:41Z

Hey @Azure/arm-api-review-board
Can someone please review the changes.

…n preview/2021-02-01-preview for NSP Link feature (Azure#21617) * Update NSP Link Swagger * fix model validation

Update NSP Link Swagger

9bdf653

ghost added the Network label Nov 21, 2022

vineetmimrot changed the title ~~[Hub Generated] Review request for Microsoft.Network to add version preview/2021-02-01-preview~~ [Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature Nov 21, 2022

azure-sdk mentioned this pull request Nov 21, 2022

[AutoPR sdk/resourcemanager/network/armnetwork] [Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature azure-sdk/azure-sdk-for-go#3626

Closed

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NewApiVersionRequired resource-manager labels Nov 21, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Nov 21, 2022

fix model validation

4f9f6a3

vineetmimrot marked this pull request as ready for review November 22, 2022 09:46

vineetmimrot requested a review from MikhailTryakhov as a code owner November 22, 2022 09:46

openapi-assignment-bot bot assigned raych1 Nov 22, 2022

vineetmimrot commented Nov 22, 2022

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 22, 2022

vineetmimrot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 22, 2022

vineetmimrot added the ARMReview label Nov 30, 2022

raych1 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 30, 2022

raych1 removed the ARMReview label Nov 30, 2022

raych1 approved these changes Nov 30, 2022

View reviewed changes

raych1 merged commit 62c8da7 into Azure:main Nov 30, 2022

ladonnaq mentioned this pull request Oct 18, 2023

Bug - Can't find release plans and API Spec work item missing Azure/azure-sdk-tools#7148

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

vineetmimrot commented Nov 21, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 21, 2022

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 21, 2022

openapi-workflow-bot bot commented Nov 21, 2022

vineetmimrot Nov 22, 2022

vineetmimrot commented Nov 28, 2022

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

Conversation

vineetmimrot commented Nov 21, 2022 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 21, 2022

openapi-pipeline-app bot commented Nov 21, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 21, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 21, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Nov 21, 2022

openapi-workflow-bot bot commented Nov 21, 2022

vineetmimrot Nov 22, 2022

Choose a reason for hiding this comment

vineetmimrot commented Nov 28, 2022

vineetmimrot commented Nov 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 21, 2022 •

edited

Loading