-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Replicas_ListByServer to postgres flexible server 2022-03-08-preview #21424
Add Replicas_ListByServer to postgres flexible server 2022-03-08-preview #21424
Conversation
Hi, @alanenriqueo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.1)] | new version | base version |
---|---|---|
2022-03-08-preview | 2022-03-08-preview(ef004ed) | 2022-03-08-preview(main) |
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/ef004edcd771fc275dd3a884c7a42db6ccba3ee1/specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview", "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.43/common/temp/node_modules/.pnpm/@Azure+oad@0.10.1/node_modules/autorest/dist/app.js /tmp/readme.oad.old.md --v2 --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/compose - FAILED\nFATAL: Error: '$.definitions.Sku.description' has incompatible values (---\nThe resource model definition representing SKU\n, ---\nSku information related properties of a server.\n).\n Error: '$.definitions.Sku.description' has incompatible values (---\nThe resource model definition representing SKU\n, ---\nSku information related properties of a server.\n).\n" |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 2 Errors, 0 Warnings failed [Detail]
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
AutoRest exception |
"location":"specification/postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2022-03-preview", "details":"swagger-document/compose - FAILED" |
|
AutoRest exception |
"location":"specification/postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2022-03-preview", "details":"Error: '$.definitions.Sku.description' has incompatible values (---The resource model definition representing SKU, ---Sku information related properties of a server.)." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Administrators_Create' Request Model: 'ActiveDirectoryAdministratorAdd' Response Model: 'ActiveDirectoryAdministrator' Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Administrators.json#L38 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @alanenriqueo, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
...l/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json
Outdated
Show resolved
Hide resolved
Hi, @alanenriqueo your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
@@ -85,6 +85,9 @@ | |||
"$ref": "#/definitions/ActiveDirectoryAdministrator" | |||
} | |||
}, | |||
"202": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our RP we have a lot of PUT operations that return 202. We'll fix it later, but for now we need to keep 202 in this API, and we've had this issue before: #21234 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkmanda looped you in the chat history we had earlier with Tim during earlier review regarding PUT calls returning 202.
The diffs for replicationRole changes are not clear when I do a diff between the 1st and last iterations of the PR. Refers to: specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json:509 in ef004ed. [](commit_id = ef004ed, deletion_comment = False) |
Is every file in this PR new changes? If any of them are from previous API version, please follow this: In reply to: 1309696792 Refers to: specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json:509 in b9dbea9. [](commit_id = b9dbea9, deletion_comment = False) |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
This breaking change and lintDiff is existing issue. Service team already plan to fix it. |
… server 2022-03-08-preview (#2660) Create to sync Azure/azure-rest-api-specs#21424 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/postgresql?expand=1)
…iew (Azure#21424) * Add Replicas_ListByServer to postgres package-flexibleserver-2022-03-preview * Fix lintDiff * Fix lintDiff * Move Replicas_ListByServer to Replicas.json * Add 202 response to Administrators_Create
…iew (Azure#21424) * Add Replicas_ListByServer to postgres package-flexibleserver-2022-03-preview * Fix lintDiff * Fix lintDiff * Move Replicas_ListByServer to Replicas.json * Add 202 response to Administrators_Create
Replicas_ListByServer
operation to postgres flexible server 2022-03-08-preview.replicationRole
property to modelServerPropertiesForUpdate
.None
toreplicationRole
enum.Administrators_Create
.ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.