-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/v sparatala/merge all v2 to v1 #20748
Users/v sparatala/merge all v2 to v1 #20748
Conversation
This reverts commit 5513349.
…yptions_CreateOrUpdate
…ratala/MergeAllV2ToV1
…' into users/v-sparatala/MergeAllV2ToV1
…v-sparatala/MergeAllV2ToV1
…' into users/v-sparatala/MergeAllV2ToV1
…o users/v-sparatala/MergeAllV2ToV1
…into users/v-sparatala/MergeAllV2ToV1
This reverts commit dcc8c98.
Hi @sparatala, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
* Updated SqlPoolTransparentDataEncryptions_CreateOrUpdate ErrorResponse from V2 to V1 * Updated IntegrationRuntimes_ListByWorkspace ErrorResponse from V2 to V1 types json * Updated SqlPoolsDatawareHouseQueries_Get path V2 to V1 * Updated SqlPoolTransparentDataEncryptions_Get ErrorResponse from V2 to V1 * Updated IntegrationRuntimes_Stop ErrorResponse path V2 to V1 * Updated IntegrationRuntimeConnectionInfos_Get ErrorResponse V2 to V1 * Updated Keys_Delete ErrorResponse V2 to V1 types json * Update Keys_CreateOrUpdate ErrorResponse V2 to V1 types json * Fix Lint Error * Fix lint error * Fix lint, model validation error * Fix lint error * Fix Model validation error * Revert "Fix Model validation error" This reverts commit 5513349. * Fix Model validation * Fix Lint errors * Fix Model Validation Error * Fix Lint error * Fix Lint error * Fix lint error * Resolve Model validation error * Fix OBJECT_ADDITIONAL_PROPERTIES error * Fix RESPONSE_SCHEMA_NOT_IN_SPEC error * Revert "Fix Model validation" This reverts commit dcc8c98. * Fix LRO_RESPONSE_HEADER error * Fix R4041 - XmsIdentifierValidation lint error * Fix R4007 - DefaultErrorResponseSchema lint error
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.