Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Review] PostgreSQL 2022-03-08-preview API #20632

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

DaeunYim
Copy link
Contributor

@DaeunYim DaeunYim commented Sep 8, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…/2022-01-20-preview to version 2022-03-08-preview
@DaeunYim DaeunYim requested a review from msyyc as a code owner September 8, 2022 00:16
@openapi-workflow-bot
Copy link

Hi, @DaeunYim Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 17 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    Databases.json 2022-03-08-preview(ef4e8bc) 2021-06-01(main)
    Databases.json 2022-03-08-preview(ef4e8bc) 2022-01-20-preview(main)
    PrivateDnsZone.json 2022-03-08-preview(ef4e8bc) 2021-06-01(main)
    PrivateDnsZone.json 2022-03-08-preview(ef4e8bc) 2022-01-20-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L69:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L69:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L255:9
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L253:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L78:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L78:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L84:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L84:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L93:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L93:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L140:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L140:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L178:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L178:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L184:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L184:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L278:11
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L276:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L226:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L226:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L238:5
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L238:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L252:5
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L251:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L290:5
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/Databases.json#L288:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/PrivateDnsZone.json#L63:13
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/PrivateDnsZone.json#L63:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/PrivateDnsZone.json#L76:5
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/PrivateDnsZone.json#L76:5

    Rule Message
    ⚠️ APIsBeingMovedToANewSpec "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:GetCachedServerName_Execute;",
    "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/CachedServerName.json"
    ⚠️ APIsBeingMovedToANewSpec "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:Operations_List;",
    "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Operations.json"
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 8 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-flexibleserver-2022-03-privatepreview package-flexibleserver-2022-03-privatepreview(ef4e8bc) default(main)
    package-flexibleserver-2022-03-preview package-flexibleserver-2022-03-preview(ef4e8bc) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Administrators_Create' Request Model: 'ActiveDirectoryAdministratorAdd' Response Model: 'ActiveDirectoryAdministrator'
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Administrators.json#L38
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getcachedservername' in:'GetCachedServerName_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/CachedServerName.json#L42
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fastProvisioningSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L357
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: activeDirectoryAuthEnabled
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L706
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: passwordAuthEnabled
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L710
    ⚠️ R4021 - DescriptionAndTitleMissing 'FastProvisioningEditionCapability' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L212
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedFastProvisioningEditions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L362
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ServerGet
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L226


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'LocationBasedCapabilitiesExecute' response has model definition 'x-ms-pageable', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L42
    ⚠️ R1005 - GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L42
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'Configurations_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Configuration.json#L186
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Operations.json#L38
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/CheckNameAvailability.json#L42
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/PrivateDnsZone.json#L42
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'VirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/VirtualNetwork.json#L42
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: geoBackupSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L326
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L331
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaAndGeoBackupSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L336
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/CheckNameAvailability.json#L109
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDynamicConfig
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Configuration.json#L282
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isReadOnly
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Configuration.json#L287
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isConfigPendingRestart
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Configuration.json#L292
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Operations.json#L111
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: restartWithFailover
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/ServerStartStopRestart.json#L182
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedVcores' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L151
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedStorageMB' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L175
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedFlexibleServerEditions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L341
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedHyperscaleNodeEditions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Capabilities.json#L349
    ⚠️ R4021 - DescriptionAndTitleMissing 'ServerPropertiesForUpdate' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L551
    ⚠️ R4021 - DescriptionAndTitleMissing 'delegatedSubnetsUsage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/VirtualNetwork.json#L100
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Update a user configuration
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Configuration.json#L187
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: FirewallRuleList
    Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FirewallRules.json#L197
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.DBforPostgreSQL' for api version '2022-03-08-preview'. The supported api-versions are '2021-06-01-preview,
    2021-06-01,
    2022-01-20-preview,
    2017-12-01-preview,
    2017-12-01'."
    ️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ASSERTION_ERROR "ResourceType 'flexibleServers' should be deployed in 'West Central US' on apiVersion '2022-03-08-preview'.: expected [ Array(39) ] to satisfy [Function]"
    ️❌~[Staging] TrafficValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ASSERTION_ERROR "ResourceType 'flexibleServers' should be deployed in 'West Central US' on apiVersion '2022-03-08-preview'.: expected [ Array(39) ] to satisfy [Function]"
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 2 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/ef4e8bc90aae5855402ac971791fb936ad60852c/specification/postgresql/resource-manager/readme.md#tag-package-flexibleserver-2022-03-preview">postgresql/resource-manager/readme.md#package-flexibleserver-2022-03-preview
      • "https://github.com/Azure/azure-rest-api-specs/blob/ef4e8bc90aae5855402ac971791fb936ad60852c/specification/postgresql/resource-manager/readme.md#tag-package-flexibleserver-2022-03-privatepreview">postgresql/resource-manager/readme.md#package-flexibleserver-2022-03-privatepreview
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"postgresql/resource-manager/readme.md",
    "tag":"package-flexibleserver-2022-03-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"postgresql/resource-manager/readme.md",
    "tag":"package-flexibleserver-2022-03-privatepreview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/postgresql/armpostgresql - 2.0.0
    +	Struct `CloudError` has been removed
    azure-sdk-for-go - sdk/resourcemanager/postgresql/armpostgresqlflexibleservers - 2.0.0
    +	Struct `CloudError` has been removed

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.PostgreSql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest]   File "src/black/_init__.py", line 1173, in _format_stronce
      cmdout	[automation_generate.sh] [Autorest]   File "src/black/parsing.py", line 128, in lib2to3_parse
      cmdout	[automation_generate.sh] [Autorest] black.parsing.InvalidInput: Cannot parse: 267:38:         passwordauthenabled: bool = ,
      cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
      cmdout	[automation_generate.sh] [Autorest] error   | Batch/Error | Failure during batch task - {"tag":"package-flexibleserver-2022-03-preview"}  -- Error: Plugin black reported failure.
      cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin black reported failure.
      cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmdout	[automation_generate.sh] [Autorest]   File "src/black/_init__.py", line 1173, in _format_stronce
      cmdout	[automation_generate.sh] [Autorest]   File "src/black/parsing.py", line 128, in lib2to3_parse
      cmdout	[automation_generate.sh] [Autorest] black.parsing.InvalidInput: Cannot parse: 267:38:         passwordauthenabled: bool = ,
      cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
      cmdout	[automation_generate.sh] [Autorest] error   | Batch/Error | Failure during batch task - {"tag":"package-flexibleserver-2022-03-preview"}  -- Error: Plugin black reported failure.
      cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin black reported failure.
      cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • postgresql/resource-manager [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 93dd8364eac5175da740d40771c6def605ff0760. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.PostgreSql [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/postgresql/armpostgresql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-postgresqlflexibleserver Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.PostgreSql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @DaeunYim, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants