-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add property "priorityMixPolicy" to VMSS Specification for version 2022-08-01 #20079
Add property "priorityMixPolicy" to VMSS Specification for version 2022-08-01 #20079
Conversation
… of creating a vmss with the property included
Hi, @aleclawlor Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
virtualMachineScaleSet.json | 2022-08-01(3c59378) | 2022-03-01(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-08-01 | package-2022-08-01(3c59378) | package-2022-08-01(feature/cplat-2022-08-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L1911 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L5679 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetVMExtension' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3408 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetVMExtensionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3432 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetVMExtensionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3456 |
R4037 - MissingTypeObject |
The schema 'AutomaticRepairsPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3478 |
R4037 - MissingTypeObject |
The schema 'AutomaticOSUpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3504 |
R4037 - MissingTypeObject |
The schema 'UpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3521 |
R4037 - MissingTypeObject |
The schema 'RollingUpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3547 |
R4037 - MissingTypeObject |
The schema 'ScaleInPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3585 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3655 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetOSProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3688 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateOSProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3732 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetManagedDiskParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3759 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetOSDisk' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3776 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateOSDisk' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3840 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetDataDisk' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3877 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetStorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3930 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateStorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3954 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetIPConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L3978 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateIPConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4035 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4092 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4113 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetNetworkConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4131 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateNetworkConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4182 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetNetworkConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4230 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetUpdateNetworkConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4251 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetNetworkConfigurationDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4269 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetPublicIPAddressConfigurationDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4281 |
R4037 - MissingTypeObject |
The schema 'VirtualMachineScaleSetIpTag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4293 |
️⚠️
Avocado: 1 Warnings warning [Detail]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/3c59378381f6f45b5cbb2f508f4aba2dfc57c8be/specification/compute/resource-manager/readme.md#tag-package-2022-08-01">compute/resource-manager/readme.md#package-2022-08-01
- "https://github.com/Azure/azure-rest-api-specs/blob/3c59378381f6f45b5cbb2f508f4aba2dfc57c8be/specification/compute/resource-manager/readme.md#tag-package-2022-08-01-only">compute/resource-manager/readme.md#package-2022-08-01-only
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-08-01", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1403", "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-08-01", "details":"Error: 1 errors occured -- cannot continue." |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-08-01-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Generated ApiView
|
…property-to-vmss-spec Integrate changes that stop sdk build from failing
...e/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json
Outdated
Show resolved
Hide resolved
...e/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json
Outdated
Show resolved
Hide resolved
…caused creation failure with Flexible orchestration
Hi @aleclawlor, Your PR has some issues. Please fix the CI sequentially by following the order of
|
** please note that this feature is intended for Public Preview
The property allows customers to specify target splits between Spot and Regular priority VM's in a VMSS Flex Scale Set instance.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.