Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'daorozcoABACGA' #19937

Merged
merged 25 commits into from
Jul 27, 2022

Conversation

zhihaoxue
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@zhihaoxue
Copy link
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/6248

@openapi-workflow-bot
Copy link

Hi, @zhihaoxue Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 25, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 8 Errors, 48 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    authorization-ProviderOperationsCalls.json 2022-04-01(689b9ee) 2015-07-01(main)
    authorization-ProviderOperationsCalls.json 2022-04-01(689b9ee) 2018-01-01-preview(main)
    authorization-RoleAssignmentsCalls.json 2022-04-01(689b9ee) 2015-07-01(main)
    authorization-RoleAssignmentsCalls.json 2022-04-01(689b9ee) 2020-10-01-preview(main)
    authorization-RoleDefinitionsCalls.json 2022-04-01(689b9ee) 2015-07-01(main)
    authorization-RoleDefinitionsCalls.json 2022-04-01(689b9ee) 2018-01-01-preview(main)
    common-types.json 2022-04-01(689b9ee) 2020-10-01(main)
    common-types.json 2022-04-01(689b9ee) 2020-10-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}/providers/Microsoft.Authorization/roleAssignments' removed or restructured?
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{roleDefinitionId}' removed or restructured?
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleDefinitionsCalls.json#L355:5
    1008 - ModifiedOperationId The operation id has been changed from 'RoleAssignments_List' to 'RoleAssignments_ListForSubscription'. This will impact generated code.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L38:7
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L451:7
    1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L258:11
    1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L438:11
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L561:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L562:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L550:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L610:9
    1034 - AddedRequiredProperty The new version has new required property 'roleDefinitionId, principalId' that was not found in the old version.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L654:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L594:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L63:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L67:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L200:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L198:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L139:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L143:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L210:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L208:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L104:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L108:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L224:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L221:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L127:5
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L131:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L149:5
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L152:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L180:5
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L178:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-ProviderOperationsCalls.json#L220:5
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L217:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L110:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L145:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L545:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L605:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L654:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L594:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L214:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L301:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L237:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L243:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L237:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L636:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L254:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L255:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L306:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L197:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L397:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L432:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L434:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L393:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L477:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L342:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L61:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L475:13


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Authorization/roleAssignments/{roleAssignmentName}/validate' removed or restructured?
    Old: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L327:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{roleAssignmentId}/validate' removed or restructured?
    Old: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L540:5

    Rule Message
    ⚠️ APIsBeingMovedToANewSpec "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:DenyAssignments_ListForScope;",
    "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/authorization/resource-manager/Microsoft.Authorization/stable/2022-04-01/authorization-DenyAssignmentCalls.json"
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-04-01 package-2022-04-01(689b9ee) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/689b9eee7bf0aeba5301ce69621ee2c8dae90cc4/specification/authorization/resource-manager/readme.md#tag-package-2022-04-01">authorization/resource-manager/readme.md#package-2022-04-01
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2022-04-01",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 25, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armauthorization - 2.0.0-beta.2
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-authorization - 2.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from d8bad7c. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d8bad7c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-authorization [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation AccessReviewInstancesOperations.create
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionInstanceOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionInstancesOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionsOperations
      info	[Changelog]   - Added operation group AccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewDefaultSettingsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionInstanceOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionInstancesOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceDecisionsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstancesOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewScheduleDefinitionsOperations
      info	[Changelog]   - Added operation group TenantLevelAccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Model AccessReviewDecision has a new parameter insights
      info	[Changelog]   - Model AccessReviewDecision has a new parameter membership_types
      info	[Changelog]   - Model AccessReviewDecisionProperties has a new parameter insights
      info	[Changelog]   - Model AccessReviewDecisionProperties has a new parameter membership_types
      info	[Changelog]   - Model AccessReviewDefaultSettings has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewInstance has a new parameter backup_reviewers
      info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers
      info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers_type
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter exclude_resource_id
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter exclude_role_definition_id
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter expand_nested_memberships
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter include_access_below_resource
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter include_inherited_access
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter exclude_resource_id
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter exclude_role_definition_id
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter expand_nested_memberships
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter include_access_below_resource
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter include_inherited_access
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewScheduleSettings has a new parameter recommendation_look_back_duration
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d8bad7c. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armauthorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - Type of `AccessReviewDecisionProperties.Resource` has been changed from `AccessReviewDecisionResourceClassification` to `*AccessReviewDecisionResource`
      info	[Changelog] - Function `*AccessReviewDecisionResource.GetAccessReviewDecisionResource` has been removed
      info	[Changelog] - Function `*AccessReviewDecisionResourceAzureRole.GetAccessReviewDecisionResource` has been removed
      info	[Changelog] - Struct `AccessReviewDecisionResourceAzureRole` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RecordAllDecisionsResultApprove`
      info	[Changelog] - New const `AccessReviewDecisionPrincipalResourceMembershipTypeIndirect`
      info	[Changelog] - New const `RecordAllDecisionsResultDeny`
      info	[Changelog] - New const `AccessReviewDecisionInsightTypeUserSignInInsight`
      info	[Changelog] - New const `AccessReviewDecisionPrincipalResourceMembershipTypeDirect`
      info	[Changelog] - New function `*ScopeAccessReviewScheduleDefinitionsClient.GetByID(context.Context, string, string, *ScopeAccessReviewScheduleDefinitionsClientGetByIDOptions) (ScopeAccessReviewScheduleDefinitionsClientGetByIDResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceClient.SendReminders(context.Context, string, string, string, *ScopeAccessReviewInstanceClientSendRemindersOptions) (ScopeAccessReviewInstanceClientSendRemindersResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewScheduleDefinitionsClient.DeleteByID(context.Context, string, string, *ScopeAccessReviewScheduleDefinitionsClientDeleteByIDOptions) (ScopeAccessReviewScheduleDefinitionsClientDeleteByIDResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceClient.RecordAllDecisions(context.Context, string, string, string, RecordAllDecisionsProperties, *ScopeAccessReviewInstanceClientRecordAllDecisionsOptions) (ScopeAccessReviewInstanceClientRecordAllDecisionsResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionClient.DeleteByID(context.Context, string, string, *ScopeAccessReviewHistoryDefinitionClientDeleteByIDOptions) (ScopeAccessReviewHistoryDefinitionClientDeleteByIDResponse, error)`
      info	[Changelog] - New function `NewScopeAccessReviewInstanceDecisionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewInstanceDecisionsClient, error)`
      info	[Changelog] - New function `NewScopeAccessReviewDefaultSettingsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewDefaultSettingsClient, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceClient.ResetDecisions(context.Context, string, string, string, *ScopeAccessReviewInstanceClientResetDecisionsOptions) (ScopeAccessReviewInstanceClientResetDecisionsResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewScheduleDefinitionsClient.CreateOrUpdateByID(context.Context, string, string, AccessReviewScheduleDefinitionProperties, *ScopeAccessReviewScheduleDefinitionsClientCreateOrUpdateByIDOptions) (ScopeAccessReviewScheduleDefinitionsClientCreateOrUpdateByIDResponse, error)`
      info	[Changelog] - New function `NewScopeAccessReviewHistoryDefinitionInstancesClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewHistoryDefinitionInstancesClient, error)`
      info	[Changelog] - New function `NewScopeAccessReviewHistoryDefinitionInstanceClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewHistoryDefinitionInstanceClient, error)`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionsClient.GetByID(context.Context, string, string, *ScopeAccessReviewHistoryDefinitionsClientGetByIDOptions) (ScopeAccessReviewHistoryDefinitionsClientGetByIDResponse, error)`
      info	[Changelog] - New function `PossibleAccessReviewDecisionInsightTypeValues() []AccessReviewDecisionInsightType`
      info	[Changelog] - New function `*ScopeAccessReviewScheduleDefinitionsClient.Stop(context.Context, string, string, *ScopeAccessReviewScheduleDefinitionsClientStopOptions) (ScopeAccessReviewScheduleDefinitionsClientStopResponse, error)`
      info	[Changelog] - New function `PossibleAccessReviewDecisionPrincipalResourceMembershipTypeValues() []AccessReviewDecisionPrincipalResourceMembershipType`
      info	[Changelog] - New function `NewScopeAccessReviewHistoryDefinitionClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewHistoryDefinitionClient, error)`
      info	[Changelog] - New function `*ScopeAccessReviewDefaultSettingsClient.Get(context.Context, string, *ScopeAccessReviewDefaultSettingsClientGetOptions) (ScopeAccessReviewDefaultSettingsClientGetResponse, error)`
      info	[Changelog] - New function `NewScopeAccessReviewInstanceClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewInstanceClient, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstancesClient.GetByID(context.Context, string, string, string, *ScopeAccessReviewInstancesClientGetByIDOptions) (ScopeAccessReviewInstancesClientGetByIDResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceDecisionsClient.NewListPager(string, string, string, *ScopeAccessReviewInstanceDecisionsClientListOptions) *runtime.Pager[ScopeAccessReviewInstanceDecisionsClientListResponse]`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionsClient.NewListPager(string, *ScopeAccessReviewHistoryDefinitionsClientListOptions) *runtime.Pager[ScopeAccessReviewHistoryDefinitionsClientListResponse]`
      info	[Changelog] - New function `NewScopeAccessReviewInstanceContactedReviewersClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewInstanceContactedReviewersClient, error)`
      info	[Changelog] - New function `*AccessReviewDecisionInsightProperties.GetAccessReviewDecisionInsightProperties() *AccessReviewDecisionInsightProperties`
      info	[Changelog] - New function `*ScopeAccessReviewInstancesClient.Create(context.Context, string, string, string, AccessReviewInstanceProperties, *ScopeAccessReviewInstancesClientCreateOptions) (ScopeAccessReviewInstancesClientCreateResponse, error)`
      info	[Changelog] - New function `PossibleRecordAllDecisionsResultValues() []RecordAllDecisionsResult`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionInstancesClient.NewListPager(string, string, *ScopeAccessReviewHistoryDefinitionInstancesClientListOptions) *runtime.Pager[ScopeAccessReviewHistoryDefinitionInstancesClientListResponse]`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceClient.Stop(context.Context, string, string, string, *ScopeAccessReviewInstanceClientStopOptions) (ScopeAccessReviewInstanceClientStopResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstancesClient.NewListPager(string, string, *ScopeAccessReviewInstancesClientListOptions) *runtime.Pager[ScopeAccessReviewInstancesClientListResponse]`
      info	[Changelog] - New function `*ScopeAccessReviewDefaultSettingsClient.Put(context.Context, string, AccessReviewScheduleSettings, *ScopeAccessReviewDefaultSettingsClientPutOptions) (ScopeAccessReviewDefaultSettingsClientPutResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionInstanceClient.GenerateDownloadURI(context.Context, string, string, string, *ScopeAccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIOptions) (ScopeAccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewHistoryDefinitionClient.Create(context.Context, string, string, AccessReviewHistoryDefinitionProperties, *ScopeAccessReviewHistoryDefinitionClientCreateOptions) (ScopeAccessReviewHistoryDefinitionClientCreateResponse, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceContactedReviewersClient.NewListPager(string, string, string, *ScopeAccessReviewInstanceContactedReviewersClientListOptions) *runtime.Pager[ScopeAccessReviewInstanceContactedReviewersClientListResponse]`
      info	[Changelog] - New function `*ScopeAccessReviewScheduleDefinitionsClient.NewListPager(string, *ScopeAccessReviewScheduleDefinitionsClientListOptions) *runtime.Pager[ScopeAccessReviewScheduleDefinitionsClientListResponse]`
      info	[Changelog] - New function `NewScopeAccessReviewHistoryDefinitionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewHistoryDefinitionsClient, error)`
      info	[Changelog] - New function `*AccessReviewDecisionUserSignInInsightProperties.GetAccessReviewDecisionInsightProperties() *AccessReviewDecisionInsightProperties`
      info	[Changelog] - New function `NewScopeAccessReviewScheduleDefinitionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewScheduleDefinitionsClient, error)`
      info	[Changelog] - New function `*ScopeAccessReviewInstanceClient.ApplyDecisions(context.Context, string, string, string, *ScopeAccessReviewInstanceClientApplyDecisionsOptions) (ScopeAccessReviewInstanceClientApplyDecisionsResponse, error)`
      info	[Changelog] - New function `NewScopeAccessReviewInstancesClient(azcore.TokenCredential, *arm.ClientOptions) (*ScopeAccessReviewInstancesClient, error)`
      info	[Changelog] - New struct `AccessReviewDecisionInsight`
      info	[Changelog] - New struct `AccessReviewDecisionInsightProperties`
      info	[Changelog] - New struct `AccessReviewDecisionPrincipalResourceMembership`
      info	[Changelog] - New struct `AccessReviewDecisionUserSignInInsightProperties`
      info	[Changelog] - New struct `RecordAllDecisionsProperties`
      info	[Changelog] - New struct `ScopeAccessReviewDefaultSettingsClient`
      info	[Changelog] - New struct `ScopeAccessReviewDefaultSettingsClientGetOptions`
      info	[Changelog] - New struct `ScopeAccessReviewDefaultSettingsClientGetResponse`
      info	[Changelog] - New struct `ScopeAccessReviewDefaultSettingsClientPutOptions`
      info	[Changelog] - New struct `ScopeAccessReviewDefaultSettingsClientPutResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionClient`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionClientCreateOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionClientCreateResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionClientDeleteByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionClientDeleteByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstanceClient`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstancesClient`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstancesClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionInstancesClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionsClient`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionsClientGetByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionsClientGetByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionsClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewHistoryDefinitionsClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClient`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientApplyDecisionsOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientApplyDecisionsResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientRecordAllDecisionsOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientRecordAllDecisionsResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientResetDecisionsOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientResetDecisionsResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientSendRemindersOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientSendRemindersResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientStopOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceClientStopResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceContactedReviewersClient`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceContactedReviewersClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceContactedReviewersClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceDecisionsClient`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceDecisionsClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstanceDecisionsClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClient`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientCreateOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientCreateResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientGetByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientGetByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewInstancesClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClient`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientCreateOrUpdateByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientCreateOrUpdateByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientDeleteByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientDeleteByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientGetByIDOptions`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientGetByIDResponse`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientListOptions`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientListResponse`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientStopOptions`
      info	[Changelog] - New struct `ScopeAccessReviewScheduleDefinitionsClientStopResponse`
      info	[Changelog] - New field `PrincipalResourceMembership` in struct `AccessReviewDecisionProperties`
      info	[Changelog] - New field `Insights` in struct `AccessReviewDecisionProperties`
      info	[Changelog] - New field `IncludeAccessBelowResource` in struct `AccessReviewScope`
      info	[Changelog] - New field `IncludeInheritedAccess` in struct `AccessReviewScope`
      info	[Changelog] - New field `ExcludeResourceID` in struct `AccessReviewScope`
      info	[Changelog] - New field `ExcludeRoleDefinitionID` in struct `AccessReviewScope`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 168 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d8bad7c. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from d8bad7c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • authorization/resource-manager [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d8bad7c. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Authorization [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @zhihaoxue, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @zhihaoxue, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @@ -177,6 +202,47 @@ input-file:
    - Microsoft.Authorization/preview/2021-01-01-preview/authorization-RoleAssignmentApprovalCalls.json
    ```

    ### Tag: package-2020-10-01
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Why is this being added? It already exists.

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    #20055 will remove these duplicate tags.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants