Feature/cplat 2022 04 04 #19467
Merged
Feature/cplat 2022 04 04 #19467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
|
Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
grizzlytheodore
requested review from
Sandido,
dkulkarni-ms,
haagha,
madewithsmiles,
MS-syh2qs and
hyonholee
as code owners
This was referenced Jun 15, 2022
Closed
ArcturusZhang
pushed a commit
that referenced
this pull request
Jun 23, 2022
* set up branch * Feature/cplat 2022 04 04 (#19467) * set up feature branch * Update cloud service swagger file and examples (#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> * prettier fix Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.