Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureCXP} fixes Azure/azure-sdk-for-python#24694 #19367

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

navba-MSFT
Copy link
Contributor

@navba-MSFT navba-MSFT commented Jun 8, 2022

Including the possible values for the enum of the runbook types

Docs Link: https://docs.microsoft.com/en-us/python/api/azure-mgmt-automation/azure.mgmt.automation.models.runbook?view=azure-python#parameters

fixes Azure/azure-sdk-for-python#24694

In this PR Azure/azure-sdk-for-python#24745, we were asked to fix the REST API Specs before the changes are implemented in SDK.

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Including the possible values for the enum of the runbook types

Docs Link: https://docs.microsoft.com/en-us/python/api/azure-mgmt-automation/azure.mgmt.automation.models.runbook?view=azure-python#parameters

fixes #24694

In this PR  Azure/azure-sdk-for-python#24745, we were asked to fix the REST API Specs before the changes are implemented in SDK.
@openapi-workflow-bot
Copy link

Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L85
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L85
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L85
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L157
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L157
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L157
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L210
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L210
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L210
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L265
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L265
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L265
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L318
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L318
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L318
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L373
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L373
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L373
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L425
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L425
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L425
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L496
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L496
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L496
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L555
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L555
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L555
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L605
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L605
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Automation/stable/2015-10-31/runbook.json#L605
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/automation/resource-manager/readme.md
    tag: specification/automation/resource-manager/readme.md#tag-package-2021-06-22
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 200 for operation RunbookDraft_ReplaceContent were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
    Url: Microsoft.Automation/stable/2015-10-31/runbook.json#L142:18
    ExampleUrl: stable/2015-10-31/examples/replaceRunbookDraftContent.json#L10:16
    RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation RunbookDraft_UndoEdit has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
    Url: Microsoft.Automation/stable/2015-10-31/runbook.json#L311:22
    ExampleUrl: stable/2015-10-31/examples/undoDraftEditToLastKnownPublishedState.json#L9:16
    RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation RunbookDraft_ReplaceContent has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
    Url: Microsoft.Automation/stable/2018-06-30/runbook.json#L141:22
    ExampleUrl: stable/2018-06-30/examples/replaceRunbookDraftContent.json#L10:16
    RESPONSE_SCHEMA_NOT_IN_SPEC Response statusCode 202 for operation RunbookDraft_ReplaceContent has response body provided in the example, however the response does not have a "schema" defined in the swagger spec.
    Url: Microsoft.Automation/stable/2018-06-30/runbook.json#L141:22
    ExampleUrl: stable/2018-06-30/examples/replaceRunbookDraftContent.json#L10:16
    RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation RunbookDraft_UndoEdit has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
    Url: Microsoft.Automation/stable/2018-06-30/runbook.json#L311:22
    ExampleUrl: stable/2018-06-30/examples/undoDraftEditToLastKnownPublishedState.json#L9:16
    RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation Runbook_Update has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
    Url: Microsoft.Automation/stable/2018-06-30/runbook.json#L545:22
    ExampleUrl: stable/2018-06-30/examples/updateRunbook.json#L17:16
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    "readme":"automation/resource-manager/readme.md",
    "tag":"package-2017-05-preview",
    "details":"Error: Plugin prechecker reported failure."
    "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-01-preview",
    "details":"Error: Plugin prechecker reported failure."
    "readme":"automation/resource-manager/readme.md",
    "tag":"package-2018-06-preview",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armautomation - 0.7.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-automation - Approved - 1.1.0b1
    -	Operation DscConfigurationOperations.create_or_update has a new parameter content_type
    -	Operation DscConfigurationOperations.update has a new parameter content_type
    ️✔️azure-sdk-for-go - automation/mgmt/2019-06-01/automation - v65.0.0
    ️✔️azure-sdk-for-go - automation/mgmt/2015-10-31/automation - v65.0.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2021-06-22-preview/automation - v65.0.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2020-01-13-preview/automation - v65.0.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2018-06-30-preview/automation - v65.0.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2018-01-15-preview/automation - v65.0.0
    ️✔️azure-sdk-for-go - preview/automation/mgmt/2017-05-15-preview/automation - v65.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 59b4132. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/automation/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 59b4132. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.12.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.12.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.12.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-automation [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation HybridRunbookWorkerGroupOperations.create
      info	[Changelog]   - Added operation group AutomationClientOperationsMixin
      info	[Changelog]   - Added operation group HybridRunbookWorkersOperations
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]   - Model AutomationAccount has a new parameter automation_hybrid_service_url
      info	[Changelog]   - Model AutomationAccount has a new parameter disable_local_auth
      info	[Changelog]   - Model AutomationAccount has a new parameter encryption
      info	[Changelog]   - Model AutomationAccount has a new parameter identity
      info	[Changelog]   - Model AutomationAccount has a new parameter private_endpoint_connections
      info	[Changelog]   - Model AutomationAccount has a new parameter public_network_access
      info	[Changelog]   - Model AutomationAccount has a new parameter system_data
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter disable_local_auth
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter encryption
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter identity
      info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter public_network_access
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter disable_local_auth
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter encryption
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter identity
      info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter public_network_access
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter id
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter registered_date_time
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter system_data
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter type
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter vm_resource_id
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter worker_name
      info	[Changelog]   - Model HybridRunbookWorker has a new parameter worker_type
      info	[Changelog]   - Model HybridRunbookWorkerGroup has a new parameter system_data
      info	[Changelog]   - Model HybridRunbookWorkerGroup has a new parameter type
      info	[Changelog]   - Operation DscConfigurationOperations.create_or_update has a new optional and keyword-only parameter content_type
      info	[Changelog]   - Operation DscConfigurationOperations.update has a new optional and keyword-only parameter content_type
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model HybridRunbookWorker no longer has parameter registration_time
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 59b4132. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️automation/mgmt/2019-06-01/automation [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RunbookTypeEnumPython2`
      info	[Changelog] - New const `RunbookTypeEnumPython3`
      info	[Changelog] - New field `GroupIds` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
    • ️✔️automation/mgmt/2015-10-31/automation [View full logs
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New function `WatcherListResultIterator.NotDone() bool`
      info	[Changelog] - New function `WatcherClient.Delete(context.Context, string, string, string) (autorest.Response, error)`
      info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `WatcherListResultIterator.Response() WatcherListResult`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointProperty`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
      info	[Changelog] - New struct `Watcher`
      info	[Changelog] - New struct `WatcherClient`
      info	[Changelog] - New struct `WatcherListResult`
      info	[Changelog] - New struct `WatcherListResultIterator`
      info	[Changelog] - New struct `WatcherListResultPage`
      info	[Changelog] - New struct `WatcherProperties`
      info	[Changelog] - New struct `WatcherUpdateParameters`
      info	[Changelog] - New struct `WatcherUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 78 additive change(s).
    • ️✔️preview/automation/mgmt/2021-06-22-preview/automation [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RunbookTypeEnumPython2`
      info	[Changelog] - New const `RunbookTypeEnumPython3`
      info	[Changelog] - New field `GroupIds` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
    • ️✔️preview/automation/mgmt/2020-01-13-preview/automation [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RunbookTypeEnumPython2`
      info	[Changelog] - New const `RunbookTypeEnumPython3`
      info	[Changelog] - New field `GroupIds` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
    • ️✔️preview/automation/mgmt/2018-06-30-preview/automation [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/automation/mgmt/2018-01-15-preview/automation [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/automation/mgmt/2017-05-15-preview/automation [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 59b4132. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armautomation [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `RunbookTypeEnumPython3`
      info	[Changelog] - New const `RunbookTypeEnumPython2`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 59b4132. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️automation [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 59b4132. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.automation [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @raych1
    Copy link
    Member

    raych1 commented Jun 9, 2022

    @msyyc , I assigned this PR to you as you're better person to review this.

    @msyyc msyyc self-requested a review June 10, 2022 05:08
    @msyyc
    Copy link
    Member

    msyyc commented Jun 10, 2022

    Hi @navba-MSFT There are three versions for runbook.json. You update the one under 2019-06-01. I am wondering if the other two also need to be updated:
    image

    @openapi-workflow-bot
    Copy link

    Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @navba-MSFT
    Copy link
    Contributor Author

    @jaspkaur28 Could you please review this PR to avoid any breaking changes in the SDKs ?

    @navba-MSFT
    Copy link
    Contributor Author

    Hi @navba-MSFT There are three versions for runbook.json. You update the one under 2019-06-01. I am wondering if the other two also need to be updated: image

    @msyyc Updated for the remaining versions too.

    @msyyc
    Copy link
    Member

    msyyc commented Jun 14, 2022

    ModelValidation error is not related with this PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Additional "runbook_type" available, update the documentation please
    5 participants